* [PATCH] clk: ti: fix double free in of_ti_divider_clk_setup()
@ 2023-10-02 7:04 Dan Carpenter
2023-10-07 7:21 ` Tony Lindgren
2023-10-19 0:54 ` Stephen Boyd
0 siblings, 2 replies; 3+ messages in thread
From: Dan Carpenter @ 2023-10-02 7:04 UTC (permalink / raw)
To: Tero Kristo
Cc: Tero Kristo, Michael Turquette, Stephen Boyd, Tony Lindgren,
Dario Binacchi, linux-omap, linux-clk, kernel-janitors
The "div" pointer is freed in _register_divider() and again in
of_ti_divider_clk_setup(). Delete the free in _register_divider()
Fixes: fbbc18591585 ("clk: ti: divider: cleanup _register_divider and ti_clk_get_div_table")
Signed-off-by: Dan Carpenter <dan.carpenter@linaro.org>
---
drivers/clk/ti/divider.c | 8 +-------
1 file changed, 1 insertion(+), 7 deletions(-)
diff --git a/drivers/clk/ti/divider.c b/drivers/clk/ti/divider.c
index 768a1f3398b4..5d5bb123ba94 100644
--- a/drivers/clk/ti/divider.c
+++ b/drivers/clk/ti/divider.c
@@ -309,7 +309,6 @@ static struct clk *_register_divider(struct device_node *node,
u32 flags,
struct clk_omap_divider *div)
{
- struct clk *clk;
struct clk_init_data init;
const char *parent_name;
const char *name;
@@ -326,12 +325,7 @@ static struct clk *_register_divider(struct device_node *node,
div->hw.init = &init;
/* register the clock */
- clk = of_ti_clk_register(node, &div->hw, name);
-
- if (IS_ERR(clk))
- kfree(div);
-
- return clk;
+ return of_ti_clk_register(node, &div->hw, name);
}
int ti_clk_parse_divider_data(int *div_table, int num_dividers, int max_div,
--
2.39.2
^ permalink raw reply related [flat|nested] 3+ messages in thread
* Re: [PATCH] clk: ti: fix double free in of_ti_divider_clk_setup()
2023-10-02 7:04 [PATCH] clk: ti: fix double free in of_ti_divider_clk_setup() Dan Carpenter
@ 2023-10-07 7:21 ` Tony Lindgren
2023-10-19 0:54 ` Stephen Boyd
1 sibling, 0 replies; 3+ messages in thread
From: Tony Lindgren @ 2023-10-07 7:21 UTC (permalink / raw)
To: Dan Carpenter
Cc: Tero Kristo, Tero Kristo, Michael Turquette, Stephen Boyd,
Dario Binacchi, linux-omap, linux-clk, kernel-janitors
* Dan Carpenter <dan.carpenter@linaro.org> [231002 10:04]:
> The "div" pointer is freed in _register_divider() and again in
> of_ti_divider_clk_setup(). Delete the free in _register_divider()
Reviewed-by: Tony Lindgren <tony@atomide.com>
^ permalink raw reply [flat|nested] 3+ messages in thread
* Re: [PATCH] clk: ti: fix double free in of_ti_divider_clk_setup()
2023-10-02 7:04 [PATCH] clk: ti: fix double free in of_ti_divider_clk_setup() Dan Carpenter
2023-10-07 7:21 ` Tony Lindgren
@ 2023-10-19 0:54 ` Stephen Boyd
1 sibling, 0 replies; 3+ messages in thread
From: Stephen Boyd @ 2023-10-19 0:54 UTC (permalink / raw)
To: Dan Carpenter, Tero Kristo
Cc: Tero Kristo, Michael Turquette, Tony Lindgren, Dario Binacchi,
linux-omap, linux-clk, kernel-janitors
Quoting Dan Carpenter (2023-10-02 00:04:36)
> The "div" pointer is freed in _register_divider() and again in
> of_ti_divider_clk_setup(). Delete the free in _register_divider()
>
> Fixes: fbbc18591585 ("clk: ti: divider: cleanup _register_divider and ti_clk_get_div_table")
> Signed-off-by: Dan Carpenter <dan.carpenter@linaro.org>
> ---
Applied to clk-next
^ permalink raw reply [flat|nested] 3+ messages in thread
end of thread, other threads:[~2023-10-19 0:54 UTC | newest]
Thread overview: 3+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2023-10-02 7:04 [PATCH] clk: ti: fix double free in of_ti_divider_clk_setup() Dan Carpenter
2023-10-07 7:21 ` Tony Lindgren
2023-10-19 0:54 ` Stephen Boyd
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).