Linux clock framework development
 help / color / mirror / Atom feed
From: Alexandre Mergnat <amergnat@baylibre.com>
To: "Chun-Kuang Hu" <chunkuang.hu@kernel.org>,
	"Philipp Zabel" <p.zabel@pengutronix.de>,
	"Maarten Lankhorst" <maarten.lankhorst@linux.intel.com>,
	"Maxime Ripard" <mripard@kernel.org>,
	"Thomas Zimmermann" <tzimmermann@suse.de>,
	"David Airlie" <airlied@gmail.com>,
	"Daniel Vetter" <daniel@ffwll.ch>,
	"Rob Herring" <robh@kernel.org>,
	"Krzysztof Kozlowski" <krzysztof.kozlowski+dt@linaro.org>,
	"Conor Dooley" <conor+dt@kernel.org>,
	"Matthias Brugger" <matthias.bgg@gmail.com>,
	"AngeloGioacchino Del Regno"
	<angelogioacchino.delregno@collabora.com>,
	"Jitao Shi" <jitao.shi@mediatek.com>,
	"CK Hu" <ck.hu@mediatek.com>,
	"Uwe Kleine-König" <u.kleine-koenig@pengutronix.de>,
	"Michael Turquette" <mturquette@baylibre.com>,
	"Stephen Boyd" <sboyd@kernel.org>,
	"Fabien Parent" <fparent@baylibre.com>,
	"Markus Schneider-Pargmann" <msp@baylibre.com>,
	"Catalin Marinas" <catalin.marinas@arm.com>,
	"Will Deacon" <will@kernel.org>
Cc: dri-devel@lists.freedesktop.org,
	linux-mediatek@lists.infradead.org,  devicetree@vger.kernel.org,
	linux-kernel@vger.kernel.org,
	 linux-arm-kernel@lists.infradead.org, linux-pwm@vger.kernel.org,
	 linux-clk@vger.kernel.org,
	Alexandre Mergnat <amergnat@baylibre.com>
Subject: [PATCH v3 12/17] clk: mediatek: mt8365-mm: fix DPI0 parent
Date: Thu, 18 Apr 2024 16:17:00 +0200	[thread overview]
Message-ID: <20231023-display-support-v3-12-53388f3ed34b@baylibre.com> (raw)
In-Reply-To: <20231023-display-support-v3-0-53388f3ed34b@baylibre.com>

To have a working display through DPI, a workaround has been
implemented downstream to add "mm_dpi0_dpi0" and "dpi0_sel" to
the DPI node. Shortly, that add an extra clock.

It seems consistent to have the "dpi0_sel" as parent.
Additionnaly, "vpll_dpix" isn't used/managed.

Then, set the "mm_dpi0_dpi0" parent clock to "dpi0_sel".

The new clock tree is:

clk26m
  lvdspll
    lvdspll_X (2, 4, 8, 16)
      dpi0_sel
        mm_dpi0_dpi0

Fixes: d46adccb7966 ("clk: mediatek: add driver for MT8365 SoC")
Signed-off-by: Alexandre Mergnat <amergnat@baylibre.com>
---
 drivers/clk/mediatek/clk-mt8365-mm.c | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/drivers/clk/mediatek/clk-mt8365-mm.c b/drivers/clk/mediatek/clk-mt8365-mm.c
index 01a2ef8f594e..3f62ec750733 100644
--- a/drivers/clk/mediatek/clk-mt8365-mm.c
+++ b/drivers/clk/mediatek/clk-mt8365-mm.c
@@ -53,7 +53,7 @@ static const struct mtk_gate mm_clks[] = {
 	GATE_MM0(CLK_MM_MM_DSI0, "mm_dsi0", "mm_sel", 17),
 	GATE_MM0(CLK_MM_MM_DISP_RDMA1, "mm_disp_rdma1", "mm_sel", 18),
 	GATE_MM0(CLK_MM_MM_MDP_RDMA1, "mm_mdp_rdma1", "mm_sel", 19),
-	GATE_MM0(CLK_MM_DPI0_DPI0, "mm_dpi0_dpi0", "vpll_dpix", 20),
+	GATE_MM0(CLK_MM_DPI0_DPI0, "mm_dpi0_dpi0", "dpi0_sel", 20),
 	GATE_MM0(CLK_MM_MM_FAKE, "mm_fake", "mm_sel", 21),
 	GATE_MM0(CLK_MM_MM_SMI_COMMON, "mm_smi_common", "mm_sel", 22),
 	GATE_MM0(CLK_MM_MM_SMI_LARB0, "mm_smi_larb0", "mm_sel", 23),

-- 
2.25.1


  parent reply	other threads:[~2024-04-18 14:17 UTC|newest]

Thread overview: 25+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2024-04-18 14:16 [PATCH v3 00/17] Add display support for the MT8365-EVK board Alexandre Mergnat
2024-04-18 14:16 ` [PATCH v3 01/17] dt-bindings: display: mediatek: aal: add compatible for MT8365 SoC Alexandre Mergnat
2024-04-18 14:16 ` [PATCH v3 02/17] dt-bindings: display: mediatek: ccorr: " Alexandre Mergnat
2024-04-18 14:16 ` [PATCH v3 03/17] dt-bindings: display: mediatek: color: " Alexandre Mergnat
2024-04-18 14:16 ` [PATCH v3 04/17] dt-bindings: display: mediatek: dither: " Alexandre Mergnat
2024-04-18 14:16 ` [PATCH v3 05/17] dt-bindings: display: mediatek: dsi: " Alexandre Mergnat
2024-04-18 14:16 ` [PATCH v3 06/17] dt-bindings: display: mediatek: dpi: add power-domains property amergnat
2024-04-18 14:16 ` [PATCH v3 07/17] dt-bindings: display: mediatek: dpi: add compatible for MT8365 Alexandre Mergnat
2024-04-19  7:27   ` AngeloGioacchino Del Regno
2024-04-22 13:39   ` Rob Herring
2024-04-18 14:16 ` [PATCH v3 08/17] dt-bindings: display: mediatek: gamma: add compatible for MT8365 SoC Alexandre Mergnat
2024-04-18 14:16 ` [PATCH v3 09/17] dt-bindings: display: mediatek: ovl: " Alexandre Mergnat
2024-04-18 14:16 ` [PATCH v3 10/17] dt-bindings: display: mediatek: rdma: " Alexandre Mergnat
2024-04-18 14:16 ` [PATCH v3 11/17] dt-bindings: pwm: mediatek,pwm-disp: add compatible for mt8365 SoC Alexandre Mergnat
2024-04-18 15:57   ` Uwe Kleine-König
2024-04-18 14:17 ` Alexandre Mergnat [this message]
2024-04-19  7:34   ` [PATCH v3 12/17] clk: mediatek: mt8365-mm: fix DPI0 parent AngeloGioacchino Del Regno
2024-04-20  1:53   ` Stephen Boyd
2024-04-18 14:17 ` [PATCH v3 13/17] drm/mediatek: dsi: Improves the DSI lane setup robustness Alexandre Mergnat
2024-04-18 14:17 ` [PATCH v3 14/17] drm/mediatek: add MT8365 SoC support amergnat
2024-04-19  8:01   ` AngeloGioacchino Del Regno
2024-04-19  9:22     ` Alexandre Mergnat
2024-04-18 14:17 ` [PATCH v3 15/17] arm64: defconfig: enable display connector support Alexandre Mergnat
2024-04-18 14:17 ` [PATCH v3 16/17] arm64: dts: mediatek: add display blocks support for the MT8365 SoC Alexandre Mergnat
2024-04-18 14:17 ` [PATCH v3 17/17] arm64: dts: mediatek: add display support for mt8365-evk Alexandre Mergnat

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20231023-display-support-v3-12-53388f3ed34b@baylibre.com \
    --to=amergnat@baylibre.com \
    --cc=airlied@gmail.com \
    --cc=angelogioacchino.delregno@collabora.com \
    --cc=catalin.marinas@arm.com \
    --cc=chunkuang.hu@kernel.org \
    --cc=ck.hu@mediatek.com \
    --cc=conor+dt@kernel.org \
    --cc=daniel@ffwll.ch \
    --cc=devicetree@vger.kernel.org \
    --cc=dri-devel@lists.freedesktop.org \
    --cc=fparent@baylibre.com \
    --cc=jitao.shi@mediatek.com \
    --cc=krzysztof.kozlowski+dt@linaro.org \
    --cc=linux-arm-kernel@lists.infradead.org \
    --cc=linux-clk@vger.kernel.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=linux-mediatek@lists.infradead.org \
    --cc=linux-pwm@vger.kernel.org \
    --cc=maarten.lankhorst@linux.intel.com \
    --cc=matthias.bgg@gmail.com \
    --cc=mripard@kernel.org \
    --cc=msp@baylibre.com \
    --cc=mturquette@baylibre.com \
    --cc=p.zabel@pengutronix.de \
    --cc=robh@kernel.org \
    --cc=sboyd@kernel.org \
    --cc=tzimmermann@suse.de \
    --cc=u.kleine-koenig@pengutronix.de \
    --cc=will@kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox