Re: [PATCH v6 05/20] dt-bindings: arm: google: Add bindings for Google ARM platforms

Krzysztof Kozlowski
2023-12-10T13:52:58Z

On 10/12/2023 00:30, Peter Griffin wrote:
> + Likewise there are a couple of names for the actual device
> + - Marketing name ("Pixel 6")
> + - Codename ("Oriole")
> +
> + Devicetrees should use the lowercased SoC ID and lowercased board codename,
> + e.g. gs101 and gs101-oriole.
> +
> +properties:
> + $nodename:
> + const: '/'
> + compatible:
> + oneOf:
> + - description: Google Pixel 6 / Oriole
> + items:
> + - enum:
> + - google,gs101-oriole
> + - const: google,gs101
> +
> + # Bootloader requires empty ect node to be present
> + ect:
> + type: object
> + additionalProperties: false

This is a major change, thus Rob's review should be dropped with short
explanation.

No new properties post-review.

Rob,

Please re-review the "ect" part. I suggested it to Peter to solve the
bootloader requirements.

Best regards,
Krzysztof