Re: [PATCH v6 09/20] dt-bindings: serial: samsung: Make samsung,uart-fifosize a required property

Sam Protsenko
2023-12-10T23:34:28Z

On Sat, Dec 9, 2023 at 5:31 PM Peter Griffin <peter.griffin@linaro.org> wrote:
>
> Specifying samsung,uart-fifosize in both DT and driver static data is error
> prone and relies on driver probe order and dt aliases to be correct.
>
> Additionally on many Exynos platforms these are (USI) universal serial
> interfaces which can be uart, spi or i2c, so it can change per board.
>
> For google,gs101-uart make samsung,uart-fifosize a required property.
> For this platform fifosize now *only* comes from DT.
>
> Signed-off-by: Peter Griffin <peter.griffin@linaro.org>
> ---

Reviewed-by: Sam Protsenko <semen.protsenko@linaro.org>

> .../devicetree/bindings/serial/samsung_uart.yaml | 10 ++++++++++
> 1 file changed, 10 insertions(+)
>
> diff --git a/Documentation/devicetree/bindings/serial/samsung_uart.yaml b/Documentation/devicetree/bindings/serial/samsung_uart.yaml
> index ccc3626779d9..65d5d361e8f4 100644
> --- a/Documentation/devicetree/bindings/serial/samsung_uart.yaml
> +++ b/Documentation/devicetree/bindings/serial/samsung_uart.yaml
> @@ -133,6 +133,16 @@ allOf:
> - const: uart
> - const: clk_uart_baud0
>
> + - if:
> + properties:
> + compatible:
> + contains:
> + enum:
> + - google,gs101-uart
> + then:
> + required:
> + - samsung,uart-fifosize
> +
> unevaluatedProperties: false
>
> examples:
> --
> 2.43.0.472.g3155946c3a-goog
>