From: Al Viro <viro@zeniv.linux.org.uk>
To: Conor Dooley <conor@kernel.org>
Cc: linux-riscv@lists.infradead.org,
Conor Dooley <conor.dooley@microchip.com>,
Daire McNamara <daire.mcnamara@microchip.com>,
Michael Turquette <mturquette@baylibre.com>,
Stephen Boyd <sboyd@kernel.org>,
linux-clk@vger.kernel.org, linux-kernel@vger.kernel.org
Subject: Re: [PATCH v1] clk: microchip: mpfs-ccc: replace include of asm-generic/errno-base.h
Date: Thu, 14 Dec 2023 21:10:46 +0000 [thread overview]
Message-ID: <20231214211046.GS1674809@ZenIV> (raw)
In-Reply-To: <20231214-dipper-earshot-72eef3059961@spud>
On Thu, Dec 14, 2023 at 10:59:57AM +0000, Conor Dooley wrote:
> From: Conor Dooley <conor.dooley@microchip.com>
>
> As evidenced by the fact that only 2 other drivers include this header,
> it is not a normal thing to do. Including the regular version of this
> header is far more conventional for drivers.
ACK. Includes of asm-generic/anything.h are fine in arch/*/include/*
and (under some circumstances) in include/*; anywhere else they are very
dubious, including outright bugs (io_uring/uring_cmd.h include
of asm-generic/ioctls.h, for example).
next prev parent reply other threads:[~2023-12-14 21:10 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-12-14 10:59 [PATCH v1] clk: microchip: mpfs-ccc: replace include of asm-generic/errno-base.h Conor Dooley
2023-12-14 21:10 ` Al Viro [this message]
2023-12-17 22:48 ` Stephen Boyd
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20231214211046.GS1674809@ZenIV \
--to=viro@zeniv.linux.org.uk \
--cc=conor.dooley@microchip.com \
--cc=conor@kernel.org \
--cc=daire.mcnamara@microchip.com \
--cc=linux-clk@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-riscv@lists.infradead.org \
--cc=mturquette@baylibre.com \
--cc=sboyd@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox