From: Conor Dooley <conor.dooley@microchip.com>
To: Inochi Amaoto <inochiama@outlook.com>
Cc: Conor Dooley <conor@kernel.org>,
Michael Turquette <mturquette@baylibre.com>,
Stephen Boyd <sboyd@kernel.org>, Rob Herring <robh+dt@kernel.org>,
Krzysztof Kozlowski <krzysztof.kozlowski+dt@linaro.org>,
Conor Dooley <conor+dt@kernel.org>,
Chao Wei <chao.wei@sophgo.com>,
Chen Wang <unicorn_wang@outlook.com>,
Paul Walmsley <paul.walmsley@sifive.com>,
Palmer Dabbelt <palmer@dabbelt.com>,
Albert Ou <aou@eecs.berkeley.edu>,
Jisheng Zhang <jszhang@kernel.org>,
Liu Gui <kenneth.liu@sophgo.com>,
Jingbao Qiu <qiujingbao.dlmu@gmail.com>, <dlan@gentoo.org>,
<linux-clk@vger.kernel.org>, <devicetree@vger.kernel.org>,
<linux-kernel@vger.kernel.org>, <linux-riscv@lists.infradead.org>
Subject: Re: [PATCH v6 1/4] dt-bindings: clock: sophgo: Add clock controller of SG2000 series SoC
Date: Tue, 16 Jan 2024 07:36:58 +0000 [thread overview]
Message-ID: <20240116-doubling-fanning-2a46405942ae@wendy> (raw)
In-Reply-To: <IA1PR20MB4953C0E6DCC3C4CC0A398529BB732@IA1PR20MB4953.namprd20.prod.outlook.com>
[-- Attachment #1: Type: text/plain, Size: 2400 bytes --]
On Tue, Jan 16, 2024 at 08:27:59AM +0800, Inochi Amaoto wrote:
> >On Sun, Jan 14, 2024 at 12:16:58PM +0800, Inochi Amaoto wrote:
> >> SG2000 series SoC has the same clock as CV1810 series, but the clock
> >> related to A53 is functional in SG2000 series. So a new compatible
> >> string is needed for the new SoC.
> >>
> >> Add definition for the clock controller of the SG2000 series SoC.
> >>
> >> Signed-off-by: Inochi Amaoto <inochiama@outlook.com>
> >> Link: https://github.com/sophgo/sophgo-doc/releases/tag/sg2000-datasheet-v1.0-alpha
> >> ---
> >> Documentation/devicetree/bindings/clock/sophgo,cv1800-clk.yaml | 3 ++-
> >> 1 file changed, 2 insertions(+), 1 deletion(-)
> >>
> >> diff --git a/Documentation/devicetree/bindings/clock/sophgo,cv1800-clk.yaml b/Documentation/devicetree/bindings/clock/sophgo,cv1800-clk.yaml
> >> index c1dc24673c0d..59ef41adb539 100644
> >> --- a/Documentation/devicetree/bindings/clock/sophgo,cv1800-clk.yaml
> >> +++ b/Documentation/devicetree/bindings/clock/sophgo,cv1800-clk.yaml
> >> @@ -4,7 +4,7 @@
> >> $id: http://devicetree.org/schemas/clock/sophgo,cv1800-clk.yaml#
> >> $schema: http://devicetree.org/meta-schemas/core.yaml#
> >>
> >> -title: Sophgo CV1800 Series Clock Controller
> >> +title: Sophgo CV1800/SG2000 Series Clock Controller
> >>
> >> maintainers:
> >> - Inochi Amaoto <inochiama@outlook.com>
> >> @@ -14,6 +14,7 @@ properties:
> >> enum:
> >> - sophgo,cv1800-clk
> >> - sophgo,cv1810-clk
> >> + - sophgo,sg2000-clk
> >
> >I recall before you mentioned that the Sophgo folks were considering
> >renaming one of their devices. Is the sg2000 the renamed one, or a
> >different chip?
> The sg2000/sg2002 SoCs have one A53 core which cv1812/cv1813 SoCs
> don't have. I prefer sg2000/sg2002 are different chips, or at least
> an enhanced version of existed cv1812/cv1813. It is not a simple
> rename.
>
> For this patch, the sg2000 doesn't need to disable A53 related clocks
> like cv18xx series. So this compatible is needed to bind to this new
> logic.
I'm not disputing the unique compatible - you previously mentioned that
Sophgo were considering rebranding the cvXXXX series of chips going
forward and that one particular chip might undergo a name change.
I was wondering if this was that chip or just another device in the
series.
Thanks,
Conor.
[-- Attachment #2: signature.asc --]
[-- Type: application/pgp-signature, Size: 228 bytes --]
next prev parent reply other threads:[~2024-01-16 7:37 UTC|newest]
Thread overview: 14+ messages / expand[flat|nested] mbox.gz Atom feed top
2024-01-14 4:15 [PATCH v6 0/4] riscv: sophgo: add clock support for Sophgo CV1800/SG2000 SoCs Inochi Amaoto
2024-01-14 4:16 ` [PATCH v6 1/4] dt-bindings: clock: sophgo: Add clock controller of SG2000 series SoC Inochi Amaoto
2024-01-15 7:31 ` Krzysztof Kozlowski
2024-01-15 16:35 ` Conor Dooley
2024-01-16 0:27 ` Inochi Amaoto
2024-01-16 7:36 ` Conor Dooley [this message]
2024-01-16 8:00 ` Inochi Amaoto
2024-01-16 17:24 ` Conor Dooley
2024-01-14 4:16 ` [PATCH v6 2/4] clk: sophgo: Add CV1800/SG2000 series clock controller driver Inochi Amaoto
2024-01-31 4:27 ` Inochi Amaoto
2024-01-14 4:17 ` [PATCH v6 3/4] riscv: dts: sophgo: add clock generator for Sophgo CV1800 series SoC Inochi Amaoto
2024-01-31 3:44 ` Chen Wang
2024-01-14 4:17 ` [PATCH v6 4/4] riscv: dts: sophgo: add uart clock " Inochi Amaoto
2024-01-31 3:46 ` Chen Wang
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20240116-doubling-fanning-2a46405942ae@wendy \
--to=conor.dooley@microchip.com \
--cc=aou@eecs.berkeley.edu \
--cc=chao.wei@sophgo.com \
--cc=conor+dt@kernel.org \
--cc=conor@kernel.org \
--cc=devicetree@vger.kernel.org \
--cc=dlan@gentoo.org \
--cc=inochiama@outlook.com \
--cc=jszhang@kernel.org \
--cc=kenneth.liu@sophgo.com \
--cc=krzysztof.kozlowski+dt@linaro.org \
--cc=linux-clk@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-riscv@lists.infradead.org \
--cc=mturquette@baylibre.com \
--cc=palmer@dabbelt.com \
--cc=paul.walmsley@sifive.com \
--cc=qiujingbao.dlmu@gmail.com \
--cc=robh+dt@kernel.org \
--cc=sboyd@kernel.org \
--cc=unicorn_wang@outlook.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox