From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mail-lf1-f51.google.com (mail-lf1-f51.google.com [209.85.167.51]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 6CD244643C for ; Mon, 22 Jan 2024 15:28:52 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=209.85.167.51 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1705937334; cv=none; b=BX9Nf7ymexYuGFy6z02+tCorYdgey/PsUKZj5GJb4xyk+e9EuJyXhmQMK+BGYucA2ouhiphbqLiDi7bmyVftiQ5qHtJns4vOdVg0Alv5GRH+JwkvZ7ZG0H5jjxXgol+3uwsXSP5qsjBUcXOZOmEtegz9MowIk+zPe/kicda/r2o= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1705937334; c=relaxed/simple; bh=9BdBSqeP+pKAU1otFzDF6/umZq7OutkXNkVwcIuJQAQ=; h=Date:From:To:Cc:Subject:Message-ID:References:MIME-Version: Content-Type:Content-Disposition:In-Reply-To; b=YPhYkdKr4L4PnssrVF8C77Udw2zUt+BGTD6hywSK7QuN6dYpjQjaaQgQdmO38iigEcdpHe2jC8B5hLnJ2Tb2mU7ktaiXNTPBXFNSwh95gGdBr7wMwIkxcP9VJZehlL3IkO1nCLzFnyCfPgBPOiphl/gq8D/Um73FyytFNcW7LEY= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=ragnatech.se; spf=pass smtp.mailfrom=ragnatech.se; dkim=pass (2048-bit key) header.d=ragnatech.se header.i=@ragnatech.se header.b=UeI6At6N; arc=none smtp.client-ip=209.85.167.51 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=ragnatech.se Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=ragnatech.se Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=ragnatech.se header.i=@ragnatech.se header.b="UeI6At6N" Received: by mail-lf1-f51.google.com with SMTP id 2adb3069b0e04-50edf4f478eso4210732e87.3 for ; Mon, 22 Jan 2024 07:28:52 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=ragnatech.se; s=google; t=1705937330; x=1706542130; darn=vger.kernel.org; h=in-reply-to:content-transfer-encoding:content-disposition :mime-version:references:message-id:subject:cc:to:from:date:from:to :cc:subject:date:message-id:reply-to; bh=2K12GqOYOmu/kngnIcRPPAXG1MUNKwc6xKsFfoWOXrk=; b=UeI6At6NFCH5powLVwcaLYggyPZeHDZAHw2m67waGZai2AJLjwRxTr3SFz7KGRhxaI 7Yk6JejoxyWCAmVA/WbBYmFkMFUp5/YXmYvFY5Zplc/oItg+v4QAGWjUqQd3EHCMS4Ym 3EEyNZzQ0EYvXQ7DI0II+x2ycnAeoQZZIY+1vjG1bCjXkLbtZMedZPTqbJyduHv3RPcb Q9lujAV0nBIixqG7lsppxVfwzE1VADVii6F5KHfk7sr+aZ7L9iuHQ0/9U7Xbb4qBmQ/J oTV/k41m1GL6kElrIrDz3q5IE713Q2zRFhfQOQmniauYCL3O56oxmZE0OGgTEfVuYxcC PR5Q== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1705937330; x=1706542130; h=in-reply-to:content-transfer-encoding:content-disposition :mime-version:references:message-id:subject:cc:to:from:date :x-gm-message-state:from:to:cc:subject:date:message-id:reply-to; bh=2K12GqOYOmu/kngnIcRPPAXG1MUNKwc6xKsFfoWOXrk=; b=LuJdyfoTlVUX7T2d5NzfR3m5t/+5tZx6WsLkcyW1ayxh0Ea+Xs+HDPdx/Ch+IFgtlO JDtoSQzXRbZ5dzoq5g7XYMOxy6NSlYJrkRXZLYT0jk1MclBNLhCP8epi4bAnhl9NLQSZ n84KH67YG/P7YNzPLBG47r8gunsoI7m4O6U9aFszQGFLHx7gjqwkjRlBhMxu292a8TeX XQIjZfZpQM1EUbJCklxfa+aie38iirJXSFbVykgq2WytjbBUkAv35/CbiXi1E+PylKss gycBpGKWkOCd4ZFbKPzdNHlkUngHtYnmftHG+ioODa3Gu3zzN0/JJTIqz5sD/8s8TuXr Mf+A== X-Gm-Message-State: AOJu0YzRiyGJOk7IROdKmWfJAvJbAERZOBrFaIY4gBiNZKV2Mzx4/eBR 6aHdtu0/X7Bn0lMG9s/2/3rU870uTkCvPtdFMm5slil+b0a3bFhnaNChB6Uhemo= X-Google-Smtp-Source: AGHT+IFXMsLAfSiyXwYetfcWWI5V/6UXuXMRBGjPtwt7+N7rAeMR8gi0EtfzDJPIeqQ3uAipOI8Y/A== X-Received: by 2002:a05:6512:33c3:b0:50e:9a0d:d402 with SMTP id d3-20020a05651233c300b0050e9a0dd402mr2309630lfg.105.1705937330396; Mon, 22 Jan 2024 07:28:50 -0800 (PST) Received: from localhost (h-46-59-36-113.A463.priv.bahnhof.se. [46.59.36.113]) by smtp.gmail.com with ESMTPSA id b15-20020a056512304f00b0050e897b320fsm2018106lfb.192.2024.01.22.07.28.49 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Mon, 22 Jan 2024 07:28:50 -0800 (PST) Date: Mon, 22 Jan 2024 16:28:49 +0100 From: Niklas =?utf-8?Q?S=C3=B6derlund?= To: Geert Uytterhoeven Cc: Michael Turquette , Stephen Boyd , linux-clk@vger.kernel.org, linux-renesas-soc@vger.kernel.org Subject: Re: [PATCH] clk: renesas: mstp: Remove obsolete clkdev registration Message-ID: <20240122152849.GF4126432@ragnatech.se> References: Precedence: bulk X-Mailing-List: linux-clk@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Disposition: inline Content-Transfer-Encoding: 8bit In-Reply-To: Hi Geert, Thanks for your work. On 2024-01-22 14:49:45 +0100, Geert Uytterhoeven wrote: > After the DT conversion of SH-Mobile and Armadillo-800-EVA display > support, all devices are registered from DT, so we can remove the > registration of clkdevs. > > Add the missing #include , which was included implicitly > through before. > > Signed-off-by: Geert Uytterhoeven Reviewed-by: Niklas Söderlund > --- > Patch written in 2015 ;-) I scratch my head reading some of these patches, I have seen some of them before, but could not figure out when. > > To be queued in renesas-clk for v6.9. > --- > drivers/clk/renesas/clk-mstp.c | 16 +++------------- > 1 file changed, 3 insertions(+), 13 deletions(-) > > diff --git a/drivers/clk/renesas/clk-mstp.c b/drivers/clk/renesas/clk-mstp.c > index e96457371b4cce88..cab4c89c4d657740 100644 > --- a/drivers/clk/renesas/clk-mstp.c > +++ b/drivers/clk/renesas/clk-mstp.c > @@ -10,7 +10,6 @@ > > #include > #include > -#include > #include > #include > #include > @@ -19,6 +18,7 @@ > #include > #include > #include > +#include > #include > > /* > @@ -238,22 +238,12 @@ static void __init cpg_mstp_clocks_init(struct device_node *np) > > clks[clkidx] = cpg_mstp_clock_register(name, parent_name, > clkidx, group); > - if (!IS_ERR(clks[clkidx])) { > + if (!IS_ERR(clks[clkidx])) > group->data.clk_num = max(group->data.clk_num, > clkidx + 1); > - /* > - * Register a clkdev to let board code retrieve the > - * clock by name and register aliases for non-DT > - * devices. > - * > - * FIXME: Remove this when all devices that require a > - * clock will be instantiated from DT. > - */ > - clk_register_clkdev(clks[clkidx], name, NULL); > - } else { > + else > pr_err("%s: failed to register %pOFn %s clock (%ld)\n", > __func__, np, name, PTR_ERR(clks[clkidx])); > - } > } > > of_clk_add_provider(np, of_clk_src_onecell_get, &group->data); > -- > 2.34.1 > > -- Kind Regards, Niklas Söderlund