linux-clk.vger.kernel.org archive mirror
 help / color / mirror / Atom feed
From: Rob Herring <robh@kernel.org>
To: Lucas Tanure <tanure@linux.com>
Cc: Xianwei Zhao <xianwei.zhao@amlogic.com>,
	Yu Tu <yu.tu@amlogic.com>,
	Neil Armstrong <neil.armstrong@linaro.org>,
	Kevin Hilman <khilman@baylibre.com>,
	Jerome Brunet <jbrunet@baylibre.com>,
	Martin Blumenstingl <martin.blumenstingl@googlemail.com>,
	Krzysztof Kozlowski <krzysztof.kozlowski+dt@linaro.org>,
	Conor Dooley <conor+dt@kernel.org>,
	Stephen Boyd <sboyd@kernel.org>,
	Michael Turquette <mturquette@baylibre.com>,
	linux-arm-kernel@lists.infradead.org,
	linux-amlogic@lists.infradead.org, devicetree@vger.kernel.org,
	linux-kernel@vger.kernel.org, linux-clk@vger.kernel.org
Subject: Re: [RFC][PATCH 1/2] clk: meson: T7: add support for Amlogic T7 SoC PLL clock driver
Date: Mon, 18 Mar 2024 09:54:23 -0500	[thread overview]
Message-ID: <20240318145423.GA3993342-robh@kernel.org> (raw)
In-Reply-To: <20240318114346.112935-2-tanure@linux.com>

On Mon, Mar 18, 2024 at 11:43:45AM +0000, Lucas Tanure wrote:
> Add the T7 PLL clock controller driver in the T7 SoC family.
> 
> This is RFC patch that enables SDCard, Ethernet and Clocking
> for Amlogic T7 soc.
> In this current state the patch doesn't work and gives a kernel
> panic when probing the meson-axg-mmc for the SDCard.
> DO NOT MERGE.
> 
> Signed-off-by: Lucas Tanure <tanure@linux.com>
> ---
>  drivers/clk/meson/Kconfig                     |   25 +
>  drivers/clk/meson/Makefile                    |    2 +
>  drivers/clk/meson/t7-peripherals.c            | 6368 +++++++++++++++++
>  drivers/clk/meson/t7-peripherals.h            |  131 +
>  drivers/clk/meson/t7-pll.c                    | 1543 ++++
>  drivers/clk/meson/t7-pll.h                    |   83 +
>  .../clock/amlogic,t7-peripherals-clkc.h       |  410 ++
>  .../dt-bindings/clock/amlogic,t7-pll-clkc.h   |   69 +
>  8 files changed, 8631 insertions(+)
>  create mode 100644 drivers/clk/meson/t7-peripherals.c
>  create mode 100644 drivers/clk/meson/t7-peripherals.h
>  create mode 100644 drivers/clk/meson/t7-pll.c
>  create mode 100644 drivers/clk/meson/t7-pll.h

>  create mode 100644 include/dt-bindings/clock/amlogic,t7-peripherals-clkc.h
>  create mode 100644 include/dt-bindings/clock/amlogic,t7-pll-clkc.h

I'm assuming since this is an RFC you know these go in a separate patch 
with the DT binding schema which is missing.

Rob

  reply	other threads:[~2024-03-18 14:54 UTC|newest]

Thread overview: 10+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2024-03-18 11:43 [RFC][PATCH 0/2] Amlogic T7 (A113D2) Clock Driver Lucas Tanure
2024-03-18 11:43 ` [RFC][PATCH 1/2] clk: meson: T7: add support for Amlogic T7 SoC PLL clock driver Lucas Tanure
2024-03-18 14:54   ` Rob Herring [this message]
2024-03-18 15:00     ` Lucas Tanure
     [not found]   ` <CAJX_Q+0n3vPV58Qk9iZ0TsZ1Q75w18c35hoPvSi5-D0NA8Cv2w@mail.gmail.com>
2024-03-31 18:33     ` Lucas Tanure
2024-03-18 11:43 ` [RFC][PATCH 2/2] arm64: dts: amlogic: t7: SDCard, Ethernet and Clocking Lucas Tanure
2024-04-03  6:44 ` [RFC][PATCH 0/2] Amlogic T7 (A113D2) Clock Driver Xianwei Zhao
2024-04-03  8:12   ` Lucas Tanure
2024-04-07 10:08     ` Xianwei Zhao
2024-04-08  1:39     ` Xianwei Zhao

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20240318145423.GA3993342-robh@kernel.org \
    --to=robh@kernel.org \
    --cc=conor+dt@kernel.org \
    --cc=devicetree@vger.kernel.org \
    --cc=jbrunet@baylibre.com \
    --cc=khilman@baylibre.com \
    --cc=krzysztof.kozlowski+dt@linaro.org \
    --cc=linux-amlogic@lists.infradead.org \
    --cc=linux-arm-kernel@lists.infradead.org \
    --cc=linux-clk@vger.kernel.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=martin.blumenstingl@googlemail.com \
    --cc=mturquette@baylibre.com \
    --cc=neil.armstrong@linaro.org \
    --cc=sboyd@kernel.org \
    --cc=tanure@linux.com \
    --cc=xianwei.zhao@amlogic.com \
    --cc=yu.tu@amlogic.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).