Re: [PATCH v2 03/14] dt-bindings: ufs: exynos-ufs: Add gs101 compatible

Peter Griffin
2024-04-25T16:49:26Z

Hi Rob,

Thanks for the review.

On Wed, 24 Apr 2024 at 20:53, Rob Herring <robh@kernel.org> wrote:
>
> On Tue, Apr 23, 2024 at 09:49:55PM +0100, Peter Griffin wrote:
> > Add dedicated google,gs101-ufs compatible for Google Tensor gs101
> > SoC.
> >
> > Signed-off-by: Peter Griffin <peter.griffin@linaro.org>
> > ---
> > .../bindings/ufs/samsung,exynos-ufs.yaml | 38 +++++++++++++++++--
> > 1 file changed, 35 insertions(+), 3 deletions(-)
> >
> > diff --git a/Documentation/devicetree/bindings/ufs/samsung,exynos-ufs.yaml b/Documentation/devicetree/bindings/ufs/samsung,exynos-ufs.yaml
> > index b2b509b3944d..1179527d29d1 100644
> > --- a/Documentation/devicetree/bindings/ufs/samsung,exynos-ufs.yaml
> > +++ b/Documentation/devicetree/bindings/ufs/samsung,exynos-ufs.yaml
> > @@ -12,12 +12,10 @@ maintainers:
> > description: |
> > Each Samsung UFS host controller instance should have its own node.
> >
> > -allOf:
> > - - $ref: ufs-common.yaml
> > -
> > properties:
> > compatible:
> > enum:
> > + - google,gs101-ufs
> > - samsung,exynos7-ufs
> > - samsung,exynosautov9-ufs
> > - samsung,exynosautov9-ufs-vh
> > @@ -38,14 +36,24 @@ properties:
> > - const: ufsp
> >
> > clocks:
> > + minItems: 2
> > items:
> > - description: ufs link core clock
> > - description: unipro main clock
> > + - description: fmp clock
> > + - description: ufs aclk clock
> > + - description: ufs pclk clock
> > + - description: sysreg clock
> >
> > clock-names:
> > + minItems: 2
> > items:
> > - const: core_clk
> > - const: sclk_unipro_main
> > + - const: fmp
> > + - const: ufs_aclk
> > + - const: ufs_pclk
>
> 'ufs_' is redundant.

Will fix.

Thanks,

Peter.