Re: [PATCH v5 0/2] Add notifier for PLL0 clock and set it 1.5GHz on

Conor Dooley
2024-06-04T16:53:49Z

[-- Attachment #1: Type: text/plain, Size: 1628 bytes --]

On Tue, Jun 04, 2024 at 12:45:48PM +0300, David Abdurachmanov wrote:
> On Wed, May 15, 2024 at 7:31 PM Conor Dooley <conor@kernel.org> wrote:
> >
> > On Wed, May 15, 2024 at 02:23:47AM +0000, Xingyu Wu wrote:
> > > On 15/05/2024 02:08, Conor Dooley wrote:
> >
> > > > There's a push in U-Boot to move devicestrees to use "OF_UPSTREAM", which
> > > > means importing devicetrees directly from Linux and using them in U-Boot. I
> > > > don't really want to merge a patch that would present U-Boot with a problem if
> > > > the VisionFive 2 moved to that model there.
> >
> > > Would it be better if I change the rates of PLL0 and CPU core in the driver not dts,
> > > and avoid the dts of Linux and U-Boot being different?
> >
> > I'd definitely prefer if we don't include stuff in the kernel tree that
> > would cause problems for U-Boot if imported there, yeah.
> >
>
> What is the current state of this patchset?

v6: https://lore.kernel.org/all/20240603020607.25122-1-xingyu.wu@starfivetech.com/

Guess it didn't go to the riscv ml because the dts patch was dropped.

> I noticed this patchset on the U-Boot side from Hal Feng:
> [PATCH v1 0/4] Sync StarFive JH7110 clock and reset dt-bindings with Linux
>
> It seems to indicate that there is WIP for OF_UPSTREAM support.

And as a commenter on that patchset you reference said, they should
actually use OF_UPSTREAM directly rather than manual syncs like that
series. I'm not sure how the U-Boot folks want to address that w.r.t.
bisection though, in cases like this where the defines do not have
identical names.

Thanks,
Conor.

[-- Attachment #2: signature.asc --]
[-- Type: application/pgp-signature, Size: 228 bytes --]