From: "Niklas Söderlund" <niklas.soderlund+renesas@ragnatech.se>
To: Geert Uytterhoeven <geert+renesas@glider.be>
Cc: Michael Turquette <mturquette@baylibre.com>,
Stephen Boyd <sboyd@kernel.org>,
Cong Dang <cong.dang.xn@renesas.com>,
linux-renesas-soc@vger.kernel.org, linux-clk@vger.kernel.org,
Yoshihiro Shimoda <yoshihiro.shimoda.uh@renesas.com>
Subject: Re: [PATCH] clk: renesas: r8a779h0: Fix PLL2/PLL4 multipliers in comments
Date: Wed, 12 Jun 2024 12:30:25 +0200 [thread overview]
Message-ID: <20240612103025.GE382677@ragnatech.se> (raw)
In-Reply-To: <07126b55807c1596422c9547e72f0a032487da1e.1718177076.git.geert+renesas@glider.be>
Hi Geert,
Thanks for your work.
On 2024-06-12 09:25:16 +0200, Geert Uytterhoeven wrote:
> The multipliers for PLL2 and PLL4 as listed in the comments for
> the cpg_pll_configs[] array are incorrect. Fix them.
>
> Note that the actual values in the tables were correct.
>
> Reported-by: Yoshihiro Shimoda <yoshihiro.shimoda.uh@renesas.com>
> Fixes: f077cab34df3010d ("clk: renesas: cpg-mssr: Add support for R-Car V4M")
> Signed-off-by: Geert Uytterhoeven <geert+renesas@glider.be>
Reviewed-by: Niklas Söderlund <niklas.soderlund+renesas@ragnatech.se>
> ---
> To be queued in renesas-clk for v6.11.
> ---
> drivers/clk/renesas/r8a779h0-cpg-mssr.c | 6 +++---
> 1 file changed, 3 insertions(+), 3 deletions(-)
>
> diff --git a/drivers/clk/renesas/r8a779h0-cpg-mssr.c b/drivers/clk/renesas/r8a779h0-cpg-mssr.c
> index 0a553d5170d5fdde..1057a2b6a72769dd 100644
> --- a/drivers/clk/renesas/r8a779h0-cpg-mssr.c
> +++ b/drivers/clk/renesas/r8a779h0-cpg-mssr.c
> @@ -243,10 +243,10 @@ static const struct mssr_mod_clk r8a779h0_mod_clks[] = {
> * MD EXTAL PLL1 PLL2 PLL3 PLL4 PLL5 PLL6 OSC
> * 14 13 (MHz)
> * ------------------------------------------------------------------------
> - * 0 0 16.66 / 1 x192 x204 x192 x144 x192 x168 /16
> - * 0 1 20 / 1 x160 x170 x160 x120 x160 x140 /19
> + * 0 0 16.66 / 1 x192 x240 x192 x240 x192 x168 /16
> + * 0 1 20 / 1 x160 x200 x160 x200 x160 x140 /19
> * 1 0 Prohibited setting
> - * 1 1 33.33 / 2 x192 x204 x192 x144 x192 x168 /32
> + * 1 1 33.33 / 2 x192 x240 x192 x240 x192 x168 /32
> */
> #define CPG_PLL_CONFIG_INDEX(md) ((((md) & BIT(14)) >> 13) | \
> (((md) & BIT(13)) >> 13))
> --
> 2.34.1
>
--
Kind Regards,
Niklas Söderlund
next prev parent reply other threads:[~2024-06-12 10:30 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2024-06-12 7:25 [PATCH] clk: renesas: r8a779h0: Fix PLL2/PLL4 multipliers in comments Geert Uytterhoeven
2024-06-12 10:30 ` Niklas Söderlund [this message]
2024-06-12 11:22 ` Yoshihiro Shimoda
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20240612103025.GE382677@ragnatech.se \
--to=niklas.soderlund+renesas@ragnatech.se \
--cc=cong.dang.xn@renesas.com \
--cc=geert+renesas@glider.be \
--cc=linux-clk@vger.kernel.org \
--cc=linux-renesas-soc@vger.kernel.org \
--cc=mturquette@baylibre.com \
--cc=sboyd@kernel.org \
--cc=yoshihiro.shimoda.uh@renesas.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox