Re: [PATCH v3 10/23] dt-bindings: regulator: add samsung,s2dos05

Krzysztof Kozlowski
2024-06-20T15:51:40Z

On 18/06/2024 15:59, Dzmitry Sankouski wrote:
> add samsung,s2dos05 regulator binding part

Make it a proper sentence.

>
> Signed-off-by: Dzmitry Sankouski <dsankouski@gmail.com>
> ---
> .../bindings/regulator/samsung,s2dos05.yaml | 36 ++++++++++++++++++++++
> MAINTAINERS | 1 +
> 2 files changed, 37 insertions(+)
>
> diff --git a/Documentation/devicetree/bindings/regulator/samsung,s2dos05.yaml b/Documentation/devicetree/bindings/regulator/samsung,s2dos05.yaml
> new file mode 100644
> index 000000000000..4b8e4389329c
> --- /dev/null
> +++ b/Documentation/devicetree/bindings/regulator/samsung,s2dos05.yaml
> @@ -0,0 +1,36 @@
> +# SPDX-License-Identifier: (GPL-2.0 OR BSD-2-Clause)
> +%YAML 1.2
> +---
> +$id: http://devicetree.org/schemas/regulator/samsung,s2dos05.yaml#
> +$schema: http://devicetree.org/meta-schemas/core.yaml#
> +
> +title: Samsung S2DOS05 Power Management IC Regulators
> +
> +maintainers:
> + - Dzmitry Sankouski <dsankouski@gmail.com>
> +
> +description:
> + This is a part of device tree bindings for S2M and S5M family of Power
> + Management IC (PMIC).

No, it's not.

> +
> + Has 4 LDO and 1 BUCK regulators, provides ELVDD, ELVSS, AVDD lines.
> +
> + See also Documentation/devicetree/bindings/mfd/samsung,s2dos05.yaml for
> + additional information and example.
> +
> +properties:
> + compatible:
> + const: samsung,s2dos05-regulator

Drop the compatible and then squash it in the MFD binding.

> +
> +patternProperties:
> + "^buck1|ldo[1-4]$":

You did not test the patches.

I will not continue with the review, because testing is a requirement.
Otherwise it is just a waste of my time.

Best regards,
Krzysztof