Re: [PATCH v3 17/23] mfd: add s2dos series core driver

Krzysztof Kozlowski
2024-06-20T16:07:12Z

On 18/06/2024 15:59, Dzmitry Sankouski wrote:
> S2DOS05 is a panel/touchscreen PMIC, often found in
> Samsung phones. We define 2 sub-devices for which drivers will
> be added in subsequent patches.
>
> Signed-off-by: Dzmitry Sankouski <dsankouski@gmail.com>
> ---
> MAINTAINERS | 1 +
> drivers/mfd/Kconfig | 13 +++
> drivers/mfd/Makefile | 2 +-
> drivers/mfd/s2dos-core.c | 141 +++++++++++++++++++++++++++++++++
> include/linux/mfd/samsung/s2dos-core.h | 21 +++++
> include/linux/mfd/samsung/s2dos05.h | 115 +++++++++++++++++++++++++++
> 6 files changed, 292 insertions(+), 1 deletion(-)
>
> diff --git a/MAINTAINERS b/MAINTAINERS
> index f3c245d432d9..b53462684a30 100644
> --- a/MAINTAINERS
> +++ b/MAINTAINERS
> @@ -19908,6 +19908,7 @@ F: Documentation/devicetree/bindings/regulator/samsung,s2dos*.yaml
> F: Documentation/devicetree/bindings/regulator/samsung,s2m*.yaml
> F: Documentation/devicetree/bindings/regulator/samsung,s5m*.yaml
> F: drivers/clk/clk-s2mps11.c
> +F: drivers/mfd/s2dos*.c
> F: drivers/mfd/sec*.c
> F: drivers/regulator/s2m*.c
> F: drivers/regulator/s5m*.c
> diff --git a/drivers/mfd/Kconfig b/drivers/mfd/Kconfig
> index c4eb8ff2dcad..517d8778d7a8 100644
> --- a/drivers/mfd/Kconfig
> +++ b/drivers/mfd/Kconfig
> @@ -1278,6 +1278,19 @@ config MFD_RN5T618
> additional drivers must be enabled in order to use the
> functionality of the device.
>
> +config MFD_S2DOS_CORE
> + tristate "Samsung Electronics PMIC Series Support"

Nope, that's a strong NAK.

No need for one more clone of Samsung PMIC driver.

Best regards,
Krzysztof