Re: [PATCH v10 03/38] clk: ep93xx: add DT support for Cirrus EP93xx

Nikita Shubin
2024-07-09T15:37:22Z

Hi Stephen,

Thank you for looking into this.

On Mon, 2024-07-08 at 15:18 -0700, Stephen Boyd wrote:
> Quoting Nikita Shubin via B4 Relay (2024-06-17 02:36:37)
> > diff --git a/drivers/clk/clk-ep93xx.c b/drivers/clk/clk-ep93xx.c
> > new file mode 100644
> > index 000000000000..a0430a5ae4da
> > --- /dev/null
> > +++ b/drivers/clk/clk-ep93xx.c
> > @@ -0,0 +1,834 @@
> > +// SPDX-License-Identifier: GPL-2.0-or-later
> > +/*
> [...]
>
> > +
> > +       clk_spi_div = id->driver_data;
> > +       hw = devm_clk_hw_register_fixed_factor(dev, "ep93xx-spi.0",
> > "xtali",
>
> Are these clk names trying to match device names?

Yes, ep93xx is still a pure platform SoC, so spi for example still uses
devm_clk_get:

espi->clk = devm_clk_get(&pdev->dev, NULL);
[...]
.driver = {
.name = "ep93xx-spi",
},

This, of course, is no longer necessary in these series (since we
convert to DT).

The clock names are from CLK conversion of arch/arm/mach-ep93xx/clock.c
i made earlier:

9645ccc7bd7a16cd73c3be9dee70cd702b03be37 ep93xx: clock: convert in-
place to COMMON_CLK

Where i kept the original names which were used before conversion.