Re: [PATCH 18/23] dt-bindings: allwinner: add H616 DE33 bus, clock and display bindings

Rob Herring (Arm)
2024-06-20T12:25:01Z

On Thu, 20 Jun 2024 23:29:56 +1200, Ryan Walklin wrote:
> The Allwinner H616 and variants have a new display engine revision
> (DE33).
>
> Add display engine bus, clock and mixer bindings for the DE33.
>
> Signed-off-by: Ryan Walklin <ryan@testtoast.com>
> ---
> .../devicetree/bindings/bus/allwinner,sun50i-a64-de2.yaml | 7 ++++---
> .../bindings/clock/allwinner,sun8i-a83t-de2-clk.yaml | 1 +
> .../bindings/display/allwinner,sun8i-a83t-de2-mixer.yaml | 1 +
> 3 files changed, 6 insertions(+), 3 deletions(-)
>

My bot found errors running 'make dt_binding_check' on your patch:

yamllint warnings/errors:
./Documentation/devicetree/bindings/bus/allwinner,sun50i-a64-de2.yaml:27:9: [warning] wrong indentation: expected 10 but found 8 (indentation)

dtschema/dtc warnings/errors:
/builds/robherring/dt-review-ci/linux/Documentation/devicetree/bindings/bus/allwinner,sun50i-a64-de2.example.dtb: bus@1000000: compatible: ['allwinner,sun50i-a64-de2'] is valid under each of {'items': [{'const': 'allwinner,sun50i-a64-de2'}], 'type': 'array', 'minItems': 1, 'maxItems': 1}, {'items': [{'const': 'allwinner,sun50i-a64-de2'}], 'type': 'array', 'minItems': 1, 'maxItems': 1}
from schema $id: http://devicetree.org/schemas/bus/allwinner,sun50i-a64-de2.yaml#

doc reference errors (make refcheckdocs):

See https://patchwork.ozlabs.org/project/devicetree-bindings/patch/20240620113150.83466-19-ryan@testtoast.com

The base for the series is generally the latest rc1. A different dependency
should be noted in *this* patch.

If you already ran 'make dt_binding_check' and didn't see the above
error(s), then make sure 'yamllint' is installed and dt-schema is up to
date:

pip3 install dtschema --upgrade

Please check and re-submit after running the above command yourself. Note
that DT_SCHEMA_FILES can be set to your schema file to speed up checking
your schema. However, it must be unset to test all examples with your schema.