Re: [PATCH v4 15/27] regulator: add s2dos05 regulator support

Krzysztof Kozlowski
2024-09-23T09:07:56Z

On 19/09/2024 16:28, Dzmitry Sankouski wrote:
>>> diff --git a/include/linux/regulator/s2dos05.h b/include/linux/regulator/s2dos05.h
>>> new file mode 100644
>>> index 000000000000..2e89fcbce769
>>> --- /dev/null
>>> +++ b/include/linux/regulator/s2dos05.h
>>> @@ -0,0 +1,73 @@
>>> +/* SPDX-License-Identifier: GPL-2.0+ */
>>
>> Are you sure that here (and other places) you want any newer GPL? This
>> is quite odd. Does original code (from which you took 2016 copyrights)
>> have this as well?
>>
> Original code permits redistribution under 2+ license [1].
> Is 2+ preferable over 2 only?
>
> [1]: https://github.com/klabit87/twrp_android_samsung_kernel_sdm845/blob/android-8.0/include/linux/regulator/s2dos05.h#L9

For new code we usually suggest 2-only, but your work looks like
derivative, so keeping 2+ is fine.

Best regards,
Krzysztof