Re: [PATCH v5 21/26] dt-bindings: allwinner: add H616 DE33 mixer binding

Chris Morgan
2025-02-12T17:31:08Z

On Sun, Sep 29, 2024 at 10:04:53PM +1300, Ryan Walklin wrote:
> The Allwinner H616 and variants have a new display engine revision
> (DE33).
>
> The mixer configuration registers are significantly different to the DE3
> and DE2 revisions, being split into separate top and display blocks,
> therefore a fallback for the mixer compatible is not provided.
>
> Add a display engine mixer binding for the DE33.
>
> Signed-off-by: Ryan Walklin <ryan@testtoast.com>
> Acked-by: Conor Dooley <conor.dooley@microchip.com>
> Reviewed-by: Chen-Yu Tsai <wens@csie.org>
>
> ---
> Changelog v2..v3:
> - Separate content into three patches for three separate subsystems
> ---
> .../bindings/display/allwinner,sun8i-a83t-de2-mixer.yaml | 1 +
> 1 file changed, 1 insertion(+)
>
> diff --git a/Documentation/devicetree/bindings/display/allwinner,sun8i-a83t-de2-mixer.yaml b/Documentation/devicetree/bindings/display/allwinner,sun8i-a83t-de2-mixer.yaml
> index b75c1ec686ad2..c37eb8ae1b8ee 100644
> --- a/Documentation/devicetree/bindings/display/allwinner,sun8i-a83t-de2-mixer.yaml
> +++ b/Documentation/devicetree/bindings/display/allwinner,sun8i-a83t-de2-mixer.yaml
> @@ -24,6 +24,7 @@ properties:
> - allwinner,sun50i-a64-de2-mixer-0
> - allwinner,sun50i-a64-de2-mixer-1
> - allwinner,sun50i-h6-de3-mixer-0
> + - allwinner,sun50i-h616-de33-mixer-0
>
> reg:
> maxItems: 1

- maxItems: 1
+ minItems: 1
+ maxItems: 3

> --
> 2.46.1
>

Also need to add constraints to set maxItems to 3 only for the h616-de33

+allOf:
+ - if:
+ properties:
+ compatible:
+ enum:
+ - allwinner,sun50i-h616-de33-mixer-0
+
+ then:
+ properties:
+ reg:
+ maxItems: 3
+
+ else:
+ properties:
+ reg:
+ maxItems: 1
+

Thank you,
Chris