From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from foss.arm.com (foss.arm.com [217.140.110.172]) by smtp.subspace.kernel.org (Postfix) with ESMTP id 446881F471A; Tue, 17 Dec 2024 21:16:00 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=217.140.110.172 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1734470164; cv=none; b=QhC4HN88zUhKumSUIAOyMLUDM4KLdThe2KJ65cqovyEMfGmV6wLCrGJJGZ8WqZ2PLs4LE8T5S5xTO0e8NHpnFjYWG0eLNim136ikQIxWPGgvOdd70wYj0wH1swcAsxsuhf0RD0THgCrMuf8fEUXUXW583oAzU6jRzMAd+/D7JRs= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1734470164; c=relaxed/simple; bh=UKaP4RT1362Jn3OfLDudS6vvatZTlO6Za7PX7nGwm7Y=; h=Date:From:To:Cc:Subject:Message-ID:In-Reply-To:References: MIME-Version:Content-Type; b=AwfBpHozeRV8rLzj8IK7zwHXcciK/Wo6Ef+q4dizK8ibMpbdGCxzcQtPTj1KhEOgTcTUxJzyRwUgsyJ4wTVvldsY6WiODi0yCUSiCM7TJvIJ4N3AcxgZBmELtTASm531/flzqai3x6YVMJUbCvCzzCTlD2aiNboj3EXCVbRWCBo= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=arm.com; spf=pass smtp.mailfrom=arm.com; arc=none smtp.client-ip=217.140.110.172 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=arm.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=arm.com Received: from usa-sjc-imap-foss1.foss.arm.com (unknown [10.121.207.14]) by usa-sjc-mx-foss1.foss.arm.com (Postfix) with ESMTP id A68DEFEC; Tue, 17 Dec 2024 13:16:27 -0800 (PST) Received: from minigeek.lan (usa-sjc-mx-foss1.foss.arm.com [172.31.20.19]) by usa-sjc-imap-foss1.foss.arm.com (Postfix) with ESMTPSA id 621913F7B4; Tue, 17 Dec 2024 13:15:57 -0800 (PST) Date: Tue, 17 Dec 2024 21:15:05 +0000 From: Andre Przywara To: Vasily Khoruzhick Cc: Krzysztof Kozlowski , Rob Herring , Krzysztof Kozlowski , Conor Dooley , Chen-Yu Tsai , Jernej Skrabec , Samuel Holland , Michael Turquette , Stephen Boyd , Maxime Ripard , Roman Beranek , devicetree@vger.kernel.org, linux-arm-kernel@lists.infradead.org, linux-sunxi@lists.linux.dev, linux-kernel@vger.kernel.org, linux-clk@vger.kernel.org Subject: Re: [PATCH 1/3] dt-bindings: clock: sunxi: Export PLL_VIDEO_2X and PLL_MIPI Message-ID: <20241217211505.7f9c9e4e@minigeek.lan> In-Reply-To: References: <20241215053639.738890-1-anarsoul@gmail.com> <20241215053639.738890-2-anarsoul@gmail.com> Organization: Arm Ltd. X-Mailer: Claws Mail 4.2.0 (GTK 3.24.31; x86_64-slackware-linux-gnu) Precedence: bulk X-Mailing-List: linux-clk@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: quoted-printable On Tue, 17 Dec 2024 10:00:45 -0800 Vasily Khoruzhick wrote: Hi, > On Mon, Dec 16, 2024 at 11:33=E2=80=AFPM Krzysztof Kozlowski wrote: > > > > On Sat, Dec 14, 2024 at 09:34:57PM -0800, Vasily Khoruzhick wrote: =20 > > > These will be used to explicitly select TCON0 clock parent in dts > > > > > > Fixes: ca1170b69968 ("clk: sunxi-ng: a64: force select PLL_MIPI in TC= ON0 mux") > > > Signed-off-by: Vasily Khoruzhick > > > --- > > > drivers/clk/sunxi-ng/ccu-sun50i-a64.h | 2 -- > > > include/dt-bindings/clock/sun50i-a64-ccu.h | 2 + =20 >=20 > Hi Krzysztof, >=20 > > You cannot combine these changes. =20 >=20 > The patch basically moves defines out from ccu-sun50i-a64.h to > sun50i-a64-ccu.h. How do I split the change without introducing > compilation failure? You can just have the binding part first, adding the (same) definition to the binding headers. As long as the #define's are not conflicting, this is fine. Then remove the now redundant definitions in the kernel headers, with a subsequent patch. Cheers, Andre >=20 > > Please run scripts/checkpatch.pl and fix reported warnings. Then please > > run 'scripts/checkpatch.pl --strict' and (probably) fix more warnings. > > Some warnings can be ignored, especially from --strict run, but the code > > here looks like it needs a fix. Feel free to get in touch if the warning > > is not clear. =20 >=20 > Yeah, it is not clear what do you want me to do, assuming the previous > similar change to sun50i-a64-ccu.h did essentially the same, see > 71b597ef5d46a326fb0d5cbfc1c6ff1d73cdc7f9 >=20 > Regards, > Vasily >=20 > > Best regards, > > Krzysztof > > =20 >=20