Re: [PATCH v5 1/2] dt-bindings: clock: cs2600: Add support for the CS2600

[Conor Dooley <conor@kernel.org>]

[-- Attachment #1: Type: text/plain, Size: 1096 bytes --]

On Tue, Dec 31, 2024 at 02:17:41PM -0600, Paul Handrigan wrote:

> +  cirrus,aux-output-source:
> +    description:
> +      Specifies the function of the auxiliary output pin with "phase_unlock"
> +      to indicate the input and output clocks are not in phase, "freq_unlock"
> +      to indicate the PLL is unlocked, and "no_clkin" to indicate the clock on
> +      the clk_in pin is not present.
> +    $ref: /schemas/types.yaml#/definitions/string
> +    enum:
> +      - phase_unock
> +      - freq_unlock
> +      - no_clkin
> +
> +  cirrus,clock-mode:
> +    description:
> +      Sets the device into smart mode whith "smart_mode" and sets the device
> +      into smart mode that only outputs a clock when clk_in starts with
> +      "smart_clkin_only_mode".
> +    $ref: /schemas/types.yaml#/definitions/string
> +    enum:
> +      - smart_mode
> +      - smart_clkin_only_mode

Both of these vendor properties are not required, so they need to have a
default added to the binding.

> +
> +required:
> +  - compatible
> +  - reg
> +  - clocks
> +  - clock-names
> +  - '#clock-cells'


[-- Attachment #2: signature.asc --]
[-- Type: application/pgp-signature, Size: 228 bytes --]