From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mail.thorsis.com (mail.thorsis.com [217.92.40.78]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 9C13D1D63F7; Tue, 11 Feb 2025 07:26:17 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=217.92.40.78 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1739258779; cv=none; b=VEk8J3BE5t2/L4pmYhDIBZui0xp4APDbDslQgS3udXIbklBUXmHGRQYyNbadw8QYemHMT92Ld9CMOyY8LdY2IW0JT+1fk0FVkIFbygTi3JsVw8YJGGokqbwuGcJa5wYVi/PcJseIUVh8t5dJUe1OwJTcKGIK24sWb5uV5OpcfnU= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1739258779; c=relaxed/simple; bh=TcIarT3JO97cH1N3JAkDmFIDszTxj4BeqZagTWuxUrs=; h=Date:From:To:Cc:Subject:Message-ID:References:MIME-Version: Content-Type:Content-Disposition:In-Reply-To; b=tQwAUhf5zSJ7ZOFkZz6aVOi1MU6aPMsTvu5T48H2vpOPvFrgdsKy+Bx6oL3/jhRA9SqwzII+f3mm6QFaGZFMOrfyTxPJjHTyn9WzHd1h+Pcu8pnrG15WAyDyvbwbkfxT7ZQcZNQzzKmzgio0QpyXsAXto+xXLdz18AAU53HrWgE= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=pass (p=quarantine dis=none) header.from=thorsis.com; spf=pass smtp.mailfrom=thorsis.com; dkim=pass (2048-bit key) header.d=thorsis.com header.i=@thorsis.com header.b=wlhlPoTs; arc=none smtp.client-ip=217.92.40.78 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=quarantine dis=none) header.from=thorsis.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=thorsis.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=thorsis.com header.i=@thorsis.com header.b="wlhlPoTs" Received: from [127.0.0.1] (localhost [127.0.0.1]) by localhost (Mailerdaemon) with ESMTPSA id 3C04914802D4; Tue, 11 Feb 2025 08:26:13 +0100 (CET) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=thorsis.com; s=dkim; t=1739258774; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: in-reply-to:in-reply-to:references:references; bh=RYs4aAcJHRJkvxcIeHsULbx8GQp917z9kJzRH+pky5g=; b=wlhlPoTsjWnIE1TnJpa4gc8z69bjupLBcLpg3tULPnmnMK3ESwl93cxYL3s/uveVJ2eDPV WuGtImGJhZf7W0YOdqGxHftl19rIlXL3GDGN3N/5sqB5rNw4FzNQ1FCPqBPyBFe81CGm1W MLyJQeg4MHlGJbdu40Xiswyzvo/hKa3Bi/rIkKZtYa/SQOl9m//foimXIAN792EA6mYDyZ FYLZ7j4Yrka9oI4oGlHBpF+cplMyk/nRX81AzOrkrY7/MkQc1NFFTtml8iI4wtu7cjqSEc WIKLcCYvXrs79+3sCLgUCP6gnJfr1Kuuz32MDKokrhgMLb23D92kdwVmPgC9Iw== Date: Tue, 11 Feb 2025 08:26:11 +0100 From: Alexander Dahl To: Krzysztof Kozlowski Cc: Alexander Dahl , Claudiu Beznea , Nicolas Ferre , Ryan Wanner , linux-arm-kernel@lists.infradead.org, devicetree@vger.kernel.org, linux-clk@vger.kernel.org, linux-kernel@vger.kernel.org, Michael Turquette , Stephen Boyd , Rob Herring , Krzysztof Kozlowski , Conor Dooley Subject: Re: [PATCH v2 04/16] dt-bindings: clock: at91: Allow referencing main rc oscillator in DT Message-ID: <20250211-deprive-relocate-353ad26f46b7@thorsis.com> Mail-Followup-To: Krzysztof Kozlowski , Claudiu Beznea , Nicolas Ferre , Ryan Wanner , linux-arm-kernel@lists.infradead.org, devicetree@vger.kernel.org, linux-clk@vger.kernel.org, linux-kernel@vger.kernel.org, Michael Turquette , Stephen Boyd , Rob Herring , Krzysztof Kozlowski , Conor Dooley References: <20250210164506.495747-1-ada@thorsis.com> <20250210164506.495747-5-ada@thorsis.com> <89d51ac4-0690-42a7-b5fb-2887363e8a8b@kernel.org> Precedence: bulk X-Mailing-List: linux-clk@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <89d51ac4-0690-42a7-b5fb-2887363e8a8b@kernel.org> User-Agent: Mutt/2.2.12 (2023-09-09) X-Last-TLS-Session-Version: TLSv1.3 Hello Krzysztof, Am Mon, Feb 10, 2025 at 06:07:10PM +0100 schrieb Krzysztof Kozlowski: > On 10/02/2025 17:44, Alexander Dahl wrote: > > The main rc oscillator will be needed for the OTPC to work properly. > > > > The new index introduced here was not used on the four affected SoC > > clock drivers before, but for sama5d2 only (PMC_I2S1_MUX). > > > > Link: https://lore.kernel.org/linux-devicetree/20250207-jailbird-circus-bcc04ee90e05@thorsis.com/T/#u > > Signed-off-by: Alexander Dahl > > --- > > > > Notes: > > v2: > > - new patch, not present in v1 > > > > include/dt-bindings/clock/microchip,sam9x60-pmc.h | 3 +++ > > include/dt-bindings/clock/microchip,sam9x7-pmc.h | 3 +++ > > include/dt-bindings/clock/microchip,sama7d65-pmc.h | 3 +++ > > include/dt-bindings/clock/microchip,sama7g5-pmc.h | 3 +++ > > 4 files changed, 12 insertions(+) > > > > diff --git a/include/dt-bindings/clock/microchip,sam9x60-pmc.h b/include/dt-bindings/clock/microchip,sam9x60-pmc.h > > index e01e867e8c4da..dcd3c74f75b54 100644 > > --- a/include/dt-bindings/clock/microchip,sam9x60-pmc.h > > +++ b/include/dt-bindings/clock/microchip,sam9x60-pmc.h > > @@ -16,4 +16,7 @@ > > > > #define SAM9X60_PMC_PLLACK PMC_PLLACK /* 7 */ > > > > +/* new from after bindings splitup */ > > +#define SAM9X60_PMC_MAIN_RC 6 > > This is confusing me, because: > 1. You still have holes in IDs Yes, I was told to maintain the old values for interface stability in series v1 feedback. > 2. This should be placed in proper order by ID Okay, no problem. > 3. Why not using 4 - the next available empty ID? The MAIN_RC clock is used on four out of thirteen (?) SoC variants which all used the same IDs before. 6 is the first ID which is free on all of sam9x60, sam9x7, sama7g5, and sama7d65. The last two already use 4 for a different clock. The whole splitup is to avoid even more and/or bigger holes, but is it important where the existent holes are filled? Technically if the next available empty ID should be used it would be 4 for sam9x60 and sam9x7, 2 for sama7d65, and 6 for sama7g5. I thought it would be nice to use the same value instead to make somewhat compatible to the old approach. Greets Alex