Linux clock framework development
 help / color / mirror / Atom feed
From: "Théo Lebrun" <theo.lebrun@bootlin.com>
To: jbrunet@baylibre.com
Cc: Laurent.pinchart@ideasonboard.com, abelvesa@kernel.org,
	airlied@gmail.com, andrzej.hajda@intel.com, arnd@arndb.de,
	bryan.odonoghue@linaro.org, conor.dooley@microchip.com,
	daire.mcnamara@microchip.com, dakr@kernel.org,
	david.m.ertman@intel.com, dianders@chromium.org,
	dri-devel@lists.freedesktop.org, festevam@gmail.com,
	gregkh@linuxfoundation.org, gregory.clement@bootlin.com,
	hdegoede@redhat.com, ilpo.jarvinen@linux.intel.com,
	imx@lists.linux.dev, ira.weiny@intel.com,
	jernej.skrabec@gmail.com, jonas@kwiboo.se, kernel@pengutronix.de,
	khilman@baylibre.com, linux-amlogic@lists.infradead.org,
	linux-arm-kernel@lists.infradead.org, linux-clk@vger.kernel.org,
	linux-kernel@vger.kernel.org, linux-mips@vger.kernel.org,
	linux-riscv@lists.infradead.org,
	maarten.lankhorst@linux.intel.com,
	martin.blumenstingl@googlemail.com, mripard@kernel.org,
	mturquette@baylibre.com, neil.armstrong@linaro.org,
	p.zabel@pengutronix.de, peng.fan@nxp.com,
	platform-driver-x86@vger.kernel.org, rafael@kernel.org,
	rfoss@kernel.org, s.hauer@pengutronix.de, sboyd@kernel.org,
	shawnguo@kernel.org, simona@ffwll.ch, theo.lebrun@bootlin.com,
	tzimmermann@suse.de, vladimir.kondratiev@mobileye.com
Subject: [PATCH] reset: eyeq: drop device_set_of_node_from_dev() done by parent
Date: Wed, 12 Feb 2025 15:41:26 +0100	[thread overview]
Message-ID: <20250212144126.120231-1-theo.lebrun@bootlin.com> (raw)
In-Reply-To: <20250211-aux-device-create-helper-v3-5-7edb50524909@baylibre.com>

Our parent driver (clk-eyeq) now does the
	device_set_of_node_from_dev(dev, dev->parent)
call through the newly introduced devm_auxiliary_device_create() helper.

Doing it again in the reset-eyeq probe would be redundant.
Drop both the WARN_ON() and the device_set_of_node_from_dev() call.
Also fix the following comment that talks about "our newfound OF node".

Signed-off-by: Théo Lebrun <theo.lebrun@bootlin.com>
---
 drivers/reset/reset-eyeq.c | 13 ++-----------
 1 file changed, 2 insertions(+), 11 deletions(-)

diff --git a/drivers/reset/reset-eyeq.c b/drivers/reset/reset-eyeq.c
index 02d50041048b..8018fa895427 100644
--- a/drivers/reset/reset-eyeq.c
+++ b/drivers/reset/reset-eyeq.c
@@ -420,17 +420,8 @@ static int eqr_probe(struct auxiliary_device *adev,
 	int ret;
 
 	/*
-	 * We are an auxiliary device of clk-eyeq. We do not have an OF node by
-	 * default; let's reuse our parent's OF node.
-	 */
-	WARN_ON(dev->of_node);
-	device_set_of_node_from_dev(dev, dev->parent);
-	if (!dev->of_node)
-		return -ENODEV;
-
-	/*
-	 * Using our newfound OF node, we can get match data. We cannot use
-	 * device_get_match_data() because it does not match reused OF nodes.
+	 * Get match data. We cannot use device_get_match_data() because it does
+	 * not accept reused OF nodes; see device_set_of_node_from_dev().
 	 */
 	match = of_match_node(dev->driver->of_match_table, dev->of_node);
 	if (!match || !match->data)
-- 
2.48.1


  reply	other threads:[~2025-02-12 14:41 UTC|newest]

Thread overview: 29+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2025-02-11 17:27 [PATCH v3 0/7] driver core: auxiliary bus: add device creation helper Jerome Brunet
2025-02-11 17:27 ` [PATCH v3 1/7] driver core: auxiliary bus: add device creation helpers Jerome Brunet
2025-02-14 16:33   ` Greg Kroah-Hartman
2025-02-14 18:16     ` Jerome Brunet
2025-02-15  6:53       ` Greg Kroah-Hartman
2025-02-17 18:10         ` Jerome Brunet
2025-02-18  8:14           ` Greg Kroah-Hartman
2025-02-11 17:27 ` [PATCH v3 2/7] reset: mpfs: use the auxiliary device creation helper Jerome Brunet
2025-02-13 17:59   ` Conor Dooley
2025-02-14  8:59     ` Jerome Brunet
2025-02-14 15:25       ` Doug Anderson
2025-02-15 12:50         ` Conor Dooley
2025-02-11 17:28 ` [PATCH v3 3/7] drm/bridge: ti-sn65dsi86: " Jerome Brunet
2025-02-12 16:38   ` Doug Anderson
2025-02-13 10:10     ` Jerome Brunet
2025-02-11 17:28 ` [PATCH v3 4/7] platform: arm64: lenovo-yoga-c630: " Jerome Brunet
2025-02-13 12:56   ` Ilpo Järvinen
2025-02-11 17:28 ` [PATCH v3 5/7] clk: eyeq: " Jerome Brunet
2025-02-12 14:41   ` Théo Lebrun [this message]
2025-02-12 14:51   ` Théo Lebrun
2025-02-11 17:28 ` [PATCH v3 6/7] clk: clk-imx8mp-audiomix: " Jerome Brunet
2025-02-14 16:15   ` Ira Weiny
2025-02-14 18:20     ` Jerome Brunet
2025-02-14 22:03       ` Ira Weiny
2025-02-11 17:28 ` [PATCH v3 7/7] clk: amlogic: axg-audio: use the auxiliary reset driver - take 2 Jerome Brunet
2025-02-12 14:53   ` Théo Lebrun
2025-02-13 10:16     ` Jerome Brunet
2025-02-13 12:26   ` Arnd Bergmann
2025-02-13 13:35     ` Jerome Brunet

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20250212144126.120231-1-theo.lebrun@bootlin.com \
    --to=theo.lebrun@bootlin.com \
    --cc=Laurent.pinchart@ideasonboard.com \
    --cc=abelvesa@kernel.org \
    --cc=airlied@gmail.com \
    --cc=andrzej.hajda@intel.com \
    --cc=arnd@arndb.de \
    --cc=bryan.odonoghue@linaro.org \
    --cc=conor.dooley@microchip.com \
    --cc=daire.mcnamara@microchip.com \
    --cc=dakr@kernel.org \
    --cc=david.m.ertman@intel.com \
    --cc=dianders@chromium.org \
    --cc=dri-devel@lists.freedesktop.org \
    --cc=festevam@gmail.com \
    --cc=gregkh@linuxfoundation.org \
    --cc=gregory.clement@bootlin.com \
    --cc=hdegoede@redhat.com \
    --cc=ilpo.jarvinen@linux.intel.com \
    --cc=imx@lists.linux.dev \
    --cc=ira.weiny@intel.com \
    --cc=jbrunet@baylibre.com \
    --cc=jernej.skrabec@gmail.com \
    --cc=jonas@kwiboo.se \
    --cc=kernel@pengutronix.de \
    --cc=khilman@baylibre.com \
    --cc=linux-amlogic@lists.infradead.org \
    --cc=linux-arm-kernel@lists.infradead.org \
    --cc=linux-clk@vger.kernel.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=linux-mips@vger.kernel.org \
    --cc=linux-riscv@lists.infradead.org \
    --cc=maarten.lankhorst@linux.intel.com \
    --cc=martin.blumenstingl@googlemail.com \
    --cc=mripard@kernel.org \
    --cc=mturquette@baylibre.com \
    --cc=neil.armstrong@linaro.org \
    --cc=p.zabel@pengutronix.de \
    --cc=peng.fan@nxp.com \
    --cc=platform-driver-x86@vger.kernel.org \
    --cc=rafael@kernel.org \
    --cc=rfoss@kernel.org \
    --cc=s.hauer@pengutronix.de \
    --cc=sboyd@kernel.org \
    --cc=shawnguo@kernel.org \
    --cc=simona@ffwll.ch \
    --cc=tzimmermann@suse.de \
    --cc=vladimir.kondratiev@mobileye.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox