Re: [PATCH v3 1/5] dt-bindings: clock: Document clock and reset unit of RK3528

Heiko Stübner
2025-02-24T09:09:35Z

Am Montag, 17. Februar 2025, 07:11:42 MEZ schrieb Yao Zi:
> There are two types of clocks in RK3528 SoC, CRU-managed and
> SCMI-managed. Independent IDs are assigned to them.
>
> For the reset part, differing from previous Rockchip SoCs and
> downstream bindings which embeds register offsets into the IDs, gapless
> numbers starting from zero are used.
>
> Signed-off-by: Yao Zi <ziyao@disroot.org>
> ---
> .../bindings/clock/rockchip,rk3528-cru.yaml | 64 +++
> .../dt-bindings/clock/rockchip,rk3528-cru.h | 453 ++++++++++++++++++
> .../dt-bindings/reset/rockchip,rk3528-cru.h | 241 ++++++++++
> 3 files changed, 758 insertions(+)
> create mode 100644 Documentation/devicetree/bindings/clock/rockchip,rk3528-cru.yaml
> create mode 100644 include/dt-bindings/clock/rockchip,rk3528-cru.h
> create mode 100644 include/dt-bindings/reset/rockchip,rk3528-cru.h
>
> diff --git a/Documentation/devicetree/bindings/clock/rockchip,rk3528-cru.yaml b/Documentation/devicetree/bindings/clock/rockchip,rk3528-cru.yaml
> new file mode 100644
> index 000000000000..5a3ec902351c
> --- /dev/null
> +++ b/Documentation/devicetree/bindings/clock/rockchip,rk3528-cru.yaml
> @@ -0,0 +1,64 @@
> +# SPDX-License-Identifier: (GPL-2.0-only OR BSD-2-Clause)
> +%YAML 1.2
> +---
> +$id: http://devicetree.org/schemas/clock/rockchip,rk3528-cru.yaml#
> +$schema: http://devicetree.org/meta-schemas/core.yaml#
> +
> +title: Rockchip RK3528 Clock and Reset Controller
> +
> +maintainers:
> + - Yao Zi <ziyao@disroot.org>
> +
> +description: |
> + The RK3528 clock controller generates the clock and also implements a reset
> + controller for SoC peripherals. For example, it provides SCLK_UART0 and
> + PCLK_UART0 as well as SRST_P_UART0 and SRST_S_UART0 for the first UART
> + module.
> + Each clock is assigned an identifier, consumer nodes can use it to specify
> + the clock. All available clock and reset IDs are defined in dt-binding
> + headers.
> +
> +properties:
> + compatible:
> + const: rockchip,rk3528-cru
> +
> + reg:
> + maxItems: 1
> +
> + clocks:

I do think this needs a
minItems: 1
maxItems: 2
or similar.

xin24m is the main oscillator everything else is supplied from, so is
absolutely required, but that gmac0 supply comes from an (probably)
optional clock supply from a mac phy?

So is possibly not available on a system without ethernet hardware?

Heiko