Re: [PATCH v5 00/21] Enable drm/imagination BXM-4-64 Support for LicheePi 4A

Krzysztof Kozlowski
2025-03-04T07:44:47Z

On 04/03/2025 08:38, Michal Wilczynski wrote:
>
>
> On 3/3/25 18:43, Krzysztof Kozlowski wrote:
>> On 03/03/2025 09:38, Michal Wilczynski wrote:
>>>
>>>
>>> On 2/21/25 10:12, Krzysztof Kozlowski wrote:
>>>> On Wed, Feb 19, 2025 at 03:02:18PM +0100, Michal Wilczynski wrote:
>>>>> The LicheePi 4A board, featuring the T-HEAD TH1520 SoC, includes an Imagination
>>>>> Technologies BXM-4-64 GPU. Initial support for this GPU was provided through a
>>>>> downstream driver [1]. Recently, efforts have been made to upstream support for
>>>>> the Rogue family GPUs, which the BXM-4-64 is part of [2].
>>>>>
>>>>> While the initial upstream driver focused on the AXE-1-16 GPU, newer patches
>>>>> have introduced support for the BXS-4-64 GPU [3]. The modern upstream
>>>>> drm/imagination driver is expected to support the BXM-4-64 as well [4][5]. As
>>>>> this support is being developed, it's crucial to upstream the necessary glue
>>>>> code including clock and power-domain drivers so they're ready for integration
>>>>> with the drm/imagination driver.
>>>>>
>>>>
>>>> This is v5 of big patchset which became huge. I understand you did like
>>>> that for v1 which was RFC. But it stopped being RFC.
>>>>
>>>> Split your patchset, keeping versioning and changelog, per subsystem.
>>>
>>> Sorry for the late reply—I didn't have access to email. I agree with
>>> your suggestion and will send the clock changes, firmware/power domain,
>>> reset, and drm/imagination updates as separate patchsets for merging.
>>
>>
>> How did you implement above comment? You did the split, right? Where is
>> versioning and where are changelogs?
>
> So I thought the sub-series should be versioned independently from v1 ?

Keep the versioning. Keep the changelog.

You now versioned your new set independently, so I don't understand your
question.

> Then linked the previous discussions in the cover letter, without
> copying them.

Nothing said this is the same patchset. You just mentioned some "bigger
series" cover letter. How some other bigger series is anyhow related?
And how can I find relevant pieces there?

You are supposed to make it easy for reviewers, not difficult.

Best regards,
Krzysztof