Re: [PATCH v5 19/21] riscv: dts: thead: Introduce power domain nodes with aon firmware

Michal Wilczynski
2025-04-16T11:22:42Z

On 4/15/25 20:48, Drew Fustini wrote:
> On Mon, Apr 14, 2025 at 07:04:29PM -0700, Drew Fustini wrote:
>> On Wed, Feb 19, 2025 at 03:02:37PM +0100, Michal Wilczynski wrote:
>>> The DRM Imagination GPU requires a power-domain driver. In the T-HEAD
>>> TH1520 SoC implements power management capabilities through the E902
>>> core, which can be communicated with through the mailbox, using firmware
>>> protocol.
>>>
>>> Add AON node, which servers as a power-domain controller.
>>>
>>> Signed-off-by: Michal Wilczynski <m.wilczynski@samsung.com>
>>> ---
>>> arch/riscv/boot/dts/thead/th1520.dtsi | 8 ++++++++
>>> 1 file changed, 8 insertions(+)
>>>
>>> diff --git a/arch/riscv/boot/dts/thead/th1520.dtsi b/arch/riscv/boot/dts/thead/th1520.dtsi
>>> index 197df1f32b25..474f31576a1b 100644
>>> --- a/arch/riscv/boot/dts/thead/th1520.dtsi
>>> +++ b/arch/riscv/boot/dts/thead/th1520.dtsi
>>> @@ -6,6 +6,7 @@
>>>
>>> #include <dt-bindings/interrupt-controller/irq.h>
>>> #include <dt-bindings/clock/thead,th1520-clk-ap.h>
>>> +#include <dt-bindings/power/thead,th1520-power.h>
>>>
>>> / {
>>> compatible = "thead,th1520";
>>> @@ -229,6 +230,13 @@ stmmac_axi_config: stmmac-axi-config {
>>> snps,blen = <0 0 64 32 0 0 0>;
>>> };
>>>
>>> + aon: aon {
>>> + compatible = "thead,th1520-aon";
>>> + mboxes = <&mbox_910t 1>;
>>> + mbox-names = "aon";
>>> + #power-domain-cells = <1>;
>>> + };
>>> +
>>> soc {
>>> compatible = "simple-bus";
>>> interrupt-parent = <&plic>;
>>> --
>>> 2.34.1
>>>
>>
>> Reviewed-by: Drew Fustini <drew@pdp7.com>
>>
>> I tested this on top of 6.15-rc1 and found no issues.
>>
>> -Drew
>
> I've applied to thead-dt-for-next:
> https://protect2.fireeye.com/v1/url?k=2f3b741b-4eb0613b-2f3aff54-74fe485fb347-beeac007773a982c&q=1&e=eb6b4dda-c02a-4e0a-831a-a28d0489f6c3&u=https%3A%2F%2Fgithub.com%2Fpdp7%2Flinux%2Fcommit%2F2bae46e3de2a64fe3a619d61b16da0c01b8df2a1
>
> Michal - are there any other dts patches that I should consider for 6.16
> PR? I would probably send to Arnd around 6.15-rc3 or 6.15-rc4.

Thanks for the heads-up.

I think the reset DT node would be a good candidate for inclusion [1].
Depending on how the clock series evolves, we might also consider this
commit without the reset part [2]. Similarly, if the PM series lands in
time, we may want to update the aon node to include the reset [3].

To avoid any last-minute issues, I can send a separate DT-only series
that includes all relevant patches targeting the next release. Just give
me a heads-up a few days before your PR, and I’ll make sure everything
is ready.

Best regards,
Michał

[1] - https://lore.kernel.org/all/20250219140239.1378758-21-m.wilczynski@samsung.com/
[2] - https://lore.kernel.org/all/20250219140239.1378758-19-m.wilczynski@samsung.com/
[3] - https://lore.kernel.org/all/20250414-apr_14_for_sending-v2-2-70c5af2af96c@samsung.com/

>
> Thanks,
> Drew
>