Re: [PATCH v5 20/21] riscv: dts: thead: Introduce reset controller node

Drew Fustini
2025-04-19T19:10:00Z

On Wed, Feb 19, 2025 at 03:02:38PM +0100, Michal Wilczynski wrote:
> T-HEAD TH1520 SoC requires to put the GPU out of the reset state as part
> of the power-up sequence.
>
> Signed-off-by: Michal Wilczynski <m.wilczynski@samsung.com>
> ---
> arch/riscv/boot/dts/thead/th1520.dtsi | 7 +++++++
> 1 file changed, 7 insertions(+)
>
> diff --git a/arch/riscv/boot/dts/thead/th1520.dtsi b/arch/riscv/boot/dts/thead/th1520.dtsi
> index 474f31576a1b..6b34aab4b455 100644
> --- a/arch/riscv/boot/dts/thead/th1520.dtsi
> +++ b/arch/riscv/boot/dts/thead/th1520.dtsi
> @@ -7,6 +7,7 @@
> #include <dt-bindings/interrupt-controller/irq.h>
> #include <dt-bindings/clock/thead,th1520-clk-ap.h>
> #include <dt-bindings/power/thead,th1520-power.h>
> +#include <dt-bindings/reset/thead,th1520-reset.h>

Are you okay if I omit this hunk? My thead-dt-for-next branch is based
on 6.15-rc1 but thead,th1520-reset.h only exists in next until the merge
window.

>
> / {
> compatible = "thead,th1520";
> @@ -497,6 +498,12 @@ clk: clock-controller@ffef010000 {
> #clock-cells = <1>;
> };
>
> + rst: reset-controller@ffef528000 {
> + compatible = "thead,th1520-reset";
> + reg = <0xff 0xef528000 0x0 0x4f>;
> + #reset-cells = <1>;
> + };
> +
> clk_vo: clock-controller@ffef528050 {
> compatible = "thead,th1520-clk-vo";
> reg = <0xff 0xef528050 0x0 0xfb0>;
> --
> 2.34.1
>

With the above caveat:

Reviewed-by: Drew Fustini <drew@pdp7.com>

-Drew