From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from foss.arm.com (foss.arm.com [217.140.110.172]) by smtp.subspace.kernel.org (Postfix) with ESMTP id 9ECBE2627E1; Mon, 24 Feb 2025 17:56:50 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=217.140.110.172 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1740419812; cv=none; b=YCvzjyP06BsOAwrwYv4wYVRvdR9PH+d5TUQpKgJecKU37jKgwQbSrzEAzqgi+WYjNDl5ZLJCDH2TRu3TEWP2HcxW3aX+krFpSvPj1Fao/M6qsc85wAQUVBXTAf9hhnCU2Z2qxVgD87HeUVVOZSrgQTTdPkk3kDgTeC0DoirmG78= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1740419812; c=relaxed/simple; bh=laLlXfTqdTi8U2cQjpNZyAGYUeq8S9FFniC6nm3tRK4=; h=Date:From:To:Cc:Subject:Message-ID:In-Reply-To:References: MIME-Version:Content-Type; b=q6YVwVPBPZAttrd3rrfv0VVLJIEoevajOXxaVGB/+Ph1tA3S9ty7EtHMhM6Ci2sG5xQQCahGy/c+5QN3mgi1riK2zWK91+KqMpKfbek5RYn6YABRlFh5MFaVP4H/HgC+PNJFo+sI0o+3rY4KxG08F6CSB6OuCsah5AHZ3TSzXvw= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=arm.com; spf=pass smtp.mailfrom=arm.com; arc=none smtp.client-ip=217.140.110.172 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=arm.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=arm.com Received: from usa-sjc-imap-foss1.foss.arm.com (unknown [10.121.207.14]) by usa-sjc-mx-foss1.foss.arm.com (Postfix) with ESMTP id 7991B152B; Mon, 24 Feb 2025 09:57:06 -0800 (PST) Received: from donnerap.manchester.arm.com (usa-sjc-imap-foss1.foss.arm.com [10.121.207.14]) by usa-sjc-imap-foss1.foss.arm.com (Postfix) with ESMTPSA id 4D9C63F5A1; Mon, 24 Feb 2025 09:56:46 -0800 (PST) Date: Mon, 24 Feb 2025 17:56:42 +0000 From: Andre Przywara To: Ryan Walklin Cc: Maxime Ripard , Chen-Yu Tsai , Maarten Lankhorst , Thomas Zimmermann , David Airlie , Daniel Vetter , Jernej Skrabec , Samuel Holland , Rob Herring , Krzysztof Kozlowski , Conor Dooley , Michael Turquette , Stephen Boyd , Chris Morgan , Hironori KIKUCHI , Philippe Simons , Dmitry Baryshkov , dri-devel@lists.freedesktop.org, linux-arm-kernel@lists.infradead.org, linux-sunxi@lists.linux.dev, devicetree@vger.kernel.org, linux-clk@vger.kernel.org, Conor Dooley Subject: Re: [PATCH v7 22/27] dt-bindings: allwinner: add H616 DE33 mixer binding Message-ID: <20250224175642.170c124e@donnerap.manchester.arm.com> In-Reply-To: <20250216183710.8443-23-ryan@testtoast.com> References: <20250216183710.8443-3-ryan@testtoast.com> <20250216183710.8443-23-ryan@testtoast.com> Organization: ARM X-Mailer: Claws Mail 3.18.0 (GTK+ 2.24.32; aarch64-unknown-linux-gnu) Precedence: bulk X-Mailing-List: linux-clk@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Type: text/plain; charset=US-ASCII Content-Transfer-Encoding: 7bit On Mon, 17 Feb 2025 07:36:22 +1300 Ryan Walklin wrote: Hi, > The Allwinner H616 and variants have a new display engine revision > (DE33). > > The mixer configuration registers are significantly different to the DE3 > and DE2 revisions, being split into separate top and display blocks, > therefore a fallback for the mixer compatible is not provided. > > Add a display engine mixer binding for the DE33. > > Signed-off-by: Ryan Walklin > Acked-by: Conor Dooley > Reviewed-by: Chen-Yu Tsai > > --- > Changelog v2..v3: > - Separate content into three patches for three separate subsystems > > Changelog v5..v6: > - increase reg maxItems to 3 and add conditional for h616-de33 > --- > .../allwinner,sun8i-a83t-de2-mixer.yaml | 21 ++++++++++++++++++- > 1 file changed, 20 insertions(+), 1 deletion(-) > > diff --git a/Documentation/devicetree/bindings/display/allwinner,sun8i-a83t-de2-mixer.yaml b/Documentation/devicetree/bindings/display/allwinner,sun8i-a83t-de2-mixer.yaml > index b75c1ec686ad2..274f5e6327333 100644 > --- a/Documentation/devicetree/bindings/display/allwinner,sun8i-a83t-de2-mixer.yaml > +++ b/Documentation/devicetree/bindings/display/allwinner,sun8i-a83t-de2-mixer.yaml > @@ -24,9 +24,11 @@ properties: > - allwinner,sun50i-a64-de2-mixer-0 > - allwinner,sun50i-a64-de2-mixer-1 > - allwinner,sun50i-h6-de3-mixer-0 > + - allwinner,sun50i-h616-de33-mixer-0 > > reg: > - maxItems: 1 > + minItems: 1 > + maxItems: 3 What are those three regions? I wonder if we should have reg-names here, to fix the order, and to document them on the way? > > clocks: > items: > @@ -61,6 +63,23 @@ properties: > required: > - port@1 > > +allOf: > + - if: > + properties: > + compatible: > + enum: > + - allwinner,sun50i-h616-de33-mixer-0 > + > + then: > + properties: > + reg: > + maxItems: 3 Should we override minItems here as well? I guess any driver would need all three region to work? Cheers, Andre > + > + else: > + properties: > + reg: > + maxItems: 1 > + > required: > - compatible > - reg