Re: [PATCH 00/13] airoha: en7581: clk cleanup + USB support

Rob Herring (Arm)
2025-03-10T14:36:21Z

On Sun, 09 Mar 2025 14:29:31 +0100, Christian Marangi wrote:
> This series implement all the changes required to correctly handle
> USB support for the Airoha EN7581 SoC.
>
> The first few patch are cleanup for the clock driver and the
> introduction of the SCU SSR SoC driver.
>
> The SoC always support USB 2.0 but for USB 3.0 it needs additional
> configuration for the Serdes port. Such port can be either configured
> for USB usage or for PCIe lines or HSGMII and these are configured
> in the SCU space.
>
> To correctly handle this, the SCU is changed to a simple-mfd
> implemenetation and the clock controller updated to follow this new
> node structure. Both implementation are supported to handle old
> binding.
>
> The xHCI USB is based on the Mediatek implementation but the PHY
> handling although conceptually similar, is indded different compared
> to Mediatek due to SSR checks and different port power up.
>
> The SSR driver expose an API to poll the current status of the Serdes
> port and the USB PHY driver validates it. Refer to the specific commit
> for additional info.
>
> Consider that there is currently an inconsistency as AN7581 and
> EN7581 refer to the same thing. This is due to the fact that
> the SoC born under EcoNet but then was acquired by Airoha.
>
> Christian Marangi (13):
> clk: en7523: convert driver to regmap API
> clk: en7523: generalize register clocks function
> dt-bindings: soc: airoha: add SCU SSR Serdes port binding
> dt-bindings: soc: airoha: add Documentation for Airoha AN7581 SCU SSR
> dt-bindings: mfd: add Documentation for Airoha EN7581 SCU
> dt-bindings: clock: airoha: make reg optional for Airoha EN7581
> clk: en7523: support getting regmap from parent node for EN7581
> soc: airoha: add support for configuring SCU SSR Serdes port
> dt-bindings: phy: Add documentation for Airoha AN7581 USB PHY
> phy: airoha: Add support for Airoha AN7581 USB PHY
> usb: host: add ARCH_AIROHA in XHCI MTK dependency
> arm64: dts: airoha: en7581: convert SCU clock node to MFD
> implementation
> arm64: dts: airoha: en7581: add USB and SCU SSR nodes
>
> .../bindings/clock/airoha,en7523-scu.yaml | 13 +-
> .../mfd/airoha,en7581-scu-sysctl.yaml | 68 +++
> .../bindings/phy/airoha,an7581-usb-phy.yaml | 106 ++++
> .../soc/airoha/airoha,an7581-scu-ssr.yaml | 106 ++++
> MAINTAINERS | 15 +
> arch/arm64/boot/dts/airoha/en7581.dtsi | 74 ++-
> drivers/clk/clk-en7523.c | 258 ++++----
> drivers/phy/Kconfig | 1 +
> drivers/phy/Makefile | 3 +-
> drivers/phy/airoha/Kconfig | 13 +
> drivers/phy/airoha/Makefile | 3 +
> drivers/phy/airoha/phy-airoha-usb.c | 554 ++++++++++++++++++
> drivers/soc/Kconfig | 1 +
> drivers/soc/Makefile | 1 +
> drivers/soc/airoha/Kconfig | 18 +
> drivers/soc/airoha/Makefile | 3 +
> drivers/soc/airoha/airoha-scu-ssr.c | 195 ++++++
> drivers/usb/host/Kconfig | 2 +-
> include/dt-bindings/soc/airoha,scu-ssr.h | 24 +
> include/linux/soc/airoha/airoha-scu-ssr.h | 17 +
> include/linux/soc/soc/airoha-scu-ssr.h | 17 +
> 21 files changed, 1355 insertions(+), 137 deletions(-)
> create mode 100644 Documentation/devicetree/bindings/mfd/airoha,en7581-scu-sysctl.yaml
> create mode 100644 Documentation/devicetree/bindings/phy/airoha,an7581-usb-phy.yaml
> create mode 100644 Documentation/devicetree/bindings/soc/airoha/airoha,an7581-scu-ssr.yaml
> create mode 100644 drivers/phy/airoha/Kconfig
> create mode 100644 drivers/phy/airoha/Makefile
> create mode 100644 drivers/phy/airoha/phy-airoha-usb.c
> create mode 100644 drivers/soc/airoha/Kconfig
> create mode 100644 drivers/soc/airoha/Makefile
> create mode 100644 drivers/soc/airoha/airoha-scu-ssr.c
> create mode 100644 include/dt-bindings/soc/airoha,scu-ssr.h
> create mode 100644 include/linux/soc/airoha/airoha-scu-ssr.h
> create mode 100644 include/linux/soc/soc/airoha-scu-ssr.h
>
> --
> 2.48.1
>
>
>

My bot found new DTB warnings on the .dts files added or changed in this
series.

Some warnings may be from an existing SoC .dtsi. Or perhaps the warnings
are fixed by another series. Ultimately, it is up to the platform
maintainer whether these warnings are acceptable or not. No need to reply
unless the platform maintainer has comments.

If you already ran DT checks and didn't see these error(s), then
make sure dt-schema is up to date:

pip3 install dtschema --upgrade

New warnings running 'make CHECK_DTBS=y for arch/arm64/boot/dts/airoha/' for 20250309132959.19045-1-ansuelsmth@gmail.com:

arch/arm64/boot/dts/airoha/en7581-evb.dtb: usb@1fab0000: compatible:0: 'mediatek,mtk-xhci' is not one of ['mediatek,mt2701-xhci', 'mediatek,mt2712-xhci', 'mediatek,mt7622-xhci', 'mediatek,mt7623-xhci', 'mediatek,mt7629-xhci', 'mediatek,mt7986-xhci', 'mediatek,mt7988-xhci', 'mediatek,mt8173-xhci', 'mediatek,mt8183-xhci', 'mediatek,mt8186-xhci', 'mediatek,mt8188-xhci', 'mediatek,mt8192-xhci', 'mediatek,mt8195-xhci', 'mediatek,mt8365-xhci']
from schema $id: http://devicetree.org/schemas/usb/mediatek,mtk-xhci.yaml#
arch/arm64/boot/dts/airoha/en7581-evb.dtb: usb@1fab0000: compatible: ['mediatek,mtk-xhci'] is too short
from schema $id: http://devicetree.org/schemas/usb/mediatek,mtk-xhci.yaml#
arch/arm64/boot/dts/airoha/en7581-evb.dtb: usb@1fad0000: compatible:0: 'mediatek,mtk-xhci' is not one of ['mediatek,mt2701-xhci', 'mediatek,mt2712-xhci', 'mediatek,mt7622-xhci', 'mediatek,mt7623-xhci', 'mediatek,mt7629-xhci', 'mediatek,mt7986-xhci', 'mediatek,mt7988-xhci', 'mediatek,mt8173-xhci', 'mediatek,mt8183-xhci', 'mediatek,mt8186-xhci', 'mediatek,mt8188-xhci', 'mediatek,mt8192-xhci', 'mediatek,mt8195-xhci', 'mediatek,mt8365-xhci']
from schema $id: http://devicetree.org/schemas/usb/mediatek,mtk-xhci.yaml#
arch/arm64/boot/dts/airoha/en7581-evb.dtb: usb@1fad0000: compatible: ['mediatek,mtk-xhci'] is too short
from schema $id: http://devicetree.org/schemas/usb/mediatek,mtk-xhci.yaml#