Re: [PATCH v5 2/5] dt-bindings: clock: spacemit: Add spacemit,k1-pll

Haylen Chu
2025-03-07T06:35:01Z

On Fri, Mar 07, 2025 at 12:29:43AM +0000, Yixun Lan wrote:
> Hi Haylen:
>
> On 17:57 Thu 06 Mar , Haylen Chu wrote:
> > Add definition for the PLL found on Spacemit K1 SoC, which takes the
> > external 24MHz oscillator as input and generates clocks in various
> > frequencies for the system.
> >
> > Signed-off-by: Haylen Chu <heylenay@4d2.org>
> > ---
> > .../bindings/clock/spacemit,k1-pll.yaml | 50 +++++++++++++++++++
> > include/dt-bindings/clock/spacemit,k1-ccu.h | 37 ++++++++++++++
> > 2 files changed, 87 insertions(+)
> > create mode 100644 Documentation/devicetree/bindings/clock/spacemit,k1-pll.yaml
> >
> > diff --git a/Documentation/devicetree/bindings/clock/spacemit,k1-pll.yaml b/Documentation/devicetree/bindings/clock/spacemit,k1-pll.yaml
> > new file mode 100644
> > index 000000000000..23d7aa1bc573
> > --- /dev/null
> > +++ b/Documentation/devicetree/bindings/clock/spacemit,k1-pll.yaml
> > @@ -0,0 +1,50 @@
> > +# SPDX-License-Identifier: GPL-2.0-only OR BSD-2-Clause
> > +%YAML 1.2
> > +---
> > +$id: http://devicetree.org/schemas/clock/spacemit,k1-pll.yaml#
> > +$schema: http://devicetree.org/meta-schemas/core.yaml#
> > +
> > +title: Spacemit K1 PLL
> > +
> > +maintainers:
> > + - Haylen Chu <heylenay@4d2.org>
> > +
> > +properties:
> > + compatible:
> > + const: spacemit,k1-pll
> > +
> > + reg:
> > + maxItems: 1
> > +
> > + clocks:
> > + description: External 24MHz oscillator
> > +
> > + spacemit,mpmu:
> how about naming it as "spacemit,mpmu-syscon" explicitly?
> to indicate this is a syscon phandle, it's more readable

It's okay but I'm not sure whether this helps a lot... will wait for the
maintainer to decide the name.

> > + $ref: /schemas/types.yaml#/definitions/phandle
> > + description:
> > + Phandle to the "Main PMU (MPMU)" syscon. It is used to check PLL
> > + lock status.
> > +
> > + "#clock-cells":
> > + const: 1
> > + description:
> > + See <dt-bindings/clock/spacemit,k1-ccu.h> for valid indices.
> > +
> > +required:
> > + - compatible
> > + - reg
> > + - clocks
> > + - spacemit,mpmu
> > + - "#clock-cells"
> > +
> > +additionalProperties: false
> > +
> > +examples:
> > + - |
> > + clock-controller@d4090000 {
> > + compatible = "spacemit,k1-pll";
> > + reg = <0xd4090000 0x1000>;
> > + clocks = <&vctcxo_24m>;
> > + spacemit,mpmu = <&sysctl_mpmu>;
> > + #clock-cells = <1>;
> > + };
> --

...

> Yixun Lan (dlan)
> Gentoo Linux Developer
> GPG Key ID AABEFD55

Best regards,
Haylen Chu