Re: [PATCH 05/17] dt-bindings: display: renesas,rzg2l-du: Add support for RZ/V2H(P) SoC

Lad, Prabhakar
2025-04-08T10:36:36Z

Hi Krzysztof,

Thank you for the review.

On Mon, Mar 31, 2025 at 9:24 AM Krzysztof Kozlowski <krzk@kernel.org> wrote:
>
> On Sun, Mar 30, 2025 at 10:07:01PM +0100, Prabhakar wrote:
> > allOf:
> > + - if:
> > + properties:
> > + compatible:
> > + contains:
> > + const: renesas,r9a07g044-du
>
> This goes probably after the if: block for renesas,r9a07g043u-du to keep
> sorting (if I get numbers correctly).
>
Agreed, I'll maintain the sort order here.

> > + then:
> > + properties:
> > + ports:
> > + properties:
> > + port@0:
> > + description: DSI
> > + port@1:
> > + description: DPI
> > +
> > + required:
> > + - port@0
> > + - port@1
> > - if:
> > properties:
> > compatible:
> > @@ -101,18 +119,20 @@ allOf:
> >
> > required:
> > - port@0
> > - else:
> > + - if:
> > + properties:
> > + compatible:
> > + contains:
> > + const: renesas,r9a09g057-du
> > + then:
> > properties:
> > ports:
> > properties:
> > port@0:
> > description: DSI
>
> port@1: false
Agreed, more validation.

Cheers,
Prabhakar