Linux clock framework development
 help / color / mirror / Atom feed
From: Brian Masney <bmasney@redhat.com>
To: sboyd@kernel.org, mturquette@baylibre.com
Cc: linux-clk@vger.kernel.org, linux-kernel@vger.kernel.org,
	mripard@redhat.com
Subject: [PATCH 0/8] clk: test: add tests for inconsistencies and limitations in the framework
Date: Mon,  7 Apr 2025 09:12:50 -0400	[thread overview]
Message-ID: <20250407131258.70638-1-bmasney@redhat.com> (raw)

Here's a series that introduces some clock provider kunit tests. These
tests are centered around inconsistencies and limitations in the clock
framework that may lead to some clocks unknowingly changing rates during
a rate change of their siblings.

The intent of the clock framework is to keep the siblings clock rate
stable during such an operation:

    clk_set_rate(clk, MY_NEW_RATE);

However, it assumes that the sibling can generate that rate in the first
place. In many situations, it can't, and it leads to numerous bugs and
solutions over the years.

https://lore.kernel.org/lkml/20230825-pll-mipi_keep_rate-v1-0-35bc43570730@oltmanns.dev/
https://lore.kernel.org/linux-kernel/20230807-pll-mipi_set_rate_parent-v6-0-f173239a4b59@oltmanns.dev/
https://lore.kernel.org/all/20241114065759.3341908-1-victor.liu@nxp.com/
https://lore.kernel.org/linux-clk/20241121-ge-ian-debug-imx8-clk-tree-v1-0-0f1b722588fe@bootlin.com/

We intend to fix these issues, but first we need to agree and document
what these shortcomings are. These patches are meant to do that, even
though some will be skipped as they are currently broken.

Special thanks to Maxime Ripard for the guidance and feedback on this
project so far.

Brian Masney (8):
  clk: test: introduce a few specific rate constants for mock testing
  clk: test: introduce clk_dummy_div for a mock divider
  clk: test: introduce test suite for sibling rate changes on a divider
  clk: test: introduce clk_dummy_gate for a mock gate
  clk: test: introduce test suite for sibling rate changes on a gate
  clk: test: introduce helper to create a mock mux
  clk: test: introduce test variation for sibling rate changes on a mux
  clk: test: introduce test variation for sibling rate changes on a
    gate/mux

 drivers/clk/clk_test.c | 601 +++++++++++++++++++++++++++++++++++------
 1 file changed, 513 insertions(+), 88 deletions(-)

-- 
2.49.0


             reply	other threads:[~2025-04-07 13:13 UTC|newest]

Thread overview: 10+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2025-04-07 13:12 Brian Masney [this message]
2025-04-07 13:12 ` [PATCH 1/8] clk: test: introduce a few specific rate constants for mock testing Brian Masney
2025-04-07 13:12 ` [PATCH 2/8] clk: test: introduce clk_dummy_div for a mock divider Brian Masney
2025-04-07 13:12 ` [PATCH 3/8] clk: test: introduce test suite for sibling rate changes on a divider Brian Masney
2025-04-07 13:12 ` [PATCH 4/8] clk: test: introduce clk_dummy_gate for a mock gate Brian Masney
2025-04-07 13:12 ` [PATCH 5/8] clk: test: introduce test suite for sibling rate changes on a gate Brian Masney
2025-04-07 13:12 ` [PATCH 6/8] clk: test: introduce helper to create a mock mux Brian Masney
2025-04-07 13:12 ` [PATCH 7/8] clk: test: introduce test variation for sibling rate changes on a mux Brian Masney
2025-04-07 13:12 ` [PATCH 8/8] clk: test: introduce test variation for sibling rate changes on a gate/mux Brian Masney
2025-05-28 23:22 ` [PATCH 0/8] clk: test: add tests for inconsistencies and limitations in the framework Brian Masney

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20250407131258.70638-1-bmasney@redhat.com \
    --to=bmasney@redhat.com \
    --cc=linux-clk@vger.kernel.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=mripard@redhat.com \
    --cc=mturquette@baylibre.com \
    --cc=sboyd@kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox