From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from smtp.kernel.org (aws-us-west-2-korg-mail-1.web.codeaurora.org [10.30.226.201]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 2621318C930; Thu, 1 May 2025 14:22:23 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=10.30.226.201 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1746109344; cv=none; b=J7mKMTTBhmPaZMsFQHC5rvWfmw9BoDEt5wBHrMqTpVfSTojKl24BFSSAvPWP6q8hL7mP5Do9PhRy+6D4el5Rn7AobwQbZrjqsTryhX87fMJ21z/oYPJExyJlkUi+a7+TFg44ISOv1kHeY2LVR5oS0UkwdNz5Sl2wksNmKbfqgzY= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1746109344; c=relaxed/simple; bh=rBzRwoJgC9nPVv1XokQKUJ4a0+Ap+oQYmBNV9icBp+M=; h=Date:From:To:Cc:Subject:Message-ID:References:MIME-Version: Content-Type:Content-Disposition:In-Reply-To; b=nutcyKwI8NJxX3gebQ8KeHQc84fpbKFsbhqW8KjGRrEctOsYqyfiAbllY0g1EZ5P7tt37sIJ/eiUBZU3hf6nIgvvWTEjsaEDZconlTMiPj0XIzxlQPVhHRl2l529AqJM6xXmjzHBRVoxtBNnbjGT34WxEqg6OBQDl2uKpzBe38s= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=kernel.org header.i=@kernel.org header.b=H2c/wNcs; arc=none smtp.client-ip=10.30.226.201 Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=kernel.org header.i=@kernel.org header.b="H2c/wNcs" Received: by smtp.kernel.org (Postfix) with ESMTPSA id 8D431C4CEE3; Thu, 1 May 2025 14:22:19 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=k20201202; t=1746109343; bh=rBzRwoJgC9nPVv1XokQKUJ4a0+Ap+oQYmBNV9icBp+M=; h=Date:From:To:Cc:Subject:References:In-Reply-To:From; b=H2c/wNcstc22sKguf3GzhxY8FNPZ0zc9gh4t30uC7yQTWApP0Cf15w/toqAhva0sa 5aLKUPskmITnWqkpx4ue8WGDDlovvDtKVIFZCXa7T6OwIrK2iGHnLuDw8FrubLL9Ox L5ZHMnwzab69aspDqWJSvyRO6JIs1dZLBXp7lIR33Y49tLppdT1pcBIVPljucpMeKW JH0AWCTsyDNpyK13+mqr3G4ESNr24TDf5skxL6CoH9+TwfQ6AHtc4z+HxiovWQc5SV rKwsslg4uUjRirfVT9W9BXmU0u4UYIyXmlat76v3tOhn9x81oGH1TwRooGEIay62kR 9RXI8ptCuftXQ== Date: Thu, 1 May 2025 15:22:17 +0100 From: Conor Dooley To: Inochi Amaoto Cc: Michael Turquette , Stephen Boyd , Rob Herring , Krzysztof Kozlowski , Conor Dooley , Chen Wang , Paul Walmsley , Palmer Dabbelt , Albert Ou , Alexandre Ghiti , Alexander Sverdlin , Thomas Bonnefille , Jeff Johnson , linux-clk@vger.kernel.org, devicetree@vger.kernel.org, sophgo@lists.linux.dev, linux-kernel@vger.kernel.org, linux-riscv@lists.infradead.org, Yixun Lan , Longbin Li Subject: Re: [PATCH 2/3] clk: sophgo: Add support for newly added precise compatible Message-ID: <20250501-shrubs-unmixable-a2a8a9bedd01@spud> References: <20250430020932.307198-1-inochiama@gmail.com> <20250430020932.307198-3-inochiama@gmail.com> <20250430-radiance-rebuilt-2caa906d5e6f@spud> <20250430-snort-raider-dbf10d14993f@spud> Precedence: bulk X-Mailing-List: linux-clk@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Type: multipart/signed; micalg=pgp-sha256; protocol="application/pgp-signature"; boundary="XVRDKcPyTtvEDhL7" Content-Disposition: inline In-Reply-To: --XVRDKcPyTtvEDhL7 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline Content-Transfer-Encoding: quoted-printable On Thu, May 01, 2025 at 06:43:07AM +0800, Inochi Amaoto wrote: > On Wed, Apr 30, 2025 at 04:37:01PM +0100, Conor Dooley wrote: > > On Wed, Apr 30, 2025 at 04:33:39PM +0100, Conor Dooley wrote: > > > On Wed, Apr 30, 2025 at 10:09:30AM +0800, Inochi Amaoto wrote: > > > > Add of device id definition for newly added precise compatible. > > > >=20 > > > > Signed-off-by: Inochi Amaoto > > > > --- > > > > drivers/clk/sophgo/clk-cv1800.c | 3 +++ > > > > 1 file changed, 3 insertions(+) > > > >=20 > > > > diff --git a/drivers/clk/sophgo/clk-cv1800.c b/drivers/clk/sophgo/c= lk-cv1800.c > > > > index e0c4dc347579..e10221df6385 100644 > > > > --- a/drivers/clk/sophgo/clk-cv1800.c > > > > +++ b/drivers/clk/sophgo/clk-cv1800.c > > > > @@ -1519,8 +1519,11 @@ static int cv1800_clk_probe(struct platform_= device *pdev) > > > > =20 > > > > static const struct of_device_id cv1800_clk_ids[] =3D { > > > > { .compatible =3D "sophgo,cv1800-clk", .data =3D &cv1800_desc }, > > > > + { .compatible =3D "sophgo,cv1800b-clk", .data =3D &cv1800_desc }, > > >=20 > > > Given the same data is used here, should there not be fallbacks in the > > > dt for some of these? For example, 1812 to 1800? Or is that not okay, > > > because 1800 is not a real device id? > > >=20 > > > > { .compatible =3D "sophgo,cv1810-clk", .data =3D &cv1810_desc }, > > > > + { .compatible =3D "sophgo,cv1812h-clk", .data =3D &cv1800_desc }, > > > > { .compatible =3D "sophgo,sg2000-clk", .data =3D &sg2000_desc }, > > > > + { .compatible =3D "sophgo,sg2002-clk", .data =3D &sg2000_desc }, > >=20 > > Actually, this one is a better example. sg2000 is not marked deprecated. > > sg2002 uses the same match data. Why is no fallback to sg2000 used for > > the sg2002 case? >=20 > Yeah, It is a good idea. I will take it, thanks, Can you point out the difference in the dt-binding patch when you do, between the sg2000 being a real device and the others not? --XVRDKcPyTtvEDhL7 Content-Type: application/pgp-signature; name="signature.asc" -----BEGIN PGP SIGNATURE----- iHUEABYIAB0WIQRh246EGq/8RLhDjO14tDGHoIJi0gUCaBODmQAKCRB4tDGHoIJi 0pqUAPwI/zQNgP9x1HvcIE0paiqb55dihwJ5KU9E0DUZ/tC4egEAigTEf+A6r4+2 rxWOVtgQTrgGBiBhzOKRtofcr/OrIw0= =6kou -----END PGP SIGNATURE----- --XVRDKcPyTtvEDhL7--