From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from foss.arm.com (foss.arm.com [217.140.110.172]) by smtp.subspace.kernel.org (Postfix) with ESMTP id 107441EFFA3; Thu, 1 May 2025 12:22:15 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=217.140.110.172 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1746102137; cv=none; b=jKXvTuC3rw38wJKdILQ5d7QWR78TEpDZ/oGJlx/NkU4nXyHJNr0zNSC4GGE6pgEzcjRvDArfnq0Qe8kUbFIdkjVJbCXMJVeOrjeNi4CI7E9ZszGZcYENK3S+Ef0W49gwotb8boAw0qN6Jt0LxPLRTE6B3cg/jg9r9S9mR5VCRv0= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1746102137; c=relaxed/simple; bh=mxKifamzzXncn/QsKCHnl10Bc/4VPOAAX/UPUk14YDM=; h=Date:From:To:Cc:Subject:Message-ID:In-Reply-To:References: MIME-Version:Content-Type; b=Yt1He6noRm8YwAGww4AL2IfVCahfUeK7gRUNhlDu8uaw7eQ2zDOLj2HtokzY5P6kQUXnKcDxHKXfeYEQIcTdGZGDDP+0yxhJr0zPgO9RmAPiqxgYbpgfVLFOss4kcHANL8Xi4yPGFVs6NOc9bY03dzgPfKVES0t4zObBFDo+56w= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=arm.com; spf=pass smtp.mailfrom=arm.com; arc=none smtp.client-ip=217.140.110.172 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=arm.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=arm.com Received: from usa-sjc-imap-foss1.foss.arm.com (unknown [10.121.207.14]) by usa-sjc-mx-foss1.foss.arm.com (Postfix) with ESMTP id C169F1D14; Thu, 1 May 2025 05:22:07 -0700 (PDT) Received: from donnerap.manchester.arm.com (usa-sjc-imap-foss1.foss.arm.com [10.121.207.14]) by usa-sjc-imap-foss1.foss.arm.com (Postfix) with ESMTPSA id 12B663F673; Thu, 1 May 2025 05:22:13 -0700 (PDT) Date: Thu, 1 May 2025 13:22:11 +0100 From: Andre Przywara To: Chen-Yu Tsai Cc: Michael Turquette , Stephen Boyd , Jernej Skrabec , Samuel Holland , , , , Subject: Re: [PATCH] clk: sunxi-ng: fix order of arguments in clock macro Message-ID: <20250501132211.0310ae49@donnerap.manchester.arm.com> In-Reply-To: <174610166405.2974716.1586244113913047340.b4-ty@csie.org> References: <20250430095325.477311-1-andre.przywara@arm.com> <174610166405.2974716.1586244113913047340.b4-ty@csie.org> Organization: ARM X-Mailer: Claws Mail 3.18.0 (GTK+ 2.24.32; aarch64-unknown-linux-gnu) Precedence: bulk X-Mailing-List: linux-clk@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Type: text/plain; charset=US-ASCII Content-Transfer-Encoding: 7bit On Thu, 1 May 2025 20:14:24 +0800 Chen-Yu Tsai wrote: Hi, > On Wed, 30 Apr 2025 10:53:25 +0100, Andre Przywara wrote: > > When introducing the SUNXI_CCU_MP_DATA_WITH_MUX_GATE_FEAT macro, the order > > of the last two arguments was different between the users and the > > definition: features became flags and flags became features. > > > > This just didn't end up in a desaster yet because most users ended up > > passing 0 for both arguments, and other clocks (for the new A523 SoC) are > > not yet used. > > > > [...] > > Applied to clk-fixes-for-6.15 in git@github.com:linux-sunxi/linux-sunxi.git, thanks! thanks for that, but the URL here is not correct, is it? Should be the kernel.org repo instead? Saw this already in other "applied" emails. Cheers, Andre > > [1/1] clk: sunxi-ng: fix order of arguments in clock macro > commit: 4a9c3c3215491f25bc66d615faa921c814b1a479 > > Best regards,