Re: [PATCH v6 2/6] soc: spacemit: create a header for clock/reset registers

Alex Elder
2025-05-08T11:40:07Z

On 5/7/25 11:16 PM, Haylen Chu wrote:
> On Tue, May 06, 2025 at 04:06:33PM -0500, Alex Elder wrote:
>> Move the definitions of register offsets and fields used by the SpacemiT
>> K1 SoC CCUs into a separate header file, so that they can be shared by
>> the reset driver that will be found under drivers/reset.
>>
>> Signed-off-by: Alex Elder <elder@riscstar.com>
>> ---
>> drivers/clk/spacemit/ccu-k1.c | 111 +--------------------------------
>> include/soc/spacemit/ccu_k1.h | 113 ++++++++++++++++++++++++++++++++++
>
> CCU is abbreviated from "clock controller unit" thus the filename seems
> a little strange to me. Will k1-syscon.h be a better name? We could put
> all syscon registers together when introducing the power-domain driver
> later, which could provide an overall view of register layout.

I'm OK with making that change.

To me the "CCU" was the that IP block that offered clock and
reset controls (and maybe a few other things?). But renaming
it, given we're separating the functionality more clearly,
is pretty reasonable.

Thanks.

-Alex

>> 2 files changed, 114 insertions(+), 110 deletions(-)
>> create mode 100644 include/soc/spacemit/ccu_k1.h
>
> Best regards,
> Haylen Chu