Re: [PATCH v6 1/6] dt-bindings: soc: spacemit: define spacemit,k1-ccu resets

Krzysztof Kozlowski
2025-05-08T12:02:34Z

On 08/05/2025 00:35, Yixun Lan wrote:
>> + - if:
>> + properties:
>> + compatible:
>> + contains:
>> + enum:
>> + - spacemit,k1-syscon-apbc
>> + - spacemit,k1-syscon-apmu
>> + - spacemit,k1-syscon-mpmu
>> + then:
>> + required:
>> + - clocks
>> + - clock-names
>> + - "#clock-cells"
>>
>> additionalProperties: false
>>
>> diff --git a/include/dt-bindings/clock/spacemit,k1-syscon.h b/include/dt-bindings/clock/spacemit,k1-syscon.h
>> index 35968ae982466..f5965dda3b905 100644
>> --- a/include/dt-bindings/clock/spacemit,k1-syscon.h
>> +++ b/include/dt-bindings/clock/spacemit,k1-syscon.h
> would it be better to move all reset definition to its dedicated dir?
> which like: include/dt-bindings/reset/spacemit,k1-syscon.h?

Please kindly trim the replies from unnecessary context. It makes it
much easier to find new content.

I don't get why such comments are appearing so late - at v6. There was
nothing from you about this in v1, v2 and v3, which finally got reviewed.

I just feel people wait for maintainers to review and only after they
will add their 2 cents of nitpicks or even some more important things
potentially invalidating the review. Lesson for me: do not review
people's work before it reaches v10, right?

Best regards,
Krzysztof