From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mail-qt1-f180.google.com (mail-qt1-f180.google.com [209.85.160.180]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id E1BB925D540 for ; Sun, 11 May 2025 17:39:36 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=209.85.160.180 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1746985178; cv=none; b=VOfsu1aUoUHVDRoqL5mK6WPJK86nbKR1NUYnD82pImEJ0o+JPdg6slTSmMMyrBinr9yFvBg0jpEy0OLmpck28IzC7d2/hBOk+6T14Qq5y2pe73hTPmsVUw+tPE/fRcL85oaRpUfANo8oatW7vYvfgbVx1PfI6XWoAP6RAIjw+k0= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1746985178; c=relaxed/simple; bh=IPXduNjdPqXlwZF1nLbl8D7KU2jgmcdSUy8mFKn4DLY=; h=From:To:Cc:Subject:Date:Message-Id:MIME-Version; b=nKBD+8BiAex0tFUeMoM5U7CyGBHYkkZkfp9Pri4Pu/shH1KcW4KnknLtp5+6NXDhNSnZ1i+amPprCUbISJ0jrVt0i5vAykpsH9StHos6GkywsXjyc+mYQ4Sy3RMlqPx5Xwu+Vnjz51J+k/FlXIpl63EluYyulQ0ixArlRYKNxKE= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=none (p=none dis=none) header.from=libre.computer; spf=none smtp.mailfrom=libretech.co; dkim=pass (2048-bit key) header.d=libre.computer header.i=@libre.computer header.b=SUvMbhWY; arc=none smtp.client-ip=209.85.160.180 Authentication-Results: smtp.subspace.kernel.org; dmarc=none (p=none dis=none) header.from=libre.computer Authentication-Results: smtp.subspace.kernel.org; spf=none smtp.mailfrom=libretech.co Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=libre.computer header.i=@libre.computer header.b="SUvMbhWY" Received: by mail-qt1-f180.google.com with SMTP id d75a77b69052e-47664364628so45582321cf.1 for ; Sun, 11 May 2025 10:39:36 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=libre.computer; s=google; t=1746985176; x=1747589976; darn=vger.kernel.org; h=content-transfer-encoding:mime-version:message-id:date:subject:cc :to:from:from:to:cc:subject:date:message-id:reply-to; bh=xLoioQfYdPBgm49bPKitfsKJOSsTnQU6DqnNOtLxcjQ=; b=SUvMbhWYe1AOzh8qEaf8fDuvtdEd4nDyBg09KVt8Cgs3HcMwUAdz/VuylRnUV6iBdh jUbcMLmcp6Vxa2sl7Q6YXwCjtynsDBeB13/3XHBUhRutYaCNQ/qlaDt718eLNs/Lun3Z MD096u+YMLXx1C3AhdIA6jxPBnlqpauikcf7sK9fc4GDortMFnUkTuxQSIm1WusIYZ1y e20Ufqq/FRSP3euK80ff04QGz785i5zZQkOa2sUE/DU2fvpQhhB02Tcs5uZ58OfmqK93 1lJ65V4h4YAyoMA41+u28PeOCPUuslfw/BfadhCGdNtn5AOiHTP/jBahxsVYkTJRV8gd mTjw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1746985176; x=1747589976; h=content-transfer-encoding:mime-version:message-id:date:subject:cc :to:from:x-gm-message-state:from:to:cc:subject:date:message-id :reply-to; bh=xLoioQfYdPBgm49bPKitfsKJOSsTnQU6DqnNOtLxcjQ=; b=cZbxDv1S1CAoXxbtjr+8j6CQos8BX1qnCi0uPBMFDTWNobn+LUkOjivuk9C+pWYEgs NMnsqEvSqLbNKKuCE7BpS8gtAJM6tWUhtobmbLo2WxkVmyq/cwlfya1AuVifOkFXmhza b6MNRmR3e10IVpnW9cB4v86TD76LpkSog6x7Dt//cPuCds1dhScQI0+GZCbNNPT0h4Vo 4dySRrOmHKv+iBOer+7fPJ9OBdLeL9vgaG+4xhQhSlMwxMw9G4OYbMhlGS1LMXlo0fn2 fk9uj/VJC/Xe3K/XJrvG/YTlwIZSaTghopYQ6OkSMwOh1+DHfXdfwo6YKV8SQRl+eu+2 7PaA== X-Forwarded-Encrypted: i=1; AJvYcCWR28JdVmH0Nx6DRnwSykqmcM9b1PbuOKX2GExXmvbkSbMkL7r36lUZYUMZR8gaV15yjn1NtijeICA=@vger.kernel.org X-Gm-Message-State: AOJu0YyZkBUYW/rpGazxXerKt3ongaWhS7/las6qxkh+IBZEf0dtvoMW 8VfGpsKZiCFiGRK+B32tRGp91pQhY9tmgb7CyX/D2YPGUNF9Rqgm7WVLz+FLNw== X-Gm-Gg: ASbGnctpT1JVZY+hl+PXwhJRfqDG3/8OXiHbXutsUDoVR9lLrwIDRDdpyvqJ+5w1/q0 mxdM68Kt8UXvoSbqEqksMWF5jbrLKivZl/LPqqMbhMM6WoHlEPfqHqXakq/iunJPnkZHzoRQAC4 T6aH8jAcGy8K/3s4gyI/L8qMRHDhHrLdhghMRsOFx6z+LzmCOOiAs7eR5ra7mNZ7TMowqcn1hvk eVwGJTZ5X40t2V18qX/J0arpoBxxuJnUPHaK7IBRxB0yWfzGejABxwjAiMiv0X2dpFG8SThK8ht hCHduTEEU3tM9zsUizW7N0xDKUdh9NdrlJKKQcPgwv/BZ7Y= X-Google-Smtp-Source: AGHT+IGbtN6p73kbilpYBJERKanPWex1vuDrJr9UjFDjOEDztJIOHD7xUAEl7SH4fqjj9AVcDWDKXw== X-Received: by 2002:ac8:5d0d:0:b0:477:6e32:aae2 with SMTP id d75a77b69052e-4945285d6b1mr173557071cf.0.1746985175732; Sun, 11 May 2025 10:39:35 -0700 (PDT) Received: from localhost ([2607:fb91:eb2:c0a0:10e4:4464:87db:3a66]) by smtp.gmail.com with ESMTPSA id d75a77b69052e-49452588d92sm38259301cf.59.2025.05.11.10.39.35 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Sun, 11 May 2025 10:39:35 -0700 (PDT) From: Da Xue To: Neil Armstrong , Jerome Brunet , Michael Turquette , Stephen Boyd , Kevin Hilman , Martin Blumenstingl Cc: Da Xue , stable@vger.kernel.org, linux-amlogic@lists.infradead.org, linux-clk@vger.kernel.org, linux-arm-kernel@lists.infradead.org, linux-kernel@vger.kernel.org Subject: [PATCH v2] clk: meson-g12a: fix missing spicc clks to clk_sel Date: Sun, 11 May 2025 13:39:26 -0400 Message-Id: <20250511173926.1468374-1-da@libre.computer> X-Mailer: git-send-email 2.39.5 Precedence: bulk X-Mailing-List: linux-clk@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Transfer-Encoding: 8bit HHI_SPICC_CLK_CNTL bits 25:23 controls spicc clk_sel. It is missing fclk_div 2 and gp0_pll which causes the spicc module to output the incorrect clocks for spicc sclk at 2.5x the expected rate. Add the missing clocks resolves this. Fixes: a18c8e0b7697 ("clk: meson: g12a: add support for the SPICC SCLK Source clocks") Cc: # 6.1 Signed-off-by: Da Xue --- Changelog: v1 -> v2: add Fixes as an older version of the patch was incorrectly sent as v1 --- drivers/clk/meson/g12a.c | 2 ++ 1 file changed, 2 insertions(+) diff --git a/drivers/clk/meson/g12a.c b/drivers/clk/meson/g12a.c index 4f92b83965d5a..892862bf39996 100644 --- a/drivers/clk/meson/g12a.c +++ b/drivers/clk/meson/g12a.c @@ -4099,8 +4099,10 @@ static const struct clk_parent_data spicc_sclk_parent_data[] = { { .hw = &g12a_clk81.hw }, { .hw = &g12a_fclk_div4.hw }, { .hw = &g12a_fclk_div3.hw }, + { .hw = &g12a_fclk_div2.hw }, { .hw = &g12a_fclk_div5.hw }, { .hw = &g12a_fclk_div7.hw }, + { .hw = &g12a_gp0_pll.hw, }, }; static struct clk_regmap g12a_spicc0_sclk_sel = { -- 2.39.5