From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from us-smtp-delivery-124.mimecast.com (us-smtp-delivery-124.mimecast.com [170.10.133.124]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 9A01027466A for ; Thu, 10 Jul 2025 15:21:00 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=170.10.133.124 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1752160862; cv=none; b=kdKrDzvpVMDBTkJFN+INFavfbKEwWaGcJT7c2dUd3PE7CiPZF82fAUYMBjoLCStRpr5N93fIrG4mWfBD7lzZFwHGmiZQ0BnEp1tZdriCmzHy59oce5P5+GMFF3XkbYd+0MtqWUNabhr1rQnjnQ8eiPdnhOSciyj6oxS7BvTwofg= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1752160862; c=relaxed/simple; bh=oTegq5tfB2V7DcSOZNV9XX2rhgoU7Wa+qoYDD3MtOpY=; h=From:Date:Subject:MIME-Version:Content-Type:Message-Id:References: In-Reply-To:To:Cc; b=WCGjw1qh9O9wL4wkwEhShE4lbtxXZSlpTGbDUogfz2guYEYEZwVA4luNEqn79mFW58bcqjGF/SMqkIxlvfcfDd1JajZpK+tfIVTQW98eKuppjM/Dv7mYx7DlFebh4+j+3clTwr9LKmOKP+YAFNvVnIlypGGS7+jdtz+k6oCdz84= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=pass (p=quarantine dis=none) header.from=redhat.com; spf=pass smtp.mailfrom=redhat.com; dkim=pass (1024-bit key) header.d=redhat.com header.i=@redhat.com header.b=creHqFdN; arc=none smtp.client-ip=170.10.133.124 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=quarantine dis=none) header.from=redhat.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=redhat.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (1024-bit key) header.d=redhat.com header.i=@redhat.com header.b="creHqFdN" DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1752160859; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=0aZ7iow2nlSmHO3Sa6zhsOQGqzvxbDdCc1+cSeaMIJY=; b=creHqFdNmRsF1jerBqkBvqJ7mZeDlNczI/w7e7ISCyRmjNMP5cJO5W9Qhn9PAjqLQTbEw6 iZWT6zyVUh2U+MYKdnJi5b1kyqNS0tXhqkrz3vcfmDItSyvtcu75TmZgWI/nS4JHtjsaTm Vuuw4dIYqdxrCxdJx8QKm089I+UESdQ= Received: from mail-qt1-f198.google.com (mail-qt1-f198.google.com [209.85.160.198]) by relay.mimecast.com with ESMTP with STARTTLS (version=TLSv1.3, cipher=TLS_AES_256_GCM_SHA384) id us-mta-230-mT2EPiO4NlOG6U0YpKPOVg-1; Thu, 10 Jul 2025 11:20:58 -0400 X-MC-Unique: mT2EPiO4NlOG6U0YpKPOVg-1 X-Mimecast-MFC-AGG-ID: mT2EPiO4NlOG6U0YpKPOVg_1752160858 Received: by mail-qt1-f198.google.com with SMTP id d75a77b69052e-4a762876813so17542681cf.2 for ; Thu, 10 Jul 2025 08:20:58 -0700 (PDT) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1752160858; x=1752765658; h=cc:to:in-reply-to:references:message-id:content-transfer-encoding :mime-version:subject:date:from:x-gm-message-state:from:to:cc :subject:date:message-id:reply-to; bh=0aZ7iow2nlSmHO3Sa6zhsOQGqzvxbDdCc1+cSeaMIJY=; b=VRfU4vQGQUk03GVA7wVNTBclFrBWisSQ71vEfwC30jIzmqrVa/GAASUU1V8UlrurgK ovlPh1QGXZkOqqGAxrwZ9pNYqVHuVb9j+SmTZ2D09LNbxxQK2stp0sqFP7OamN1tjoEA ve70s71KHEbTx7Al36Mz8hL9ignjUDbojW+ZgR4JQJbiqzZhkts7X8AqPuZqg6JdN8xA OJnywv4qYrAoJc9a3+c4DoakYtucNenePizpRTys+AEFDeU95nKZXPR3AwcKBSIG4BRp Zogz8Z8Rhj5YjS9XQl4q7MFczeGBm+Xi4LRsQ/nR0fGoa+4WOUO6iEM3i5Stq1ot0bGt /DzQ== X-Gm-Message-State: AOJu0YwIyuEWIzpj/cGQEbxG7068dLkA7pNnSxi8SM2FvhFtIlHknero cGsKiHhqZiDjquB9zgu4WBWZPWhirKsEaVLS2YL3vk3+EjUimwmlIHnhlZWA8Haubafv5w6sMxU J1nord+9sTNXGaVvvrVP5wQZci6EPTHYKfk6hL/baeG/k14/3nPy9bAh19KCQ1A== X-Gm-Gg: ASbGnctMl8jbUJX/sdA4JZIbWj8/bvl4owT966j1OunUV1OvPTS4Yy699/ftvilqLni OkY4HLdoFOWKDi3YpuUbYWt42aRvhOo+jmt0Nt+NNdNDjxto2+L1ydEttFNNYsvwN2WQmqkEqhp 97mn4OzxePp+QyONMynIeMkIHLgw30sLPC33fxTJ/U8fpru/GAkyp4W4LcyScavGeNplnL/JKPB 23pIA2LRUifw713VGLoKWD4iJ7jjWaD2pTFffWOFlw0jD5ixdJRjPnguvL7aBFj/phpauJK3Apn T6+rVds60WOTMuAEy3gMSuNgsNHr1jMj4IWe8jyBeZHOaG+7DxJRZW2TIFh3 X-Received: by 2002:ac8:5a83:0:b0:4a7:9d00:770 with SMTP id d75a77b69052e-4a9dec57aa9mr107799101cf.18.1752160857805; Thu, 10 Jul 2025 08:20:57 -0700 (PDT) X-Google-Smtp-Source: AGHT+IFW1Y/+ZghE0XOiqPvb5+bbhr0BhriZx2/H84nr6c5hQpG4IkOaOonwxFNS6q9oehgxfat3nw== X-Received: by 2002:ac8:5a83:0:b0:4a7:9d00:770 with SMTP id d75a77b69052e-4a9dec57aa9mr107798321cf.18.1752160857249; Thu, 10 Jul 2025 08:20:57 -0700 (PDT) Received: from [192.168.1.3] (c-73-183-52-120.hsd1.pa.comcast.net. [73.183.52.120]) by smtp.gmail.com with ESMTPSA id d75a77b69052e-4a9edeee2c2sm9654471cf.74.2025.07.10.08.20.54 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Thu, 10 Jul 2025 08:20:56 -0700 (PDT) From: Brian Masney Date: Thu, 10 Jul 2025 11:20:22 -0400 Subject: [PATCH 02/15] rtc: hym8563: fix incorrect maximum clock rate handling Precedence: bulk X-Mailing-List: linux-clk@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: 7bit Message-Id: <20250710-rtc-clk-round-rate-v1-2-33140bb2278e@redhat.com> References: <20250710-rtc-clk-round-rate-v1-0-33140bb2278e@redhat.com> In-Reply-To: <20250710-rtc-clk-round-rate-v1-0-33140bb2278e@redhat.com> To: Alexandre Belloni , Akinobu Mita , Michael Turquette , Heiko Stuebner , Andrew Morton , Avi Fishman , Tomer Maimon , Tali Perry , Patrick Venture , Nancy Yuen , Benjamin Fair , Mia Lin , Michael McCormick , Heiko Schocher , Parthiban Nallathambi , Antoniu Miclaus , Maxime Ripard , Stephen Boyd Cc: linux-clk@vger.kernel.org, linux-rtc@vger.kernel.org, linux-kernel@vger.kernel.org, openbmc@lists.ozlabs.org, Brian Masney X-Mailer: b4 0.14.2 X-Developer-Signature: v=1; a=ed25519-sha256; t=1752160847; l=1048; i=bmasney@redhat.com; s=20250528; h=from:subject:message-id; bh=oTegq5tfB2V7DcSOZNV9XX2rhgoU7Wa+qoYDD3MtOpY=; b=g2MQCAAnSehCZ9tjenRcNXWBC1pOM+MFKKZ0kDoelFsePnd5wSPzRosgQPIlyhLjYj1+jskfi fLHbu93SQr/A3IjwrnMB769Q5Odb2T9TMdLRnSLSgnjgIWwtway/qbM X-Developer-Key: i=bmasney@redhat.com; a=ed25519; pk=x20f2BQYftANnik+wvlm4HqLqAlNs/npfVcbhHPOK2U= When hym8563_clkout_round_rate() is called with a requested rate higher than the highest supported rate, it currently returns 0, which disables the clock. According to the clk API, round_rate() should instead return the highest supported rate. Update the function to return the maximum supported rate in this case. Fixes: dcaf038493525 ("rtc: add hym8563 rtc-driver") Signed-off-by: Brian Masney --- drivers/rtc/rtc-hym8563.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/drivers/rtc/rtc-hym8563.c b/drivers/rtc/rtc-hym8563.c index 63f11ea3589d6439ac0ee7f6ee4ab70e2a52bff4..759dc2ad6e3b2ad57072b35a2642ec5bb78cd98c 100644 --- a/drivers/rtc/rtc-hym8563.c +++ b/drivers/rtc/rtc-hym8563.c @@ -294,7 +294,7 @@ static long hym8563_clkout_round_rate(struct clk_hw *hw, unsigned long rate, if (clkout_rates[i] <= rate) return clkout_rates[i]; - return 0; + return clkout_rates[0]; } static int hym8563_clkout_set_rate(struct clk_hw *hw, unsigned long rate, -- 2.50.0