linux-clk.vger.kernel.org archive mirror
 help / color / mirror / Atom feed
From: Sudeep Holla <sudeep.holla@arm.com>
To: Brian Masney <bmasney@redhat.com>
Cc: Paul Walmsley <paul@pwsan.com>,
	Aaro Koskinen <aaro.koskinen@iki.fi>,
	Janusz Krzysztofik <jmkrzyszt@gmail.com>,
	Tony Lindgren <tony@atomide.com>,
	Russell King <linux@armlinux.org.uk>,
	Andreas Kemnade <andreas@kemnade.info>,
	Kevin Hilman <khilman@baylibre.com>,
	Roger Quadros <rogerq@kernel.org>,
	Linus Walleij <linus.walleij@linaro.org>,
	Liviu Dudau <liviu.dudau@arm.com>,
	Lorenzo Pieralisi <lpieralisi@kernel.org>,
	Maxime Ripard <mripard@kernel.org>,
	Stephen Boyd <sboyd@kernel.org>,
	linux-clk@vger.kernel.org, linux-omap@vger.kernel.org,
	linux-arm-kernel@lists.infradead.org,
	linux-kernel@vger.kernel.org
Subject: Re: [PATCH 3/3] ARM: versatile: clock: convert from round_rate() to determine_rate()
Date: Fri, 11 Jul 2025 09:51:39 +0100	[thread overview]
Message-ID: <20250711-invaluable-enchanted-baboon-53fb4f@sudeepholla> (raw)
In-Reply-To: <20250710-arm32-clk-round-rate-v1-3-a9146b77aca9@redhat.com>

On Thu, Jul 10, 2025 at 07:42:18PM -0400, Brian Masney wrote:
> The round_rate() clk ops is deprecated, so migrate this driver from
> round_rate() to determine_rate() using the Coccinelle semantic patch
> on the cover letter of this series.
> 

Acked-by: Sudeep Holla <sudeep.holla@arm.com>

> Signed-off-by: Brian Masney <bmasney@redhat.com>
> ---
>  arch/arm/mach-versatile/spc.c | 9 +++++----
>  1 file changed, 5 insertions(+), 4 deletions(-)
> 
> diff --git a/arch/arm/mach-versatile/spc.c b/arch/arm/mach-versatile/spc.c
> index 790092734cf6155daa63c44a1e5af00ecef30737..812db32448fcd415fa1a60f8bb971661369151e1 100644
> --- a/arch/arm/mach-versatile/spc.c
> +++ b/arch/arm/mach-versatile/spc.c
> @@ -497,12 +497,13 @@ static unsigned long spc_recalc_rate(struct clk_hw *hw,
>  	return freq * 1000;
>  }
>  
> -static long spc_round_rate(struct clk_hw *hw, unsigned long drate,
> -		unsigned long *parent_rate)
> +static int spc_determine_rate(struct clk_hw *hw, struct clk_rate_request *req)
>  {
>  	struct clk_spc *spc = to_clk_spc(hw);
>  
> -	return ve_spc_round_performance(spc->cluster, drate);
> +	req->rate = ve_spc_round_performance(spc->cluster, req->rate);
> +
> +	return 0;
>  }
>  
>  static int spc_set_rate(struct clk_hw *hw, unsigned long rate,
> @@ -515,7 +516,7 @@ static int spc_set_rate(struct clk_hw *hw, unsigned long rate,
>  
>  static struct clk_ops clk_spc_ops = {
>  	.recalc_rate = spc_recalc_rate,
> -	.round_rate = spc_round_rate,
> +	.determine_rate = spc_determine_rate,
>  	.set_rate = spc_set_rate,
>  };
>  
> 
> -- 
> 2.50.0
> 

-- 
Regards,
Sudeep

  reply	other threads:[~2025-07-11  8:51 UTC|newest]

Thread overview: 7+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2025-07-10 23:42 [PATCH 0/3] ARM: convert from clk round_rate() to determine_rate() Brian Masney
2025-07-10 23:42 ` [PATCH 1/3] ARM: OMAP1: clock: convert from " Brian Masney
2025-07-13 20:35   ` Janusz Krzysztofik
2025-07-10 23:42 ` [PATCH 2/3] ARM: OMAP2+: " Brian Masney
2025-07-10 23:42 ` [PATCH 3/3] ARM: versatile: " Brian Masney
2025-07-11  8:51   ` Sudeep Holla [this message]
2025-07-11 17:45   ` Linus Walleij

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20250711-invaluable-enchanted-baboon-53fb4f@sudeepholla \
    --to=sudeep.holla@arm.com \
    --cc=aaro.koskinen@iki.fi \
    --cc=andreas@kemnade.info \
    --cc=bmasney@redhat.com \
    --cc=jmkrzyszt@gmail.com \
    --cc=khilman@baylibre.com \
    --cc=linus.walleij@linaro.org \
    --cc=linux-arm-kernel@lists.infradead.org \
    --cc=linux-clk@vger.kernel.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=linux-omap@vger.kernel.org \
    --cc=linux@armlinux.org.uk \
    --cc=liviu.dudau@arm.com \
    --cc=lpieralisi@kernel.org \
    --cc=mripard@kernel.org \
    --cc=paul@pwsan.com \
    --cc=rogerq@kernel.org \
    --cc=sboyd@kernel.org \
    --cc=tony@atomide.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).