Linux clock framework development
 help / color / mirror / Atom feed
From: Peng Fan <peng.fan@oss.nxp.com>
To: Brian Masney <bmasney@redhat.com>
Cc: Peng Fan <peng.fan@nxp.com>,
	Michael Turquette <mturquette@baylibre.com>,
	Stephen Boyd <sboyd@kernel.org>,
	Sudeep Holla <sudeep.holla@arm.com>,
	Cristian Marussi <cristian.marussi@arm.com>,
	Marco Felsch <m.felsch@pengutronix.de>,
	Dan Carpenter <dan.carpenter@linaro.org>,
	Geert Uytterhoeven <geert@linux-m68k.org>,
	linux-clk@vger.kernel.org, linux-kernel@vger.kernel.org,
	arm-scmi@vger.kernel.org, linux-arm-kernel@lists.infradead.org
Subject: Re: [PATCH v2 1/3] clk: Introduce clk_hw_set_spread_spectrum
Date: Sun, 7 Sep 2025 21:04:09 +0800	[thread overview]
Message-ID: <20250907130409.GA26925@nxa18884-linux.ap.freescale.net> (raw)
In-Reply-To: <aLdpKEwfqP448eMd@x1>

On Tue, Sep 02, 2025 at 06:01:12PM -0400, Brian Masney wrote:
>>   *
>> + * @set_spread_spectrum: Configure the modulation frequency, modulation percentage
>> + *		and method. This callback is optional for clocks that does not
>> + *		support spread spectrum feature or no need to enable this feature.
>> + *		Returns 0 on success, -EERROR otherwise.
>
>I think it would be worthwhile to call out in the kdocs that this helps
>to reduce EMI. How does this sound?
>
>@set_spread_spectrum: Optional callback used to configure the spread
>		spectrum modulation frequency, percentage, and method
>		to reduce EMI by spreading the clock frequency over a
>		wider range.
>		Returns 0 on success, -EERROR otherwise.

This is better. I will update in v3.

Thanks,
Peng

>
>Everything else looks good to me.
>
>Brian
>

  reply	other threads:[~2025-09-07 11:52 UTC|newest]

Thread overview: 12+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2025-09-01  3:51 [PATCH v2 0/3] clk: Support spread spectrum and use it in clk-scmi Peng Fan
2025-09-01  3:51 ` [PATCH v2 1/3] clk: Introduce clk_hw_set_spread_spectrum Peng Fan
2025-09-02 22:01   ` Brian Masney
2025-09-07 13:04     ` Peng Fan [this message]
2025-09-01  3:51 ` [PATCH v2 2/3] clk: conf: Support assigned-clock-sscs Peng Fan
2025-09-02 21:49   ` Brian Masney
2025-09-09  8:50     ` Peng Fan
2025-09-09  9:39       ` Brian Masney
2025-09-02 23:56   ` Brian Masney
2025-09-07 13:12     ` Peng Fan
2025-09-01  3:51 ` [PATCH v2 3/3] clk: scmi: Support Spread Spectrum for NXP i.MX95 Peng Fan
2025-09-07 13:19   ` Peng Fan

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20250907130409.GA26925@nxa18884-linux.ap.freescale.net \
    --to=peng.fan@oss.nxp.com \
    --cc=arm-scmi@vger.kernel.org \
    --cc=bmasney@redhat.com \
    --cc=cristian.marussi@arm.com \
    --cc=dan.carpenter@linaro.org \
    --cc=geert@linux-m68k.org \
    --cc=linux-arm-kernel@lists.infradead.org \
    --cc=linux-clk@vger.kernel.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=m.felsch@pengutronix.de \
    --cc=mturquette@baylibre.com \
    --cc=peng.fan@nxp.com \
    --cc=sboyd@kernel.org \
    --cc=sudeep.holla@arm.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox