From: Peng Fan <peng.fan@oss.nxp.com>
To: Brian Masney <bmasney@redhat.com>
Cc: Peng Fan <peng.fan@nxp.com>,
Michael Turquette <mturquette@baylibre.com>,
Stephen Boyd <sboyd@kernel.org>,
Sudeep Holla <sudeep.holla@arm.com>,
Cristian Marussi <cristian.marussi@arm.com>,
Marco Felsch <m.felsch@pengutronix.de>,
Rob Herring <robh@kernel.org>,
Krzysztof Kozlowski <krzk+dt@kernel.org>,
Conor Dooley <conor+dt@kernel.org>,
Dan Carpenter <dan.carpenter@linaro.org>,
Geert Uytterhoeven <geert@linux-m68k.org>,
linux-clk@vger.kernel.org, linux-kernel@vger.kernel.org,
arm-scmi@vger.kernel.org, linux-arm-kernel@lists.infradead.org,
devicetree@vger.kernel.org
Subject: Re: [PATCH v3 4/5] clk: Add KUnit tests for assigned-clock-sscs
Date: Mon, 15 Sep 2025 11:47:13 +0800 [thread overview]
Message-ID: <20250915034713.GA1331@nxa18884-linux.ap.freescale.net> (raw)
In-Reply-To: <aMQzP7DamsQWl8_L@redhat.com>
Hi Brian,
On Fri, Sep 12, 2025 at 10:50:39AM -0400, Brian Masney wrote:
>On Fri, Sep 12, 2025 at 11:35:53AM +0800, Peng Fan wrote:
>> ---
>
>There's no need to add a Co-developed-by for me. I just gave you a very
>rough starting point.
I honor your support, otherwise it would take me more time on write
the kunit test.
>
>> diff --git a/drivers/clk/kunit_clk_assigned_rates_zero_consumer.dtso b/drivers/clk/kunit_clk_assigned_rates_zero_consumer.dtso
>> index 1d964672e8553a90263af400367a2d947f755015..d62c7522c92461245d45f8ac0ebd26fa2850be98 100644
>> --- a/drivers/clk/kunit_clk_assigned_rates_zero_consumer.dtso
>> +++ b/drivers/clk/kunit_clk_assigned_rates_zero_consumer.dtso
>> @@ -12,5 +12,6 @@ kunit-clock-consumer {
>> compatible = "test,clk-consumer";
>> assigned-clocks = <&clk>;
>> assigned-clock-rates = <0>;
>> + assigned-clock-sscs = <0 0 0>;
>> };
>> };
>
>kunit_clk_assigned_rates_zero_consumer.dtso is modified, however
>kunit_clk_assigned_rates_zero.dtso was not. The underlying test doesn't
>check for this, so you can drop the change to this dtso file.
Right. I will drop this change.
Thanks,
Peng
next prev parent reply other threads:[~2025-09-15 2:35 UTC|newest]
Thread overview: 10+ messages / expand[flat|nested] mbox.gz Atom feed top
2025-09-12 3:35 [PATCH v3 0/5] clk: Support spread spectrum and use it in clk-scmi Peng Fan
2025-09-12 3:35 ` [PATCH v3 1/5] dt-bindings: clock: Add spread spectrum definition Peng Fan
2025-09-12 14:51 ` Brian Masney
2025-09-12 3:35 ` [PATCH v3 2/5] clk: Introduce clk_hw_set_spread_spectrum Peng Fan
2025-09-12 14:01 ` Brian Masney
2025-09-12 3:35 ` [PATCH v3 3/5] clk: conf: Support assigned-clock-sscs Peng Fan
2025-09-12 3:35 ` [PATCH v3 4/5] clk: Add KUnit tests for assigned-clock-sscs Peng Fan
2025-09-12 14:50 ` Brian Masney
2025-09-15 3:47 ` Peng Fan [this message]
2025-09-12 3:35 ` [PATCH v3 5/5] clk: scmi: Support Spread Spectrum for NXP i.MX95 Peng Fan
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20250915034713.GA1331@nxa18884-linux.ap.freescale.net \
--to=peng.fan@oss.nxp.com \
--cc=arm-scmi@vger.kernel.org \
--cc=bmasney@redhat.com \
--cc=conor+dt@kernel.org \
--cc=cristian.marussi@arm.com \
--cc=dan.carpenter@linaro.org \
--cc=devicetree@vger.kernel.org \
--cc=geert@linux-m68k.org \
--cc=krzk+dt@kernel.org \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=linux-clk@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=m.felsch@pengutronix.de \
--cc=mturquette@baylibre.com \
--cc=peng.fan@nxp.com \
--cc=robh@kernel.org \
--cc=sboyd@kernel.org \
--cc=sudeep.holla@arm.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox