Re: [PATCH RESEND] clk: at91: sam9x7: Use kmalloc_array() instead of kmalloc()

Shuah Khan
2025-10-07T21:06:10Z

On 9/24/25 08:55, Sidharth Seela wrote:
> Replace kmalloc with kmalloc array in clk/at91/sam9x7.c. Refactor to new
> API, for cases with dynamic size calculations inside kmalloc().
>

This following line doesn't belong in commit log.

Can you add details on how you tested this patch and also how
you found the problem to begin with.

> Resend is to correct previously sent patches mailing address.

>
> Signed-off-by: Sidharth Seela <sidharthseela@gmail.com>
> ---
> diff --git a/drivers/clk/at91/sam9x7.c b/drivers/clk/at91/sam9x7.c
> index ffab32b047a0..0c0a746a183d 100644
> --- a/drivers/clk/at91/sam9x7.c
> +++ b/drivers/clk/at91/sam9x7.c
> @@ -748,9 +748,9 @@ static void __init sam9x7_pmc_setup(struct device_node *np)
> if (!sam9x7_pmc)
> return;
>
> - clk_mux_buffer = kmalloc(sizeof(void *) *
> - (ARRAY_SIZE(sam9x7_gck)),
> - GFP_KERNEL);
> + clk_mux_buffer = kmalloc_array(ARRAY_SIZE(sam9x7_gck),
> + sizeof(void *),
> + GFP_KERNEL);
> if (!clk_mux_buffer)
> goto err_free;
>

thanks,
-- Shuah