From: Chuan Liu via B4 Relay <devnull+chuan.liu.amlogic.com@kernel.org>
To: Neil Armstrong <neil.armstrong@linaro.org>,
Jerome Brunet <jbrunet@baylibre.com>,
Michael Turquette <mturquette@baylibre.com>,
Stephen Boyd <sboyd@kernel.org>,
Kevin Hilman <khilman@baylibre.com>,
Martin Blumenstingl <martin.blumenstingl@googlemail.com>
Cc: linux-amlogic@lists.infradead.org, linux-clk@vger.kernel.org,
linux-arm-kernel@lists.infradead.org,
linux-kernel@vger.kernel.org, Chuan Liu <chuan.liu@amlogic.com>
Subject: [PATCH 1/3] clk: amlogic: Fix out-of-range PLL frequency setting
Date: Wed, 22 Oct 2025 14:58:51 +0800 [thread overview]
Message-ID: <20251022-optimize_pll_driver-v1-1-a275722fb6f4@amlogic.com> (raw)
In-Reply-To: <20251022-optimize_pll_driver-v1-0-a275722fb6f4@amlogic.com>
From: Chuan Liu <chuan.liu@amlogic.com>
meson_clk_get_pll_range_index incorrectly determines the maximum value
of 'm'.
Fixes: 8eed1db1adec6 ("clk: meson: pll: update driver for the g12a")
Signed-off-by: Chuan Liu <chuan.liu@amlogic.com>
---
drivers/clk/meson/clk-pll.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/drivers/clk/meson/clk-pll.c b/drivers/clk/meson/clk-pll.c
index 1ea6579a760f..b07e1eb19d12 100644
--- a/drivers/clk/meson/clk-pll.c
+++ b/drivers/clk/meson/clk-pll.c
@@ -191,7 +191,7 @@ static int meson_clk_get_pll_range_index(unsigned long rate,
*m = meson_clk_get_pll_range_m(rate, parent_rate, *n, pll);
/* the pre-divider gives a multiplier too big - stop */
- if (*m >= (1 << pll->m.width))
+ if (*m > pll->range->max)
return -EINVAL;
return 0;
--
2.42.0
next prev parent reply other threads:[~2025-10-22 6:59 UTC|newest]
Thread overview: 9+ messages / expand[flat|nested] mbox.gz Atom feed top
2025-10-22 6:58 [PATCH 0/3] clk: amlogic: optimize the PLL driver Chuan Liu via B4 Relay
2025-10-22 6:58 ` Chuan Liu via B4 Relay [this message]
2025-10-22 11:57 ` [PATCH 1/3] clk: amlogic: Fix out-of-range PLL frequency setting Jerome Brunet
2025-10-22 13:50 ` Chuan Liu
2025-10-22 6:58 ` [PATCH 2/3] clk: amlogic: Optimize PLL enable timing Chuan Liu via B4 Relay
2025-10-22 12:01 ` Jerome Brunet
2025-10-22 14:07 ` Chuan Liu
2025-10-30 8:45 ` Jerome Brunet
2025-10-22 6:58 ` [PATCH 3/3] clk: amlogic: Correct l_detect bit control Chuan Liu via B4 Relay
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20251022-optimize_pll_driver-v1-1-a275722fb6f4@amlogic.com \
--to=devnull+chuan.liu.amlogic.com@kernel.org \
--cc=chuan.liu@amlogic.com \
--cc=jbrunet@baylibre.com \
--cc=khilman@baylibre.com \
--cc=linux-amlogic@lists.infradead.org \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=linux-clk@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=martin.blumenstingl@googlemail.com \
--cc=mturquette@baylibre.com \
--cc=neil.armstrong@linaro.org \
--cc=sboyd@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox