From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mail-wm1-f44.google.com (mail-wm1-f44.google.com [209.85.128.44]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 033761FDA92 for ; Sun, 2 Nov 2025 20:27:30 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=209.85.128.44 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1762115252; cv=none; b=oYYdfIPGdCKDU/fHLTYdV6Xco9QR9FINzliLWi2gqKzXmktdOxYr0j7/tJ11THgVYHk+1tKcUOivQlpgvXmsLxyPNhHKhBPi95iZ3ROFUm28gBb4x9GMVL9Qg4DeOOsAujuXIZ85jfExyZF7paX055FcqQf651Txs+8kgfAr5M0= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1762115252; c=relaxed/simple; bh=rW93Hlr4vcum+GKJgXc1ajFfnfWqcxUHYUOR3Zmf44g=; h=From:Date:Subject:MIME-Version:Content-Type:Message-Id:References: In-Reply-To:To:Cc; b=s74FEi7U27CJRbryRLTFy4rv1QCmVkLfrf4lANmJUbOJQwUnwMiSd55fFdSNRb4DWXWnohBml9FzuxtM8uswuXFwDzBb4eR0TowFXw5Kge0nEM+C7Mq09trb8/CAOh25zjBpYw1R7weHCNKgXbOVQgDMReMkJk22xQAZYMPF+CI= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=linaro.org; spf=pass smtp.mailfrom=linaro.org; dkim=pass (2048-bit key) header.d=linaro.org header.i=@linaro.org header.b=spPclBD/; arc=none smtp.client-ip=209.85.128.44 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=linaro.org Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=linaro.org Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=linaro.org header.i=@linaro.org header.b="spPclBD/" Received: by mail-wm1-f44.google.com with SMTP id 5b1f17b1804b1-4710a1f9e4cso31697725e9.0 for ; Sun, 02 Nov 2025 12:27:30 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; t=1762115249; x=1762720049; darn=vger.kernel.org; h=cc:to:in-reply-to:references:message-id:content-transfer-encoding :mime-version:subject:date:from:from:to:cc:subject:date:message-id :reply-to; bh=VqwzmV8ucm9ZpizFb4InEfSGE/OBpMLcQ1DSFma1Oj8=; b=spPclBD/+xF/1VDujn3fFq7tYrhrEkpEAxmvtImr4ddLUF9DaiV0DiJ3cMs0jsANoa jp8m6v9yoLRJpmVZOsW7tqgIl9ohdP9G2aPy3HClM2jQ9qhLCCZUrgGCa45cFD5K/+jA jST7JeGyw+NNkpqgAWLVnFC3DEySjKh++WCtOgmxBQVRm4Go1mkVZTf5BRd4iOulyK8m Fnoq51tykTYEFkAGx390iGC5Aa2+qjEGeCkAt8KSFw2HzeMRX2xxDubo5h1XK76+VvQr vehHxG0slZjXO0GSdkjwoVsdXRUo5V96VU5xQdjb148GQyPQafU0xsZfVxpZFV1aLIHh Zh0w== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1762115249; x=1762720049; h=cc:to:in-reply-to:references:message-id:content-transfer-encoding :mime-version:subject:date:from:x-gm-message-state:from:to:cc :subject:date:message-id:reply-to; bh=VqwzmV8ucm9ZpizFb4InEfSGE/OBpMLcQ1DSFma1Oj8=; b=LOb4WHQx0kKBWbkFzOslqd90ywIn7ku+Ezq9Py00NvOUakTHt9wzmDlsfogcnfuJZY pOXDWDFSBhvsP/PdsAJA150lIDZF3li8Dto2O2iwWC/LPIOAsf5MbugkA6TEj4CQv0Dz UN1+3H8UGVj6lbfqpxOp2ho/DUD95oBVLCJznJ5+Qh3z8AkUP4aqu5F9P7t7RinVxJCz 4nlRKaIGtDSoPyV9BHR2pBmQrzDOSnK6lc0a6TnVGxMok9l9tu2+QMfoJ8OCcGUrknH4 jPN4U/+4XW8TsdLojK6A/Yp5+Lkvl+clN9EodohLrfAdCSR7TajQ+LvTWAG12sLOHMJf Mkmg== X-Forwarded-Encrypted: i=1; AJvYcCXQ0zlV/65P3nafGVW6ta+VYVUR2d4TfUgGj2Tnk5jvSTzbupwtPCOwW9oJXqpIqqDkJSEVPV2ZkwY=@vger.kernel.org X-Gm-Message-State: AOJu0YxvG61lds7kg7/+RK23PckDk3CXphcofqNB+lqOzPlvfLEcio1r 65HB+XUROzf9civjxcU4Q95e0wufegLxyDz3El+EDQkW5Fs0i5mHgsKKY5u3U2sK+PE= X-Gm-Gg: ASbGncuUOlIKyQKNcTSQ47jhHt4e8HVo55ZJJLlhoG92+A2sdA81rX6F2gAIqU5CE1T 1htDyUC3ptIchMoyuhFlZdEMgE2Y9kL9MKrdTVQxnl88BTAf4mxIdOte6WMcVLLBVa82YsD1HlF Oa6VukAz/+QDz0TpppbzWjatuKMN80WsJv4IDV0NZy/ShFxCPA762GRLhPUbFhLZWtET86G8sti nHVmpC1MZUj+go795Rn/DRjL45NeSl8paRfrIrs3d5alXwEQ1RxmswFlAZ0ZIenvJBmitL0toQQ 21RkkNItuGuLyUIUhRvHeN26475XW28kyi/o1t89jLcXMASBghS/hVMfhadir7s1ZIEZpGj41wh PpEvCcI8MKy76mHZ315nWJwZW6XERUuBAKWX8cmF2fNip413UDGbFBO7tGLijVueCfJzHotUpCY 570NkSamzqHQT6rPCMMMgwEI1C0HUkKLb4uoQ7JYxxzA== X-Google-Smtp-Source: AGHT+IHO6Kj16XZq6wFeuaf1RbffW2vio8belueyNJjXBAP6hwWK/ytmja/cRAdCXN2PlNhsCr1t1g== X-Received: by 2002:a05:600c:190e:b0:471:168f:717a with SMTP id 5b1f17b1804b1-477308599b4mr87271515e9.16.1762115249274; Sun, 02 Nov 2025 12:27:29 -0800 (PST) Received: from gpeter-l.roam.corp.google.com ([145.224.65.248]) by smtp.gmail.com with ESMTPSA id 5b1f17b1804b1-4773c374f84sm114664165e9.0.2025.11.02.12.27.28 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Sun, 02 Nov 2025 12:27:28 -0800 (PST) From: Peter Griffin Date: Sun, 02 Nov 2025 20:27:14 +0000 Subject: [PATCH v3 1/4] dt-bindings: clock: google,gs101-clock: add samsung,sysreg property as required Precedence: bulk X-Mailing-List: linux-clk@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: 7bit Message-Id: <20251102-automatic-clocks-v3-1-ff10eafe61c8@linaro.org> References: <20251102-automatic-clocks-v3-0-ff10eafe61c8@linaro.org> In-Reply-To: <20251102-automatic-clocks-v3-0-ff10eafe61c8@linaro.org> To: Rob Herring , Krzysztof Kozlowski , Conor Dooley , Alim Akhtar , =?utf-8?q?Andr=C3=A9_Draszik?= , Tudor Ambarus , Michael Turquette , Stephen Boyd , Sam Protsenko , Sylwester Nawrocki , Chanwoo Choi Cc: Will McVicker , Krzysztof Kozlowski , devicetree@vger.kernel.org, linux-arm-kernel@lists.infradead.org, linux-samsung-soc@vger.kernel.org, linux-kernel@vger.kernel.org, linux-clk@vger.kernel.org, kernel-team@android.com, Peter Griffin , Krzysztof Kozlowski X-Mailer: b4 0.14.2 X-Developer-Signature: v=1; a=openpgp-sha256; l=2325; i=peter.griffin@linaro.org; h=from:subject:message-id; bh=rW93Hlr4vcum+GKJgXc1ajFfnfWqcxUHYUOR3Zmf44g=; b=owEBbQKS/ZANAwAKAc7ouNYCNHK6AcsmYgBpB76svQKBqYy4GDQ/oR5w5NFCQd80R2RbT/sW6 cO1sayfIrKJAjMEAAEKAB0WIQQO/I5vVXh1DVa1SfzO6LjWAjRyugUCaQe+rAAKCRDO6LjWAjRy un7MD/9tdkOyjZlhnamX0fDBgvsMJET6LH8N8JPdTmn7dkF7GI4cvOuhDF0DKY24mkl1k1t+Ihs ynh39V1v15ZLyrpKTDjD3mTCEWxJjHRdF2WcHeXr0w7Oi+yuqjZaVcnMFa/hWoFP0kstG4NpApi jliMamJwva3OATI1hqBH08xqxqlyTSztEr79ZOhVR+7ugOcVREUNP+D16BSObwDHjhwJSN3QQU5 MacwZsMYrD6R6Ym/qMH3MDnjj4TqcuLCzNwaAl0D+/UsgZ+wUIXBRLB/0OkTMOrwhuySjw60yPM vzJF4IXTtPUygBa+75pAPGUhnHtMrCD/MQkXTPlahGD6knkYwPnALiif3neHHcpNdEytS9cBGx1 //Q4tvT53ZaPER/CbhFZMvkwWv+EiMvgnn4uyS/zCD/Lgt8vaHmCpBvxUpb5DkjNKUger87dwoa LjICe7n3KKwbVNrd20GQdk5MVmUBucaQ34jDCJMJOCtU5DYUGPccAvlvDhVONyHhe1ocTkSTz8g 9/7o+kOtywqhAdi11O31sc9s2SO9m2oA0wUgEfWgY9Jp6F1VkoAz4BrT9yRskKJIjAmrRuRe24j 2Havbr/MOjzlFvNvgqXHx97qAyvrYsMt9p3Ck29WQ2muZ5JZb1soWDVffEKo2CQmJmb+Lx7namy /7yR4IgeWDLaRog== X-Developer-Key: i=peter.griffin@linaro.org; a=openpgp; fpr=0EFC8E6F5578750D56B549FCCEE8B8D6023472BA Each CMU (with the exception of cmu_top) has a corresponding sysreg bank that contains the BUSCOMPONENT_DRCG_EN and MEMCLK registers. If present these registers need to be initialised in the clock driver. Update the bindings documentation so that all CMUs (with the exception of gs101-cmu-top) have samsung,sysreg as a required property. Additionally update the DT example to included the correct CMU size as registers in that region are used for auto clock mode. Signed-off-by: Peter Griffin --- Changes in v2: - Update commit description as to why the sysreg is required (Krzysztof) - Update commit description regarding updated example (Andre) --- .../bindings/clock/google,gs101-clock.yaml | 23 +++++++++++++++++++++- 1 file changed, 22 insertions(+), 1 deletion(-) diff --git a/Documentation/devicetree/bindings/clock/google,gs101-clock.yaml b/Documentation/devicetree/bindings/clock/google,gs101-clock.yaml index 31e106ef913dead9a038b3b6d8b43b950587f6aa..5ce5ba523110af3a2a7740b8ba28e2271c76bddb 100644 --- a/Documentation/devicetree/bindings/clock/google,gs101-clock.yaml +++ b/Documentation/devicetree/bindings/clock/google,gs101-clock.yaml @@ -52,6 +52,11 @@ properties: reg: maxItems: 1 + samsung,sysreg: + $ref: /schemas/types.yaml#/definitions/phandle + description: + Phandle to system registers interface. + required: - compatible - "#clock-cells" @@ -166,6 +171,22 @@ allOf: - const: bus - const: ip + - if: + properties: + compatible: + contains: + enum: + - google,gs101-cmu-apm + - google,gs101-cmu-misc + - google,gs101-hsi0 + - google,gs101-cmu-hsi2 + - google,gs101-cmu-peric0 + - google,gs101-cmu-peric1 + + then: + required: + - samsung,sysreg + additionalProperties: false examples: @@ -175,7 +196,7 @@ examples: cmu_top: clock-controller@1e080000 { compatible = "google,gs101-cmu-top"; - reg = <0x1e080000 0x8000>; + reg = <0x1e080000 0x10000>; #clock-cells = <1>; clocks = <&ext_24_5m>; clock-names = "oscclk"; -- 2.51.1.930.gacf6e81ea2-goog