Re: [PATCH 2/3] arm64: dts: rockchip: use SCMI clock id for cpu clock on rk356x

Heiko Stuebner
2025-11-05T23:43:36Z

Am Mittwoch, 5. November 2025, 14:16:42 Mitteleuropäische Normalzeit schrieb Diederik de Haas:
> Hi Heiko,
>
> On Tue Nov 4, 2025 at 12:49 AM CET, Heiko Stuebner wrote:
> > Instead of hard-coding 0, use the more descriptive ID from the binding
> > to reference the SCMI clock for the cpu on rk356x.
>
> Any particular reason you only did it for the cpu, but not the gpu?

Didn't think of if at the time :-) .

Will prepare another one for the GPU.

Heiko

>
> > Signed-off-by: Heiko Stuebner <heiko@sntech.de>
> > ---
> > arch/arm64/boot/dts/rockchip/rk356x-base.dtsi | 2 +-
> > 1 file changed, 1 insertion(+), 1 deletion(-)
> >
> > diff --git a/arch/arm64/boot/dts/rockchip/rk356x-base.dtsi b/arch/arm64/boot/dts/rockchip/rk356x-base.dtsi
> > index a3361527d4fe..d0c76401b45e 100644
> > --- a/arch/arm64/boot/dts/rockchip/rk356x-base.dtsi
> > +++ b/arch/arm64/boot/dts/rockchip/rk356x-base.dtsi
> > @@ -53,7 +53,7 @@ cpu0: cpu@0 {
> > device_type = "cpu";
> > compatible = "arm,cortex-a55";
> > reg = <0x0 0x0>;
> > - clocks = <&scmi_clk 0>;
> > + clocks = <&scmi_clk SCMI_CLK_CPU>;
>
> Regardless of the above comment, feel free to add
>
> Reviewed-by: Diederik de Haas <diederik@cknow-tech.com>
>
> Cheers,
> Diederik
>
> > #cooling-cells = <2>;
> > enable-method = "psci";
> > i-cache-size = <0x8000>;
>
>