Linux clock framework development
 help / color / mirror / Atom feed
From: Krzysztof Kozlowski <krzk@kernel.org>
To: Konrad Dybcio <konradybcio@kernel.org>
Cc: Rob Herring <robh@kernel.org>,
	 Krzysztof Kozlowski <krzk+dt@kernel.org>,
	Conor Dooley <conor+dt@kernel.org>,
	 Bjorn Andersson <andersson@kernel.org>,
	Johan Hovold <johan+linaro@kernel.org>,
	 Mathieu Poirier <mathieu.poirier@linaro.org>,
	Manivannan Sadhasivam <mani@kernel.org>,
	 Vinod Koul <vkoul@kernel.org>,
	Michael Turquette <mturquette@baylibre.com>,
	 Stephen Boyd <sboyd@kernel.org>,
	Taniya Das <quic_tdas@quicinc.com>,
	 Imran Shaik <quic_imrashai@quicinc.com>,
	Vladimir Zapolskiy <vladimir.zapolskiy@linaro.org>,
	 Jagadeesh Kona <quic_jkona@quicinc.com>,
	Ulf Hansson <ulf.hansson@linaro.org>,
	 Bryan O'Donoghue <bryan.odonoghue@linaro.org>,
	linux-arm-msm@vger.kernel.org, devicetree@vger.kernel.org,
	 linux-kernel@vger.kernel.org, linux-remoteproc@vger.kernel.org,
	linux-clk@vger.kernel.org,  linux-pm@vger.kernel.org,
	Konrad Dybcio <konrad.dybcio@oss.qualcomm.com>
Subject: Re: [PATCH 2/5] dt-bindings: remoteproc: qcom,sc8280xp-pas: Fix CDSP power desc
Date: Wed, 5 Nov 2025 10:14:21 +0100	[thread overview]
Message-ID: <20251105-dramatic-denim-kangaroo-cef9ed@kuoka> (raw)
In-Reply-To: <20251104-topic-8280_mxc-v1-2-df545af0ef94@oss.qualcomm.com>

On Tue, Nov 04, 2025 at 08:31:07PM +0100, Konrad Dybcio wrote:
> From: Konrad Dybcio <konrad.dybcio@oss.qualcomm.com>
> 
> The power requirements for the CDSP instances on SC8280XP aren't fully
> described, with only one of the three present. Fix that.
> 
> Fixes: ee651cd1e944 ("dt-bindings: remoteproc: qcom: pas: Add sc8280xp adsp and nsp pair")
> Signed-off-by: Konrad Dybcio <konrad.dybcio@oss.qualcomm.com>
> ---
>  Documentation/devicetree/bindings/remoteproc/qcom,sc8280xp-pas.yaml | 4 ++++
>  1 file changed, 4 insertions(+)
> 
> diff --git a/Documentation/devicetree/bindings/remoteproc/qcom,sc8280xp-pas.yaml b/Documentation/devicetree/bindings/remoteproc/qcom,sc8280xp-pas.yaml
> index 96d53baf6e00..5dbda3a55047 100644
> --- a/Documentation/devicetree/bindings/remoteproc/qcom,sc8280xp-pas.yaml
> +++ b/Documentation/devicetree/bindings/remoteproc/qcom,sc8280xp-pas.yaml
> @@ -91,9 +91,13 @@ allOf:
>          power-domains:
>            items:
>              - description: NSP power domain
> +            - description: CX power domain
> +            - description: MXC power domain
>          power-domain-names:
>            items:
>              - const: nsp
> +            - const: cx
> +            - const: mxc

Heh, so if this was described since beginning entire binding would fit
100% into qcom,sm8550-pas.yaml, instead having this now in different
file because of different order. Not great. :(

Reviewed-by: Krzysztof Kozlowski <krzysztof.kozlowski@linaro.org>

Best regards,
Krzysztof


  reply	other threads:[~2025-11-05  9:14 UTC|newest]

Thread overview: 18+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2025-11-04 19:31 [PATCH 0/5] Define VDD_MXC for SC8280XP Konrad Dybcio
2025-11-04 19:31 ` [PATCH 1/5] dt-bindings: power: qcom,rpmpd: Add SC8280XP_MXC_AO Konrad Dybcio
2025-11-04 19:31 ` [PATCH 2/5] dt-bindings: remoteproc: qcom,sc8280xp-pas: Fix CDSP power desc Konrad Dybcio
2025-11-05  9:14   ` Krzysztof Kozlowski [this message]
2025-11-05  9:15     ` Konrad Dybcio
2025-11-04 19:31 ` [PATCH 3/5] dt-bindings: clock: qcom: Allow MXC on SC8280XP CAMCC Konrad Dybcio
2025-11-04 20:28   ` Rob Herring (Arm)
2025-11-04 19:31 ` [PATCH 4/5] pmdomain: qcom: rpmhpd: Add MXC to SC8280XP Konrad Dybcio
2025-11-04 19:31 ` [PATCH 5/5] arm64: dts: qcom: sc8280xp: Add missing VDD_MXC links Konrad Dybcio
2025-11-05  1:00   ` Dmitry Baryshkov
2025-11-05  9:21   ` Imran Shaik
2025-11-05 11:02     ` Konrad Dybcio
2025-11-06  9:14       ` Imran Shaik
2025-11-26 20:10 ` (subset) [PATCH 0/5] Define VDD_MXC for SC8280XP Bjorn Andersson
2025-12-01 20:14   ` Rob Herring
2025-12-02  9:19     ` Ulf Hansson
2025-12-02 13:27       ` Konrad Dybcio
2025-12-02 17:27         ` Bjorn Andersson

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20251105-dramatic-denim-kangaroo-cef9ed@kuoka \
    --to=krzk@kernel.org \
    --cc=andersson@kernel.org \
    --cc=bryan.odonoghue@linaro.org \
    --cc=conor+dt@kernel.org \
    --cc=devicetree@vger.kernel.org \
    --cc=johan+linaro@kernel.org \
    --cc=konrad.dybcio@oss.qualcomm.com \
    --cc=konradybcio@kernel.org \
    --cc=krzk+dt@kernel.org \
    --cc=linux-arm-msm@vger.kernel.org \
    --cc=linux-clk@vger.kernel.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=linux-pm@vger.kernel.org \
    --cc=linux-remoteproc@vger.kernel.org \
    --cc=mani@kernel.org \
    --cc=mathieu.poirier@linaro.org \
    --cc=mturquette@baylibre.com \
    --cc=quic_imrashai@quicinc.com \
    --cc=quic_jkona@quicinc.com \
    --cc=quic_tdas@quicinc.com \
    --cc=robh@kernel.org \
    --cc=sboyd@kernel.org \
    --cc=ulf.hansson@linaro.org \
    --cc=vkoul@kernel.org \
    --cc=vladimir.zapolskiy@linaro.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox