Re: [PATCH v3 02/21] dt-bindings: power: mediatek: Add MT8189 power domain definitions

Conor Dooley
2025-11-07T16:58:45Z

[-- Attachment #1: Type: text/plain, Size: 1477 bytes --]

On Fri, Nov 07, 2025 at 08:26:34AM +0100, Krzysztof Kozlowski wrote:
> On Thu, Nov 06, 2025 at 05:17:39PM +0000, Conor Dooley wrote:
> > On Thu, Nov 06, 2025 at 07:34:37AM -0600, Rob Herring (Arm) wrote:
> > >
> > > On Thu, 06 Nov 2025 20:41:47 +0800, irving.ch.lin wrote:
> > > > From: Irving-CH Lin <irving-ch.lin@mediatek.com>
> > > >
> > > > Add device tree bindings for the power domains of MediaTek MT8189 SoC.
> > > >
> > > > Signed-off-by: Irving-CH Lin <irving-ch.lin@mediatek.com>
> > > > ---
> > > > .../power/mediatek,power-controller.yaml | 1 +
> > > > .../dt-bindings/power/mediatek,mt8189-power.h | 38 +++++++++++++++++++
> > > > 2 files changed, 39 insertions(+)
> > > > create mode 100644 include/dt-bindings/power/mediatek,mt8189-power.h
> > > >
> > >
> > > My bot found errors running 'make dt_binding_check' on your patch:
> > >
> > > yamllint warnings/errors:
> > > ./Documentation/devicetree/bindings/clock/mediatek,mt8189-clock.yaml:25:9: [warning] wrong indentation: expected 10 but found 8 (indentation)
> >
> > pw-bot: changes-requested
>
> I think this was bot's false positive - that's a different file, not
> changed here. The patch seems fine.
>
> Acked-by: Krzysztof Kozlowski <krzysztof.kozlowski@linaro.org>

Oh dear, my bad! Good thing I sent the mail, so you noticed, rather than
just setting the status in patchwork. I saw "mediatek,mt8189" and read
nothing else in the error, I suppose.

[-- Attachment #2: signature.asc --]
[-- Type: application/pgp-signature, Size: 228 bytes --]