From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from smtp.gentoo.org (woodpecker.gentoo.org [140.211.166.183]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 403611DF75B; Mon, 15 Dec 2025 22:12:14 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=140.211.166.183 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1765836735; cv=none; b=fmN3YkOvkW93MTKAHAfUUfQkkTjchfnUBVLosGFk3D4pTrfT7O2Jt2Z/frcfmaGZ6jAxhqdb1SAczfofQa4IWW4Tbd/eizyZVj5TFu+I9acTFDWmL63P5Hlv0eM5BVkZ/jcagOS27Kq89TM1NQqGvky1pArld2gkfbarwaRGutU= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1765836735; c=relaxed/simple; bh=NLYiOUYiG/k19vpOW/XSJrtj4vVB8JvwMFogPYgbGjE=; h=Date:From:To:Cc:Subject:Message-ID:References:MIME-Version: Content-Type:Content-Disposition:In-Reply-To; b=TZAKvUcSL9VC+BYEzcQQk0ZIhh5tRMcGmmLichcF62nqEy5Syn96AnrExXXfCIs52I3wYUcQkcrTI/dnR0AEDo9F1XgCEJoOtRHgk89Ocfi/ZTU1b2t1dfnPZrgA0OoEBDJJ1c9o8bGEBTF4O+pp1SU2LXKqJCAJ346cg8W7a6Q= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=gentoo.org; spf=pass smtp.mailfrom=gentoo.org; arc=none smtp.client-ip=140.211.166.183 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=gentoo.org Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=gentoo.org Received: from localhost (unknown [116.232.18.222]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange secp256r1 server-signature RSA-PSS (4096 bits) server-digest SHA256) (No client certificate requested) (Authenticated sender: dlan) by smtp.gentoo.org (Postfix) with ESMTPSA id 2CE41340DEB; Mon, 15 Dec 2025 22:12:12 +0000 (UTC) Date: Tue, 16 Dec 2025 06:12:02 +0800 From: Yixun Lan To: Inochi Amaoto Cc: Michael Turquette , Stephen Boyd , Haylen Chu , Brian Masney , Troy Mitchell , Alex Elder , Akhilesh Patil , linux-clk@vger.kernel.org, linux-riscv@lists.infradead.org, spacemit@lists.linux.dev, linux-kernel@vger.kernel.org, Longbin Li Subject: Re: [PATCH] clk: spacemit: Fix module build for spacemit common ccu driver Message-ID: <20251215221202-GYA1903981@gentoo.org> References: <20251214232938.668293-1-inochiama@gmail.com> Precedence: bulk X-Mailing-List: linux-clk@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20251214232938.668293-1-inochiama@gmail.com> Hi Inochi, On 07:29 Mon 15 Dec , Inochi Amaoto wrote: > For build spacemit common clock driver as a module, the build > process require MODULE_LICENSE()/MODULE_DESCRIPTION() globally > and EXPORT_SYMBOL() for every exposed symbol. Otherwise, the > build will fail. > > Add these missing hints, so the driver can be built as a module. > > Fixes: 1b72c59db0ad ("clk: spacemit: Add clock support for SpacemiT K1 SoC") > Signed-off-by: Inochi Amaoto looks good, thanks Reviewed-by: Yixun Lan -- Yixun Lan (dlan)