From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mx.nabladev.com (mx.nabladev.com [178.251.229.89]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 764C92C08D5; Mon, 26 Jan 2026 08:05:26 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=178.251.229.89 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1769414729; cv=none; b=OPPg18RQrtFgwEIGnFRVZjxMjlgPJqYYVpXLKFm9o80rgu4gBM4yudlh9C9DpuL4Oxp3F6xx0J9yqP6d9sfN9TtRNEc3m0ng7lHuNblZxM5aznJso9u1MEapu5JfXlSK6IAquANodgk7iZj5UBWcBmjx4+1ROXpHYWVPyhrRFtQ= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1769414729; c=relaxed/simple; bh=FVhP5CNzLOC60lrSsODAq2BDN3EAcRNfRWBWSSn7AIA=; h=Date:From:To:Cc:Subject:Message-ID:In-Reply-To:References: MIME-Version:Content-Type; b=g5glRlWH4XFWJu4yy0W1VcFA5b/LJMqQTo/0nxmPJPEK8a89TMd/ITG+HAnLVk3dAwb3PDzS8lwRd4JMapqOf+AQEsjXdVVB60uRHj1L/E3nnH/u9DRLUN/5D5L4T+G/saRuX9DkEiUiroMn1tVOe7+QiqbwvICUklYi1EHIgEc= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=pass (p=reject dis=none) header.from=nabladev.com; spf=pass smtp.mailfrom=nabladev.com; dkim=pass (2048-bit key) header.d=nabladev.com header.i=@nabladev.com header.b=CnpvMD8I; arc=none smtp.client-ip=178.251.229.89 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=reject dis=none) header.from=nabladev.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=nabladev.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=nabladev.com header.i=@nabladev.com header.b="CnpvMD8I" Received: from [127.0.0.1] (localhost [127.0.0.1]) by localhost (Mailerdaemon) with ESMTPSA id A0C8110F2A1; Mon, 26 Jan 2026 09:05:14 +0100 (CET) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=nabladev.com; s=dkim; t=1769414718; h=from:subject:date:message-id:to:cc:mime-version:content-type: content-transfer-encoding:in-reply-to:references; bh=oXaEAcCkiPb4MDjwGnEFROsVx88PiTYnyWcEst6Ub6s=; b=CnpvMD8IsO4oG+/L62lHKeeaE6t+PF3Ng8TrBowOn7q7NytPlfUp2u9rfTQLTY6oP/4BPM bNSqbQuUwSC8A11hh2MKOdLycoMN9W+DBgP4oqChXcS6Ey81nxBqKtRpiyfhjjtslijZ5/ atgsrtx8/3XGlVm7NrkqZn11KiwaZrPhl52Pl+ntlEgRqt+/blJeuOzF5yq6YmFjQZggql azFLEoALWGjEXpXGOhL30AU3zmfifgN2dCbnDGl7jxZcRBYw9QSQnSBS+zOyzPO3XIVGme kqgV17a0EaQzOhTZOF0xywo3V2Pt7iQpnnTU0i0YTWou1xe2sP5BYX7T2uLsiA== Date: Mon, 26 Jan 2026 09:05:12 +0100 From: =?UTF-8?B?xYF1a2Fzeg==?= Majewski To: Peng Fan Cc: Michael Turquette , Abel Vesa , Stephen Boyd , Shawn Guo , Sascha Hauer , Pengutronix Kernel Team , Fabio Estevam , "linux-clk@vger.kernel.org" , "imx@lists.linux.dev" , "linux-kernel@vger.kernel.org" , "linux-arm-kernel@lists.infradead.org" Subject: Re: [PATCH] clk: vf610: Add support for the Ethernet switch clocks Message-ID: <20260126090512.49b48ed0@wsk> In-Reply-To: References: <20260122130649.4150338-1-lukma@nabladev.com> Organization: Nabla X-Mailer: Claws Mail 3.19.0 (GTK+ 2.24.33; x86_64-pc-linux-gnu) Precedence: bulk X-Mailing-List: linux-clk@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Type: text/plain; charset=US-ASCII Content-Transfer-Encoding: 7bit X-Last-TLS-Session-Version: TLSv1.3 Hi Peng, > Hi Lukasz, > > > Subject: [PATCH] clk: vf610: Add support for the Ethernet switch > > clocks > > > > The vf610 device has built in the MoreThanIP L2 switch. For proper > > operation it is required to enable ESW and MAC table lookup clocks. > > > > The MAC table spans from 0x400E_C000 for 0x4000 and it is necessary > > to provide clocks for each AIPS1-"slot", which size is 0x1000 (hence > > four separate entries). > > > > Those can be enabled via clock gating CCM_CCGR10 register > > (0x4006_B068). > > > > Signed-off-by: Lukasz Majewski > > --- > > drivers/clk/imx/clk-vf610.c | 5 +++++ > > 1 file changed, 5 insertions(+) > > > > diff --git a/drivers/clk/imx/clk-vf610.c > > b/drivers/clk/imx/clk-vf610.c index 9e11f1c7c397..88c9b656f244 > > 100644 --- a/drivers/clk/imx/clk-vf610.c > > +++ b/drivers/clk/imx/clk-vf610.c > > @@ -309,6 +309,11 @@ static void __init vf610_clocks_init(struct > > device_node *ccm_node) > > clk[VF610_CLK_ENET_TS] = imx_clk_gate("enet_ts", > > "enet_ts_sel", CCM_CSCDR1, 23); > > clk[VF610_CLK_ENET0] = imx_clk_gate2("enet0", "ipg_bus", > > CCM_CCGR9, CCM_CCGRx_CGn(0)); > > clk[VF610_CLK_ENET1] = imx_clk_gate2("enet1", "ipg_bus", > > CCM_CCGR9, CCM_CCGRx_CGn(1)); > > + clk[VF610_CLK_ESW] = imx_clk_gate2("esw", "ipg_bus", > > CCM_CCGR10, CCM_CCGRx_CGn(8)); > > + clk[VF610_CLK_ESW_MAC_TAB0] = imx_clk_gate2("esw_tab0", > > "ipg_bus", CCM_CCGR10, CCM_CCGRx_CGn(12)); > > + clk[VF610_CLK_ESW_MAC_TAB1] = imx_clk_gate2("esw_tab1", > > "ipg_bus", CCM_CCGR10, CCM_CCGRx_CGn(13)); > > + clk[VF610_CLK_ESW_MAC_TAB2] = imx_clk_gate2("esw_tab2", > > "ipg_bus", CCM_CCGR10, CCM_CCGRx_CGn(14)); > > + clk[VF610_CLK_ESW_MAC_TAB3] = imx_clk_gate2("esw_tab3", > > + "ipg_bus", CCM_CCGR10, CCM_CCGRx_CGn(15)); > > Seems you post dt-binding in a separate patch. It is better to > put in one patchset. Ok. No problem - I will add them together :) > > Regards > Peng > > > > > clk[VF610_CLK_PIT] = imx_clk_gate2("pit", "ipg_bus", > > CCM_CCGR1, CCM_CCGRx_CGn(7)); > > > > -- > > 2.39.5 > -- Best regards, Lukasz Majewski -- Nabla Software Engineering GmbH HRB 40522 Augsburg Phone: +49 821 45592596 E-Mail: office@nabladev.com Managing Director : Stefano Babic