From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from smtpout-02.galae.net (smtpout-02.galae.net [185.246.84.56]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 2976D3E95B7; Wed, 25 Feb 2026 16:55:17 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=185.246.84.56 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1772038521; cv=none; b=NGGbXvu5xcW6z4hF6jxt7KcpU1AlK5nTlp2FeHvk/MCygDI25+nqqo1XK7rsX8ucwHi2DtPMJp+ld/8vxMA7Bng4KwJJGa87Lca14j7b/QTxZwrDyDBLYKLW4lme6SNSFdfnIHP7aZZ+nJoKdldOyNRoftIhajhyq2MxWzTqxjc= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1772038521; c=relaxed/simple; bh=of/YEzm7FgG2yPHCXlT6dFmVJxrfoekd4yiJn8jylBQ=; h=From:Date:Subject:MIME-Version:Content-Type:Message-Id:References: In-Reply-To:To:Cc; b=CKcxhxunuFUmHg5r/+x+zTnAdcXmMzITY5kNp5y+z3dL9FXYjmEtPFDDaaMHX6ru+DIrs0cc0YD4i3jauNgyRSm4CRAn+ZHHhygtHRyJVlFRbXz89I0l6evt56Ta9a/gQPoD+DL28bObSR4azTAZ46jLZepDP6uWkXWilySVYAM= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=pass (p=reject dis=none) header.from=bootlin.com; spf=pass smtp.mailfrom=bootlin.com; dkim=pass (2048-bit key) header.d=bootlin.com header.i=@bootlin.com header.b=YFKbFtpe; arc=none smtp.client-ip=185.246.84.56 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=reject dis=none) header.from=bootlin.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=bootlin.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=bootlin.com header.i=@bootlin.com header.b="YFKbFtpe" Received: from smtpout-01.galae.net (smtpout-01.galae.net [212.83.139.233]) by smtpout-02.galae.net (Postfix) with ESMTPS id A08721A1327; Wed, 25 Feb 2026 16:55:16 +0000 (UTC) Received: from mail.galae.net (mail.galae.net [212.83.136.155]) by smtpout-01.galae.net (Postfix) with ESMTPS id 766025FDE6; Wed, 25 Feb 2026 16:55:16 +0000 (UTC) Received: from [127.0.0.1] (localhost [127.0.0.1]) by localhost (Mailerdaemon) with ESMTPSA id 2E6BB103692EF; Wed, 25 Feb 2026 17:55:14 +0100 (CET) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=bootlin.com; s=dkim; t=1772038515; h=from:subject:date:message-id:to:cc:mime-version:content-type: content-transfer-encoding:in-reply-to:references; bh=5DDlT1zh/U2lv9Nutzq4Z1uXsMIxCkm7M1Z/vhP6/jc=; b=YFKbFtpeR5kxPPQKtZiN9Uz3KAYaFRiqPa0nPcXEjGhIzDkkkWRVeoP2qeAK5yzlFV5ikd 7kCmQ7UMMjKK1AdXZeaeohFJwpy+pS9b64YM6cIkIZyGY8NyI91Y0wjUp9dFHft0sQW94A aQfYqBboGIUecti13wbO2EO7dn590qq3Bxy07esjzHERGCfy+lgegOlAFiNmObF8je2DYs gNwYwCd8mRgoSIoW0frTvB3lnFHTTUooJp6UR+dj+qfD/LLHbs1wBffY1NONsaLcSGku/w nfjfH2yKsdbIDx2RYMQYFZ6b7MfZnJL98aTMaWR5Vvf6bmEip9qZT0QK7DT+Hw== From: =?utf-8?q?Th=C3=A9o_Lebrun?= Date: Wed, 25 Feb 2026 17:55:07 +0100 Subject: [PATCH v7 3/3] reset: eyeq: drop device_set_of_node_from_dev() done by parent Precedence: bulk X-Mailing-List: linux-clk@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: 8bit Message-Id: <20260225-macb-phy-v7-3-665bd8619d51@bootlin.com> References: <20260225-macb-phy-v7-0-665bd8619d51@bootlin.com> In-Reply-To: <20260225-macb-phy-v7-0-665bd8619d51@bootlin.com> To: Michael Turquette , Stephen Boyd , Philipp Zabel Cc: linux-mips@vger.kernel.org, linux-clk@vger.kernel.org, linux-kernel@vger.kernel.org, Vladimir Kondratiev , Gregory CLEMENT , =?utf-8?q?Beno=C3=AEt_Monin?= , Tawfik Bayouk , Thomas Petazzoni , Luca Ceresoli , =?utf-8?q?Th=C3=A9o_Lebrun?= , Jerome Brunet X-Mailer: b4 0.14.3 X-Last-TLS-Session-Version: TLSv1.3 Our parent driver (clk-eyeq) now does the device_set_of_node_from_dev(dev, dev->parent) call through the newly introduced devm_auxiliary_device_create() helper. Doing it again in the reset-eyeq probe would be redundant. Drop both the WARN_ON() and the device_set_of_node_from_dev() call. Also fix the following comment that talks about "our newfound OF node". Signed-off-by: Jerome Brunet Reviewed-by: Philipp Zabel Acked-by: Philipp Zabel Signed-off-by: Théo Lebrun --- drivers/reset/reset-eyeq.c | 24 ++---------------------- 1 file changed, 2 insertions(+), 22 deletions(-) diff --git a/drivers/reset/reset-eyeq.c b/drivers/reset/reset-eyeq.c index 2d3998368a1c..8018fa895427 100644 --- a/drivers/reset/reset-eyeq.c +++ b/drivers/reset/reset-eyeq.c @@ -410,13 +410,6 @@ static int eqr_of_xlate_twocells(struct reset_controller_dev *rcdev, return eqr_of_xlate_internal(rcdev, reset_spec->args[0], reset_spec->args[1]); } -static void eqr_of_node_put(void *_dev) -{ - struct device *dev = _dev; - - of_node_put(dev->of_node); -} - static int eqr_probe(struct auxiliary_device *adev, const struct auxiliary_device_id *id) { @@ -427,21 +420,8 @@ static int eqr_probe(struct auxiliary_device *adev, int ret; /* - * We are an auxiliary device of clk-eyeq. We do not have an OF node by - * default; let's reuse our parent's OF node. - */ - WARN_ON(dev->of_node); - device_set_of_node_from_dev(dev, dev->parent); - if (!dev->of_node) - return -ENODEV; - - ret = devm_add_action_or_reset(dev, eqr_of_node_put, dev); - if (ret) - return ret; - - /* - * Using our newfound OF node, we can get match data. We cannot use - * device_get_match_data() because it does not match reused OF nodes. + * Get match data. We cannot use device_get_match_data() because it does + * not accept reused OF nodes; see device_set_of_node_from_dev(). */ match = of_match_node(dev->driver->of_match_table, dev->of_node); if (!match || !match->data) -- 2.53.0