* [PATCH] clk: qcom: gcc-ipq6018: mark gcc_xo_clk_src as critical
@ 2026-03-11 18:21 Christian Marangi
2026-03-16 14:20 ` Konrad Dybcio
2026-03-19 3:31 ` Bjorn Andersson
0 siblings, 2 replies; 3+ messages in thread
From: Christian Marangi @ 2026-03-11 18:21 UTC (permalink / raw)
To: Bjorn Andersson, Michael Turquette, Stephen Boyd, linux-arm-msm,
linux-clk, linux-kernel
Cc: John Crispin, Christian Marangi
From: John Crispin <john@phrozen.org>
The XO clock source is always-on in hardware and cannot be gated.
Without CLK_IS_CRITICAL, runtime PM of downstream consumers (such as
the CMN PLL driver) cascades a disable up to gcc_xo_clk_src, causing
a branch status timeout warning.
The IPQ8074 GCC driver already marks this clock as CLK_IS_CRITICAL.
Apply the same fix to IPQ6018.
Signed-off-by: John Crispin <john@phrozen.org>
Signed-off-by: Christian Marangi <ansuelsmth@gmail.com>
---
drivers/clk/qcom/gcc-ipq6018.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/drivers/clk/qcom/gcc-ipq6018.c b/drivers/clk/qcom/gcc-ipq6018.c
index d4fc491a18b2..6943dc511534 100644
--- a/drivers/clk/qcom/gcc-ipq6018.c
+++ b/drivers/clk/qcom/gcc-ipq6018.c
@@ -400,7 +400,7 @@ static struct clk_branch gcc_xo_clk_src = {
.fw_name = "xo",
},
.num_parents = 1,
- .flags = CLK_SET_RATE_PARENT,
+ .flags = CLK_SET_RATE_PARENT | CLK_IS_CRITICAL,
.ops = &clk_branch2_ops,
},
},
--
2.53.0
^ permalink raw reply related [flat|nested] 3+ messages in thread* Re: [PATCH] clk: qcom: gcc-ipq6018: mark gcc_xo_clk_src as critical
2026-03-11 18:21 [PATCH] clk: qcom: gcc-ipq6018: mark gcc_xo_clk_src as critical Christian Marangi
@ 2026-03-16 14:20 ` Konrad Dybcio
2026-03-19 3:31 ` Bjorn Andersson
1 sibling, 0 replies; 3+ messages in thread
From: Konrad Dybcio @ 2026-03-16 14:20 UTC (permalink / raw)
To: Christian Marangi, Bjorn Andersson, Michael Turquette,
Stephen Boyd, linux-arm-msm, linux-clk, linux-kernel
Cc: John Crispin
On 3/11/26 7:21 PM, Christian Marangi wrote:
> From: John Crispin <john@phrozen.org>
>
> The XO clock source is always-on in hardware and cannot be gated.
> Without CLK_IS_CRITICAL, runtime PM of downstream consumers (such as
> the CMN PLL driver) cascades a disable up to gcc_xo_clk_src, causing
> a branch status timeout warning.
>
> The IPQ8074 GCC driver already marks this clock as CLK_IS_CRITICAL.
> Apply the same fix to IPQ6018.
>
> Signed-off-by: John Crispin <john@phrozen.org>
> Signed-off-by: Christian Marangi <ansuelsmth@gmail.com>
> ---
Reviewed-by: Konrad Dybcio <konrad.dybcio@oss.qualcomm.com>
Konrad
^ permalink raw reply [flat|nested] 3+ messages in thread
* Re: [PATCH] clk: qcom: gcc-ipq6018: mark gcc_xo_clk_src as critical
2026-03-11 18:21 [PATCH] clk: qcom: gcc-ipq6018: mark gcc_xo_clk_src as critical Christian Marangi
2026-03-16 14:20 ` Konrad Dybcio
@ 2026-03-19 3:31 ` Bjorn Andersson
1 sibling, 0 replies; 3+ messages in thread
From: Bjorn Andersson @ 2026-03-19 3:31 UTC (permalink / raw)
To: Michael Turquette, Stephen Boyd, linux-arm-msm, linux-clk,
linux-kernel, Christian Marangi
Cc: John Crispin
On Wed, 11 Mar 2026 19:21:42 +0100, Christian Marangi wrote:
> The XO clock source is always-on in hardware and cannot be gated.
> Without CLK_IS_CRITICAL, runtime PM of downstream consumers (such as
> the CMN PLL driver) cascades a disable up to gcc_xo_clk_src, causing
> a branch status timeout warning.
>
> The IPQ8074 GCC driver already marks this clock as CLK_IS_CRITICAL.
> Apply the same fix to IPQ6018.
>
> [...]
Applied, thanks!
[1/1] clk: qcom: gcc-ipq6018: mark gcc_xo_clk_src as critical
commit: 27c7ec7ad7dbc7baeede6ca7429f294bc33cae13
Best regards,
--
Bjorn Andersson <andersson@kernel.org>
^ permalink raw reply [flat|nested] 3+ messages in thread
end of thread, other threads:[~2026-03-19 3:31 UTC | newest]
Thread overview: 3+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2026-03-11 18:21 [PATCH] clk: qcom: gcc-ipq6018: mark gcc_xo_clk_src as critical Christian Marangi
2026-03-16 14:20 ` Konrad Dybcio
2026-03-19 3:31 ` Bjorn Andersson
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox