From: Val Packett <val@packett.cool>
To: Bjorn Andersson <andersson@kernel.org>,
Michael Turquette <mturquette@baylibre.com>,
Stephen Boyd <sboyd@kernel.org>,
Vladimir Zapolskiy <vladimir.zapolskiy@linaro.org>,
Satya Priya Kakitapalli <quic_skakitap@quicinc.com>,
Dmitry Baryshkov <dmitry.baryshkov@oss.qualcomm.com>
Cc: Val Packett <val@packett.cool>,
Konrad Dybcio <konradybcio@kernel.org>,
Johan Hovold <johan+linaro@kernel.org>,
Manivannan Sadhasivam <mani@kernel.org>,
Dmitry Baryshkov <lumag@kernel.org>,
Maximilian Luz <luzmaximilian@gmail.com>,
linux-arm-msm@vger.kernel.org, linux-clk@vger.kernel.org,
linux-kernel@vger.kernel.org
Subject: [PATCH v2 09/11] clk: qcom: camcc-sc8180x: Remove wait_val for Titan GDSC
Date: Thu, 12 Mar 2026 08:12:14 -0300 [thread overview]
Message-ID: <20260312112321.370983-10-val@packett.cool> (raw)
In-Reply-To: <20260312112321.370983-1-val@packett.cool>
These values seem to have been copied from newer SoCs, but e.g. SC7180
and SDM845 do not use them. They seem to play a role in causing the
"titan_top_gdsc stuck at off" errors on boot on the Surface Pro X.
Remove to fix.
Fixes: 691f3413baa4 ("clk: qcom: camcc-sc8180x: Add SC8180X camera clock controller driver")
Signed-off-by: Val Packett <val@packett.cool>
---
drivers/clk/qcom/camcc-sc8180x.c | 3 ---
1 file changed, 3 deletions(-)
diff --git a/drivers/clk/qcom/camcc-sc8180x.c b/drivers/clk/qcom/camcc-sc8180x.c
index 388fedf1dc81..cd4c40a81c28 100644
--- a/drivers/clk/qcom/camcc-sc8180x.c
+++ b/drivers/clk/qcom/camcc-sc8180x.c
@@ -2538,9 +2538,6 @@ static struct clk_branch cam_cc_mclk7_clk = {
static struct gdsc titan_top_gdsc = {
.gdscr = 0xc1bc,
- .en_rest_wait_val = 0x2,
- .en_few_wait_val = 0x2,
- .clk_dis_wait_val = 0xf,
.pd = {
.name = "titan_top_gdsc",
},
--
2.52.0
next prev parent reply other threads:[~2026-03-12 11:24 UTC|newest]
Thread overview: 29+ messages / expand[flat|nested] mbox.gz Atom feed top
2026-03-12 11:12 [PATCH v2 00/11] clk: qcom: sc8180x: PM-related fixes (and refactoring) Val Packett
2026-03-12 11:12 ` [PATCH v2 01/11] dt-bindings: clock: qcom,gcc-sc8180x: Add missing GDSCs Val Packett
2026-03-13 10:09 ` Krzysztof Kozlowski
2026-03-12 11:12 ` [PATCH v2 02/11] clk: qcom: gcc-sc8180x: " Val Packett
2026-03-12 11:12 ` [PATCH v2 03/11] clk: qcom: gcc-sc8180x: Use retention for USB power domains Val Packett
2026-03-12 11:12 ` [PATCH v2 04/11] clk: qcom: gcc-sc8180x: Use retention for PCIe " Val Packett
2026-03-17 3:13 ` Manivannan Sadhasivam
2026-03-18 9:31 ` Konrad Dybcio
2026-03-12 11:12 ` [PATCH v2 05/11] clk: qcom: gcc-sc8180x: Enable runtime PM support Val Packett
2026-03-12 12:39 ` Dmitry Baryshkov
2026-03-12 11:12 ` [PATCH v2 06/11] clk: qcom: gcc-sc8180x: Refactor to use qcom_cc_driver_data Val Packett
2026-03-12 13:03 ` Dmitry Baryshkov
2026-03-13 10:45 ` Konrad Dybcio
2026-03-12 11:12 ` [PATCH v2 07/11] clk: qcom: dispcc-sm8250: Use shared ops on the mdss vsync clk Val Packett
2026-03-12 13:05 ` Dmitry Baryshkov
2026-03-12 11:12 ` [PATCH v2 08/11] clk: qcom: dispcc-sm8250: Enable parents for pixel clocks Val Packett
2026-03-12 13:14 ` Dmitry Baryshkov
2026-03-20 11:32 ` Marek Szyprowski
2026-03-12 11:12 ` Val Packett [this message]
2026-03-13 10:50 ` [PATCH v2 09/11] clk: qcom: camcc-sc8180x: Remove wait_val for Titan GDSC Konrad Dybcio
2026-03-13 16:10 ` Dmitry Baryshkov
2026-03-12 11:12 ` [PATCH v2 10/11] clk: qcom: camcc-sc8180x: Add missing HW_CTRL GDSC flag Val Packett
2026-03-13 10:53 ` Konrad Dybcio
2026-03-14 0:13 ` Val Packett
2026-03-16 9:24 ` Konrad Dybcio
2026-03-12 11:12 ` [PATCH v2 11/11] clk: qcom: camcc-sc8180x: Refactor to use qcom_cc_driver_data Val Packett
2026-03-12 13:14 ` Dmitry Baryshkov
2026-03-13 10:46 ` Konrad Dybcio
2026-03-19 2:46 ` (subset) [PATCH v2 00/11] clk: qcom: sc8180x: PM-related fixes (and refactoring) Bjorn Andersson
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20260312112321.370983-10-val@packett.cool \
--to=val@packett.cool \
--cc=andersson@kernel.org \
--cc=dmitry.baryshkov@oss.qualcomm.com \
--cc=johan+linaro@kernel.org \
--cc=konradybcio@kernel.org \
--cc=linux-arm-msm@vger.kernel.org \
--cc=linux-clk@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=lumag@kernel.org \
--cc=luzmaximilian@gmail.com \
--cc=mani@kernel.org \
--cc=mturquette@baylibre.com \
--cc=quic_skakitap@quicinc.com \
--cc=sboyd@kernel.org \
--cc=vladimir.zapolskiy@linaro.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox