public inbox for linux-clk@vger.kernel.org
 help / color / mirror / Atom feed
From: Maxime Ripard <mripard@kernel.org>
To: Abel Vesa <abel.vesa@oss.qualcomm.com>
Cc: Brian Masney <bmasney@redhat.com>,
	Jonathan Corbet <corbet@lwn.net>,
	 Shuah Khan <skhan@linuxfoundation.org>,
	Michael Turquette <mturquette@baylibre.com>,
	 Stephen Boyd <sboyd@kernel.org>, Abel Vesa <abelvesa@kernel.org>,
	 Hans de Goede <hansg@kernel.org>,
	Saravana Kannan <saravanak@kernel.org>,
	 linux-doc@vger.kernel.org, linux-kernel@vger.kernel.org,
	linux-clk@vger.kernel.org
Subject: Re: [PATCH] clk: add new Kconfig to control default behavior of disabling unused clocks
Date: Tue, 17 Mar 2026 14:15:50 +0100	[thread overview]
Message-ID: <20260317-notorious-classic-sunfish-d016d5@houat> (raw)
In-Reply-To: <com5zf4bfgb3eoelbmy5pfykhdow6ne3nteua6l7bnzkr72dsb@pehxxygji5z2>

[-- Attachment #1: Type: text/plain, Size: 1521 bytes --]

On Tue, Mar 17, 2026 at 02:14:25PM +0200, Abel Vesa wrote:
> On 26-03-17 08:30:24, Maxime Ripard wrote:
> > Hi,
> > 
> > On Mon, Mar 16, 2026 at 06:33:45PM -0400, Brian Masney wrote:
> > > At the 2023 Linux Plumbers Conference in Richmond VA, there was a
> > > discussion about how large number of systems need to boot with
> > > clk_ignore_unused. Per the discussions at the conference, the existing
> > > behavior in the clk core is broken, and there is a desire to completely
> > > remove this functionality.
> > 
> > Broken how?
> > 
> > clk_ignore_unused is to a point where it's seriously cargo-culted and
> > documented as a silver bullet, when in reality it's just a debug tool
> > for broken drivers, and the driver must be fixed.
> > 
> > But nobody is actually fixing it.
> > 
> > See
> > https://fedoraproject.org/wiki/Changes/Automatic_DTB_selection_for_aarch64_EFI_systems#How_To_Test
> > for example. The affected clock could be marked as CLK_IS_CRITICAL, and
> > fedora wouldn't have to package anything, change anything, etc. But no,
> > the problem is clk_ignore_unused.
> 
> Nope. Don't ever mark clocks as critical unless system crashes without
> them.
> 
> Here is an example or why clocks cannot be marked as critical but need
> to be kept by the clk_ignore_unused: display driver probes later.
> If you mark it as critical you just made the clock stay enabled even
> when display is off.
> 
> And this is just one example.

Then use CLK_IGNORE_UNUSED.

Maxime

[-- Attachment #2: signature.asc --]
[-- Type: application/pgp-signature, Size: 273 bytes --]

  parent reply	other threads:[~2026-03-17 13:15 UTC|newest]

Thread overview: 22+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2026-03-16 22:33 [PATCH] clk: add new Kconfig to control default behavior of disabling unused clocks Brian Masney
2026-03-17  7:30 ` Maxime Ripard
2026-03-17 11:53   ` Hans de Goede
2026-03-17 12:20     ` Brian Masney
2026-03-17 13:32     ` Maxime Ripard
2026-03-17 13:51       ` Abel Vesa
2026-03-17 14:02       ` Hans de Goede
2026-03-17 12:14   ` Abel Vesa
2026-03-17 12:16     ` Hans de Goede
2026-03-17 12:26       ` Brian Masney
2026-03-17 13:03         ` Abel Vesa
2026-03-17 13:18           ` Maxime Ripard
2026-03-17 13:22             ` Abel Vesa
2026-03-17 12:57       ` Abel Vesa
2026-03-17 13:15     ` Maxime Ripard [this message]
2026-03-17 13:21       ` Abel Vesa
2026-03-17 13:40         ` Maxime Ripard
2026-03-17 14:13         ` Brian Masney
2026-03-17 14:20           ` Abel Vesa
2026-03-17 15:00             ` Brian Masney
2026-03-17 15:14               ` Hans de Goede
2026-03-19  5:40             ` Jagadeesh Kona

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20260317-notorious-classic-sunfish-d016d5@houat \
    --to=mripard@kernel.org \
    --cc=abel.vesa@oss.qualcomm.com \
    --cc=abelvesa@kernel.org \
    --cc=bmasney@redhat.com \
    --cc=corbet@lwn.net \
    --cc=hansg@kernel.org \
    --cc=linux-clk@vger.kernel.org \
    --cc=linux-doc@vger.kernel.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=mturquette@baylibre.com \
    --cc=saravanak@kernel.org \
    --cc=sboyd@kernel.org \
    --cc=skhan@linuxfoundation.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox