From: Rosen Penev <rosenp@gmail.com>
To: linux-clk@vger.kernel.org
Cc: Krzysztof Kozlowski <krzk@kernel.org>,
Sylwester Nawrocki <s.nawrocki@samsung.com>,
Chanwoo Choi <cw00.choi@samsung.com>,
Alim Akhtar <alim.akhtar@samsung.com>,
Michael Turquette <mturquette@baylibre.com>,
Stephen Boyd <sboyd@kernel.org>, Kees Cook <kees@kernel.org>,
"Gustavo A. R. Silva" <gustavoars@kernel.org>,
linux-samsung-soc@vger.kernel.org (open list:SAMSUNG SOC CLOCK
DRIVERS), linux-kernel@vger.kernel.org (open list),
linux-hardening@vger.kernel.org (open list:KERNEL HARDENING (not
covered by other areas):Keyword:\b__counted_by(_le|_be)?\b)
Subject: [PATCH 2/3] clk: samsung: cpu: use kzalloc_flex
Date: Wed, 1 Apr 2026 20:04:31 -0700 [thread overview]
Message-ID: <20260402030432.101066-3-rosenp@gmail.com> (raw)
In-Reply-To: <20260402030432.101066-1-rosenp@gmail.com>
Use a flexible array member to combine allocations.
As kmemdup_array is really kcalloc + memcpy and kzalloc_flex kzalloc +
kcalloc, kzalloc and kcalloc combine leaving the memcpy.
Signed-off-by: Rosen Penev <rosenp@gmail.com>
---
drivers/clk/samsung/clk-cpu.c | 30 +++++++++++-------------------
1 file changed, 11 insertions(+), 19 deletions(-)
diff --git a/drivers/clk/samsung/clk-cpu.c b/drivers/clk/samsung/clk-cpu.c
index ffc33e5decf5..ad08d6288baa 100644
--- a/drivers/clk/samsung/clk-cpu.c
+++ b/drivers/clk/samsung/clk-cpu.c
@@ -101,11 +101,11 @@ struct exynos_cpuclk {
const struct clk_hw *alt_parent;
void __iomem *base;
spinlock_t *lock;
- const struct exynos_cpuclk_cfg_data *cfg;
const unsigned long num_cfgs;
struct notifier_block clk_nb;
unsigned long flags;
const struct exynos_cpuclk_chip *chip;
+ struct exynos_cpuclk_cfg_data cfg[];
};
/* ---- Common code --------------------------------------------------------- */
@@ -660,10 +660,6 @@ static int __init exynos_register_cpu_clock(struct samsung_clk_provider *ctx,
return -EINVAL;
}
- cpuclk = kzalloc_obj(*cpuclk);
- if (!cpuclk)
- return -ENOMEM;
-
parent_name = clk_hw_get_name(parent);
init.name = clk_data->name;
@@ -672,6 +668,15 @@ static int __init exynos_register_cpu_clock(struct samsung_clk_provider *ctx,
init.num_parents = 1;
init.ops = &exynos_cpuclk_clk_ops;
+ /* Find count of configuration rates in cfg */
+ for (num_cfgs = 0; clk_data->cfg[num_cfgs].prate != 0; )
+ num_cfgs++;
+
+ cpuclk = kzalloc_flex(*cpuclk, cfg, num_cfgs);
+ if (!cpuclk)
+ return -ENOMEM;
+
+ memcpy(cpuclk->cfg, clk_data->cfg, num_cfgs * sizeof(*cpuclk->cfg));
cpuclk->alt_parent = alt_parent;
cpuclk->hw.init = &init;
cpuclk->base = ctx->reg_base + clk_data->offset;
@@ -687,29 +692,16 @@ static int __init exynos_register_cpu_clock(struct samsung_clk_provider *ctx,
goto free_cpuclk;
}
- /* Find count of configuration rates in cfg */
- for (num_cfgs = 0; clk_data->cfg[num_cfgs].prate != 0; )
- num_cfgs++;
-
- cpuclk->cfg = kmemdup_array(clk_data->cfg, num_cfgs, sizeof(*cpuclk->cfg),
- GFP_KERNEL);
- if (!cpuclk->cfg) {
- ret = -ENOMEM;
- goto unregister_clk_nb;
- }
-
ret = clk_hw_register(NULL, &cpuclk->hw);
if (ret) {
pr_err("%s: could not register cpuclk %s\n", __func__,
clk_data->name);
- goto free_cpuclk_data;
+ goto unregister_clk_nb;
}
samsung_clk_add_lookup(ctx, &cpuclk->hw, clk_data->id);
return 0;
-free_cpuclk_data:
- kfree(cpuclk->cfg);
unregister_clk_nb:
clk_notifier_unregister(parent->clk, &cpuclk->clk_nb);
free_cpuclk:
--
2.53.0
next prev parent reply other threads:[~2026-04-02 3:04 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2026-04-02 3:04 [PATCH 0/3] clk: samsung: use kzalloc_flex Rosen Penev
2026-04-02 3:04 ` [PATCH 1/3] " Rosen Penev
2026-04-02 3:11 ` Gustavo A. R. Silva
2026-04-02 3:04 ` Rosen Penev [this message]
2026-04-02 3:04 ` [PATCH 3/3] clk: samsung: pll: " Rosen Penev
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20260402030432.101066-3-rosenp@gmail.com \
--to=rosenp@gmail.com \
--cc=alim.akhtar@samsung.com \
--cc=cw00.choi@samsung.com \
--cc=gustavoars@kernel.org \
--cc=kees@kernel.org \
--cc=krzk@kernel.org \
--cc=linux-clk@vger.kernel.org \
--cc=linux-hardening@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-samsung-soc@vger.kernel.org \
--cc=mturquette@baylibre.com \
--cc=s.nawrocki@samsung.com \
--cc=sboyd@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox