From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from smtp.kernel.org (aws-us-west-2-korg-mail-1.web.codeaurora.org [10.30.226.201]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id A82673B3C06; Wed, 13 May 2026 19:16:50 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=10.30.226.201 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1778699810; cv=none; b=av4mrMI1IfImBaz1RhPAOHCIgt7XI3XOWVTm7I2sFF5BWBzesJnJqDi5OF0r/1o5ISm0tLsjDmw0hiHis/7xppCzoib6STuMKm9W1WYxfcitlKmtsRDvA7jE8GP2mhf5OP+UZ+68JE8hoqsK/vTLRrTZS1rzs+xMtLsBNXNRDzc= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1778699810; c=relaxed/simple; bh=iJJNz6HXYxUUNPv3YiVGvW7CisErCC6b/AI/iBRLhSw=; h=Date:From:To:Cc:Subject:Message-ID:References:MIME-Version: Content-Type:Content-Disposition:In-Reply-To; b=l1PbSSMcVoL792Wj4tT6R1N+TtX/CoeXmzePBXvkde6TqUv1OJMp2gKVa/bsvyTk/4I/zeS/BkTFcUNo07GdDkx09n3o7vAdiarZIrb20ZAUB+PfpBPUfXlKAHd91JSVg7gG7sMbbKze8eYFUnHtk6bXDhjjf8ByEbCzQUtGfVs= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=kernel.org header.i=@kernel.org header.b=Z6OuiCq8; arc=none smtp.client-ip=10.30.226.201 Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=kernel.org header.i=@kernel.org header.b="Z6OuiCq8" Received: by smtp.kernel.org (Postfix) with ESMTPSA id 4BAA5C19425; Wed, 13 May 2026 19:16:46 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=k20201202; t=1778699810; bh=iJJNz6HXYxUUNPv3YiVGvW7CisErCC6b/AI/iBRLhSw=; h=Date:From:To:Cc:Subject:References:In-Reply-To:From; b=Z6OuiCq8h7MijIfztDY6J+WrxdHxFNtPzhozImiBFKWXr4RVkFOxosQZuzp1ZYavK ElWJajC62XL+KbcFm1qYm69qffyGzkK5nWZ5W4P8MqED0RCivwlQzriDlV9c7LiHcq j3tHQ6BVrEVEDyiF+ssBGaBeBrR+X41bpPPeWFGlfcO381xumDpZuZALJRKprODfkr FmV79SWkehR89ltZ4VWnqLGeNVDbA+doXtRjM9dU5oqCfe2rQCzMu28JbN33zdb3kR JTnUrdqjZUB3myunpwF0AdfZFFwK1BKOgMMaFVK/+DIAZGcwj3H4V4ZzBmEP8G2X6t A6R9QblpKZeew== Date: Wed, 13 May 2026 20:16:44 +0100 From: Conor Dooley To: Changhuang Liang Cc: Michael Turquette , Rob Herring , Krzysztof Kozlowski , Conor Dooley , Stephen Boyd , Brian Masney , Paul Walmsley , Palmer Dabbelt , Albert Ou , Alexandre Ghiti , Philipp Zabel , Emil Renner Berthing , Chen Wang , Inochi Amaoto , Alexey Charkov , Thomas Bogendoerfer , Keguang Zhang , "linux-clk@vger.kernel.org" , "linux-kernel@vger.kernel.org" , "devicetree@vger.kernel.org" , "linux-riscv@lists.infradead.org" Subject: Re: [PATCH v2 11/12] soc: starfive: Add socinfo driver for JHB100 SoC Message-ID: <20260513-headstand-hertz-bf31fe6c1938@spud> References: <20260512083521.3448-1-changhuang.liang@starfivetech.com> <20260512083521.3448-12-changhuang.liang@starfivetech.com> <20260512-mushroom-helpless-0815d0885abb@spud> Precedence: bulk X-Mailing-List: linux-clk@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Type: multipart/signed; micalg=pgp-sha512; protocol="application/pgp-signature"; boundary="wpszzjDaD+Si2T8W" Content-Disposition: inline In-Reply-To: --wpszzjDaD+Si2T8W Content-Type: text/plain; charset=us-ascii Content-Disposition: inline Content-Transfer-Encoding: quoted-printable On Wed, May 13, 2026 at 01:01:46AM +0000, Changhuang Liang wrote: > Hi, Conor >=20 > Thanks for the review. >=20 > > On Tue, May 12, 2026 at 01:35:20AM -0700, Changhuang Liang wrote: > > > Add socinfo driver for JHB100 SoC. Currently available for > > > distinguishing between the two reversions, A0 and A1. > > > > > > Signed-off-by: Changhuang Liang > > > --- > > > MAINTAINERS | 5 ++ > > > drivers/soc/Kconfig | 1 + > > > drivers/soc/Makefile | 1 + > > > drivers/soc/starfive/Kconfig | 6 ++ > > > drivers/soc/starfive/Makefile | 2 + > > > drivers/soc/starfive/socinfo/Kconfig | 11 +++ > > > drivers/soc/starfive/socinfo/Makefile | 2 + > > > drivers/soc/starfive/socinfo/jhb100-socinfo.c | 80 > > > +++++++++++++++++++ > > > 8 files changed, 108 insertions(+) > > > create mode 100644 drivers/soc/starfive/Kconfig create mode 100644 > > > drivers/soc/starfive/Makefile create mode 100644 > > > drivers/soc/starfive/socinfo/Kconfig > > > create mode 100644 drivers/soc/starfive/socinfo/Makefile > > > create mode 100644 drivers/soc/starfive/socinfo/jhb100-socinfo.c > > > > > > diff --git a/MAINTAINERS b/MAINTAINERS index > > > 6f6aac7cea95..66175f453d20 100644 > > > --- a/MAINTAINERS > > > +++ b/MAINTAINERS > > > @@ -25613,6 +25613,11 @@ S: Maintained > > > F: drivers/reset/starfive/reset-starfive-jhb1* > > > F: include/dt-bindings/reset/starfive,jhb1*.h > > > > > > +STARFIVE JHB100 SOCINFO DRIVER > > > +M: Changhuang Liang > > > +S: Maintained > > > +F: drivers/soc/starfive/ > >=20 > > FWIW, this is not what I asked for in v1, this should remain the full p= ath to the > > driver. I wanted you to add this directory back to the "STARFIVE SOC > > DRIVERS" entry, since it's me that'll be applying patches for this driv= er. >=20 > Sorry, I misunderstood what you meant. >=20 > >=20 > > > + > > > STARFIVE JHB100 SYSCON > > > M: Changhuang Liang > > > S: Maintained > > > diff --git a/drivers/soc/Kconfig b/drivers/soc/Kconfig index > > > a2d65adffb80..b3b01fc38139 100644 > > > --- a/drivers/soc/Kconfig > > > +++ b/drivers/soc/Kconfig > > > @@ -24,6 +24,7 @@ source "drivers/soc/renesas/Kconfig" > > > source "drivers/soc/rockchip/Kconfig" > > > source "drivers/soc/samsung/Kconfig" > > > source "drivers/soc/sophgo/Kconfig" > > > +source "drivers/soc/starfive/Kconfig" > > > source "drivers/soc/sunxi/Kconfig" > > > source "drivers/soc/tegra/Kconfig" >=20 > [...] >=20 > > > + pr_info("StarFive %s SoC rev(%s)\n", attrs->soc_id, > > > +attrs->revision); > > > + > > > + return 0; > > > +} > > > + > > > +early_initcall(starfive_socinfo_init); > >=20 > > Does this really need to be an early initcall btw? >=20 > Yes, there are some drivers that need to use soc_device_match() to match = different=20 > revisions, in order to handle the processes caused by differences between= revisions.=20 > So there's no harm in initializing this driver earlier. Other socinfo drivers use device_initcall, can you use that instead? --wpszzjDaD+Si2T8W Content-Type: application/pgp-signature; name="signature.asc" -----BEGIN PGP SIGNATURE----- iHUEABYKAB0WIQRh246EGq/8RLhDjO14tDGHoIJi0gUCagTOHAAKCRB4tDGHoIJi 0oebAQDHUz422QiNNBAozcQBRUUNetPwyzPv9mbhp5q6DhB6SgEA829KIXqQgaIA +5tVEGY9wkEQecJDp2etojerH/4Npwk= =dzjP -----END PGP SIGNATURE----- --wpszzjDaD+Si2T8W--