From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from smtp.kernel.org (aws-us-west-2-korg-mail-alma10-1.taild15c8.ts.net [100.103.45.18]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 5592E21ABD7; Wed, 20 May 2026 15:26:26 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=100.103.45.18 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1779290787; cv=none; b=D0FUAU8czOkY0AeaqLy6OrTkJQoWfubNJ9JG88MEoJlOAPomxtvF8o44yTtSWjtK79sc959Pltn9f300dyNUqKbEgVpm/BQbh01xROrK/hkQ6YmEoXTHOyzkJyqpzGJmoZ8GC2oavKKSr0LWr2KeVk5+j6HCB7CQGalmqubgwRo= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1779290787; c=relaxed/simple; bh=wlo7UvgwYP16eDLQsjqB5+4swMbRE2kBVvvln25PfYs=; h=Date:From:To:Cc:Subject:Message-ID:References:MIME-Version: Content-Type:Content-Disposition:In-Reply-To; b=NVeRPVDEUM+pLSn+F224QMJIucQlVSXB/YfzQyAmOZ9Tax/x5yDjXs3/fyhCy8Vf1vTUzrYa+1Zl9hLScXSb5ursZoHKs6EGJv4P7GFO/E12AdhY8LeHljL9GDbPYSJafhS5h3dr9FY19gzVjSFwYF7C5GcG9KS5rF+0XBNEeY8= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=kernel.org header.i=@kernel.org header.b=Utyz6gxc; arc=none smtp.client-ip=100.103.45.18 Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=kernel.org header.i=@kernel.org header.b="Utyz6gxc" Received: by smtp.kernel.org (Postfix) with ESMTPSA id 56FCD1F000E9; Wed, 20 May 2026 15:26:22 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=kernel.org; s=k20260515; t=1779290786; bh=VX5QXlO/FmCYpxFmNVmPdJNwz7Cx3UHOIbX66s/Mns0=; h=Date:From:To:Cc:Subject:References:In-Reply-To; b=Utyz6gxcGJ/e6rblW1DQ0G1pWtzHJG2lFS62wmEW3iLIWhn8CHeO7KI3ClxopW/Y/ SxRS9vFZZsFRfa997iibKorGr6b3JL4+cTTYbLv2e6intFRz9lkEIQmE8IGsVdsw8l bYdf3ckKyC8tLDdH3bM/D0zsHxveal8mXz0pOKPWSZahVf25w8rcY4rVKz/PE+SkiU g/WXTep89HTWJYh7pYAqsh49kSObGBk+kmHopqCQWrjZGbc09Uc0FhNGQ5EBvigCkR RaZHlyKcOy6ZhBBFgu8VmhWv4jSxpdCPOLT6SDObwbt1WlMkD2xP8BzZ/VfmS3mre3 z6aUT/LNKrJvA== Date: Wed, 20 May 2026 16:26:19 +0100 From: Lee Jones To: Cosmin-Gabriel Tanislav Cc: Biju Das , Daniel Lezcano , Thomas Gleixner , Rob Herring , Krzysztof Kozlowski , Conor Dooley , Geert Uytterhoeven , "magnus.damm" , Michael Turquette , Stephen Boyd , Philipp Zabel , "linux-iio@vger.kernel.org" , "linux-renesas-soc@vger.kernel.org" , "linux-kernel@vger.kernel.org" , "devicetree@vger.kernel.org" , "linux-clk@vger.kernel.org" Subject: Re: [PATCH v2 03/10] mfd: rz-mtu3: use device-managed mfd_add_devices() Message-ID: <20260520152619.GI2767592@google.com> References: <20260410163530.383818-1-cosmin-gabriel.tanislav.xa@renesas.com> <20260410163530.383818-4-cosmin-gabriel.tanislav.xa@renesas.com> <20260507124620.GJ305027@google.com> Precedence: bulk X-Mailing-List: linux-clk@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: On Thu, 07 May 2026, Cosmin-Gabriel Tanislav wrote: > > From: Lee Jones > > Sent: Thursday, May 7, 2026 3:46 PM > > > > On Fri, 10 Apr 2026, Cosmin Tanislav wrote: > > > > > Replace mfd_add_devices() and the custom cleanup action with > > > devm_mfd_add_devices(). > > > > > > Remove the ret variable as it is now unused. > > > > Do this first, then the changes in the first patch make more sense. > > > > Doing the devm_mfd_add_devices() conversion first would not be a simple > replacement, as devm_add_action_or_reset() would also need to be moved > before it to keep the intermediate patch correct. > > Otherwise, on release, the reset will be asserted before the MFD devices > are removed. Doing the reset conversion first fixes that without extra > logic changes. > > Alternatively, we can squash the two conversions to avoid the > intermediate states entirely, and remove struct rz_mtu3_priv::rstc in a > new separate patch. What do you think about this variant? As you wish. -- Lee Jones