From: Krzysztof Kozlowski <krzk@kernel.org>
To: Taniya Das <taniya.das@oss.qualcomm.com>
Cc: Bjorn Andersson <andersson@kernel.org>,
Michael Turquette <mturquette@baylibre.com>,
Stephen Boyd <sboyd@kernel.org>,
Brian Masney <bmasney@redhat.com>, Rob Herring <robh@kernel.org>,
Krzysztof Kozlowski <krzk+dt@kernel.org>,
Conor Dooley <conor+dt@kernel.org>,
Vivek Aknurwar <vivek.aknurwar@oss.qualcomm.com>,
Ajit Pandey <ajit.pandey@oss.qualcomm.com>,
Imran Shaik <imran.shaik@oss.qualcomm.com>,
Jagadeesh Kona <jagadeesh.kona@oss.qualcomm.com>,
linux-arm-msm@vger.kernel.org, linux-clk@vger.kernel.org,
devicetree@vger.kernel.org, linux-kernel@vger.kernel.org
Subject: Re: [PATCH 3/5] dt-bindings: clock: qcom: Add Maili global clock controller
Date: Mon, 22 Jun 2026 15:58:38 +0200 [thread overview]
Message-ID: <20260622-complex-dashing-gopher-9f43a3@quoll> (raw)
In-Reply-To: <20260618-maili_initial_clock-v1-3-d6ede0352113@oss.qualcomm.com>
On Thu, Jun 18, 2026 at 10:51:18PM +0530, Taniya Das wrote:
> clocks:
> items:
> diff --git a/include/dt-bindings/clock/qcom,hawi-gcc.h b/include/dt-bindings/clock/qcom,hawi-gcc.h
> index 6cd7fa0884f535efce90b60997662ca90cfb9b7e..9e0e382af3112b980997f0c7e223720517f12b02 100644
> --- a/include/dt-bindings/clock/qcom,hawi-gcc.h
> +++ b/include/dt-bindings/clock/qcom,hawi-gcc.h
> @@ -196,6 +196,16 @@
> #define GCC_VIDEO_AXI0C_CLK 186
> #define GCC_VIDEO_XO_CLK 187
>
> +/* Maili has below additional clocks on top of Hawi */
> +#define GCC_QUPV3_WRAP5_CORE_2X_CLK 188
> +#define GCC_QUPV3_WRAP5_CORE_CLK 189
> +#define GCC_QUPV3_WRAP5_QSPI_REF_CLK 190
> +#define GCC_QUPV3_WRAP5_QSPI_REF_CLK_SRC 191
> +#define GCC_QUPV3_WRAP5_S0_CLK 192
> +#define GCC_QUPV3_WRAP5_S0_CLK_SRC 193
> +#define GCC_QUPV3_WRAP_5_M_AHB_CLK 194
> +#define GCC_QUPV3_WRAP_5_S_AHB_CLK 195
I think this should be moved to its own header which will include the
qcom,hawi-gcc.h. We already do it for
include/dt-bindings/clock/qcom,sm8650-videocc.h.
Best regards,
Krzysztof
next prev parent reply other threads:[~2026-06-22 13:58 UTC|newest]
Thread overview: 11+ messages / expand[flat|nested] mbox.gz Atom feed top
2026-06-18 17:21 [PATCH 0/5] clk: qcom: Introduce initial clock controllers for Maili SoC Taniya Das
2026-06-18 17:21 ` [PATCH 1/5] dt-bindings: clock: qcom-rpmhcc: Add RPMH clock controller for Maili Taniya Das
2026-06-22 13:51 ` Krzysztof Kozlowski
2026-06-18 17:21 ` [PATCH 2/5] dt-bindings: clock: qcom: Add Maili TCSR clock controller Taniya Das
2026-06-22 13:56 ` Krzysztof Kozlowski
2026-06-18 17:21 ` [PATCH 3/5] dt-bindings: clock: qcom: Add Maili global " Taniya Das
2026-06-22 13:58 ` Krzysztof Kozlowski [this message]
2026-06-18 17:21 ` [PATCH 4/5] clk: qcom: gcc-hawi: Add support for global clock controller on Maili Taniya Das
2026-06-22 14:00 ` Konrad Dybcio
2026-06-18 17:21 ` [PATCH 5/5] dt-bindings: mailbox: qcom: Document Maili CPUCP mailbox controller Taniya Das
2026-06-22 13:59 ` Krzysztof Kozlowski
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20260622-complex-dashing-gopher-9f43a3@quoll \
--to=krzk@kernel.org \
--cc=ajit.pandey@oss.qualcomm.com \
--cc=andersson@kernel.org \
--cc=bmasney@redhat.com \
--cc=conor+dt@kernel.org \
--cc=devicetree@vger.kernel.org \
--cc=imran.shaik@oss.qualcomm.com \
--cc=jagadeesh.kona@oss.qualcomm.com \
--cc=krzk+dt@kernel.org \
--cc=linux-arm-msm@vger.kernel.org \
--cc=linux-clk@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=mturquette@baylibre.com \
--cc=robh@kernel.org \
--cc=sboyd@kernel.org \
--cc=taniya.das@oss.qualcomm.com \
--cc=vivek.aknurwar@oss.qualcomm.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox